[Awaiting checklist] [$250] mWeb/Chrome - Workspace - Invite button hidden behind keypad

@eh2077

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Launch both mweb and Android
Go to workspace -- invite members
Go offline and note no internet connection above
Select a member and tap next

Expected Result:

In mweb and Android, in offline inviting members, invite button should display in same way

Actual Result:

In mweb, invite button hidden behind keypad but in Android above keypad

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6622134_1727876595223.Screenrecorder-2024-10-02-19-02-53-462_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021841522414660630574
Upwork Job ID: 1841522414660630574
Last Price Increase: 2024-10-09
Automatic offers:

Nodebrute | Contributor | 104343060

Issue Owner

Current Issue Owner: @eh2077

@twisterdotcom

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@twisterdotcom

@twisterdotcom FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-10-02 15:35:19 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Invite button hidden behind keypad

What is the root cause of that problem?

We are not adding shouldEnableMaxHeight

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in 3946b22

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               testID={WorkspaceInviteMessagePage.displayName} 
        
           >

because of which it is not using it's 100 height%

Whether to use the maxHeight (true) or use the 100% of the height (false)

What changes do you think we should make in order to solve the problem?

We should add shouldEnableMaxHeight

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in 3946b22

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               testID={WorkspaceInviteMessagePage.displayName} 
        
           >

We should check for other places too where we have this issue. Other minor styling can be adjusted in the PR.

We have another issue here when we navigate from InviteMembersPage we can see that header is missing and there's a white space under the privacy. This is the only form page where we have this issue. To fix that we can use here

    const viewportOffsetTop = useViewportOffsetTop()

And then we can pass it as styles in screenWrapper here. We are also doing the same here

                style={{marginTop:viewportOffsetTop}}

Before

Screen.Recording.2024-10-02.at.11.37.17.PM.mov

After

Screen.Recording.2024-10-02.at.11.35.45.PM.mov

What alternative solutions did you explore? (Optional)

Or we can pass shouldEnableMaxHeight={DeviceCapabilities.canUseTouchScreen()}

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in 3946b22

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               testID={WorkspaceInviteMessagePage.displayName} 
        
           >

Optional: To fix extra padding under the form we can pass shouldEnableKeyboardAvoidingView={false} here

App/src/pages/workspace/WorkspaceInviteMessagePage.tsx

Lines 131 to 134 in c301698

    
           <ScreenWrapper 
        
               includeSafeAreaPaddingBottom={false} 
        
               testID={WorkspaceInviteMessagePage.displayName} 
        
           >

Proposal Updated
Added alternate solution

This isn't a problem I can recreate. I'd wager this is just due to the keyboard being used.

https://drive.google.com/file/d/1GPzlPbzYtM-eOsDgVXEyXGn3Io1YkOMF/view?usp=sharing

@twisterdotcom

@twisterdotcom I am able to repro this on latest main and it's very visible

Ios:mweb safari

Screen.Recording.2024-10-02.at.9.39.18.PM.mov

@Nodebrute

Ahh @Nodebrute are you on iOS there? I didn't test that, it wasn't included in the report. Let me double check then.

trim.E4224B6E-3D85-4A84-89B7-5BAEA7462262.MOV

@Nodebrute

Okay agreed. This has nothing to do with being offline/online either though. It just occurs regardless. Not sure what all the bottom padding is for either when you scroll with the keyboard in view. Can we fix that too @Nodebrute?

Reviewing label has been removed, please complete the "BugZero Checklist".

@Nodebrute

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

workspace invite submit #50581

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

@Nodebrute requires payment automatic offer (Contributor)
@eh2077 requires payment through NewDot Manual Requests

@eh2077

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@eh2077] The PR that introduced the bug has been identified. Link to the PR:
[@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@eh2077] Determine if we should create a regression test for this bug.
[@eh2077] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@Nodebrute

Payment Summary:

@Nodebrute paid $250 here (Contributor)
@eh2077 paid $250 via NewDot Manual Request

@twisterdotcom

@twisterdotcom @aldo-expensify @Nodebrute @eh2077 this issue is now 4 weeks old, please consider:

Finding a contributor to fix the bug
Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

@eh2077

Checklist

[@eh2077] The PR that introduced the bug has been identified. Link to the PR: After searching the commit histories, I don't think this is a bug introduced by a recent PR. It's more likely an edge case that was uncovered
[@eh2077] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
[@eh2077] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@eh2077] Determine if we should create a regression test for this bug. No, because it's a minor change of style and won't impact the main user flow.

Requested payment in NewDot

@eh2077

$250 approved for @eh2077

Navigation Menu

Repository navigation

[Awaiting checklist] [$250] mWeb/Chrome - Workspace - Invite button hidden behind keypad #50073

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

27 remaining items

Checklist

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	<ScreenWrapper
	includeSafeAreaPaddingBottom={false}
	testID={WorkspaceInviteMessagePage.displayName}
	>

[Awaiting checklist] [$250] mWeb/Chrome - Workspace - Invite button hidden behind keypad #50073

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 2, 2024

lanitochka17 commented on Oct 2, 2024

Nodebrute commented on Oct 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Nodebrute commented on Oct 2, 2024

twisterdotcom commented on Oct 2, 2024

Nodebrute commented on Oct 2, 2024

twisterdotcom commented on Oct 2, 2024

twisterdotcom commented on Oct 2, 2024

twisterdotcom commented on Oct 2, 2024

27 remaining items

melvin-bot commented on Oct 23, 2024

melvin-bot commented on Oct 23, 2024

melvin-bot commented on Oct 23, 2024

twisterdotcom commented on Oct 30, 2024

melvin-bot commented on Oct 30, 2024

eh2077 commented on Nov 4, 2024

Checklist

eh2077 commented on Nov 5, 2024

JmillsExpensify commented on Nov 5, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions