Skip to content

[HOLD for payment 2024-11-05] [$250] IOU - mWeb - User trying to upload receipt by quickly tapping capture button shows error #50083

New issue
New issue
Closed
Closed
[HOLD for payment 2024-11-05] [$250] IOU - mWeb - User trying to upload receipt by quickly tapping capture button shows error#50083
Assignees
marcochavezffedirjhChristinadobrzynQichenZhu
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 2, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.43-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Go to DM.
  3. Submit an expense.
  4. Go to transaction thread.
  5. Tap Add receipt modal.
  6. Quickly tap capture button many times before the camera is initiated.

Expected Result:

User trying to upload receipt by quickly tapping capture button must able to upload receipt.

Actual Result:

User trying to upload receipt by quickly tapping capture button shows error "The receipt didn't upload.Download the file or dismiss this error and lose it."

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6622046_1727886169840.Screenrecorder-2024-10-02-21-46-43-70_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021841557091803230884
  • Upwork Job ID: 1841557091803230884
  • Last Price Increase: 2024-10-02
  • Automatic offers:
    • QichenZhu | Contributor | 104415140
Issue OwnerCurrent Issue Owner: @Christinadobrzyn

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 2, 2024

  2. melvin-bot commented on Oct 2, 2024

    @melvin-bot
    melvin-botBot
    on Oct 2, 2024 – with Melvin Bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot
    assigned
    marcochavezf
    and
    Christinadobrzyn
    on Oct 2, 2024

  4. melvin-bot commented on Oct 2, 2024

    @melvin-bot
    melvin-botBot
    on Oct 2, 2024 – with Melvin Bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot
    added
    DailyKSv2
    on Oct 2, 2024
  6. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 2, 2024

  7. github-actions commented on Oct 2, 2024

    @github-actions
    github-actionsBot
    on Oct 2, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  8. marcochavezf commented on Oct 2, 2024

    @marcochavezf
    marcochavezf
    on Oct 2, 2024
    Contributor

    This is a frontend issue, making it external to get more 👀

  9. marcochavezf
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 2, 2024

  10. melvin-bot commented on Oct 2, 2024

    @melvin-bot
    melvin-botBot
    on Oct 2, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021841557091803230884

  11. melvin-bot
    changed the title [-]IOU - mWeb - User trying to upload receipt by quickly tapping capture button shows error[/-] [+][$250] IOU - mWeb - User trying to upload receipt by quickly tapping capture button shows error[/+] on Oct 2, 2024

  12. 43 remaining items

  13. melvin-bot
    added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    on Oct 29, 2024
  14. melvin-bot
    changed the title [-][$250] IOU - mWeb - User trying to upload receipt by quickly tapping capture button shows error[/-] [+][HOLD for payment 2024-11-05] [$250] IOU - mWeb - User trying to upload receipt by quickly tapping capture button shows error[/+] on Oct 29, 2024
  15. melvin-bot
    removed
    ReviewingHas a PR in review
    on Oct 29, 2024

  16. melvin-bot commented on Oct 29, 2024

    @melvin-bot
    melvin-botBot
    on Oct 29, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  17. melvin-bot commented on Oct 29, 2024

    @melvin-bot
    melvin-botBot
    on Oct 29, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.54-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-05. 🎊

    For reference, here are some details about the assignees on this issue:

  18. melvin-bot commented on Oct 29, 2024

    @melvin-bot
    melvin-botBot
    on Oct 29, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
    • [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@fedirjh] Determine if we should create a regression test for this bug.
    • [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/442076
  19. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Nov 4, 2024

  20. Christinadobrzyn commented on Nov 5, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Nov 5, 2024
    Contributor

    Payouts due:

    @fedirjh do we need a regression test for this?

  21. fedirjh commented on Nov 5, 2024

    @fedirjh
    fedirjh
    on Nov 5, 2024
    Contributor

    do we need a regression test for this?

    Yes.

    Regression Test Proposal

    Precondition: Camera permission is granted.

1. Open New Dot on mobile web or native app
2. Go to DM
3. Submit a manual expense
4. Go to transaction thread
5. Tap the receipt placeholder
6. Once you see the shutter button quickly tap it several times before the camera initializes
7. Verify that there is no error message or crash
    • Do we agree 👍 or 👎

  22. Christinadobrzyn commented on Nov 6, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Nov 6, 2024
    Contributor

    Awesome! payment day is today. Payment Summary.

    Regression test https://github.com/Expensify/Expensify/issues/442076

    @fedirjh can you please request payment through ND?

  23. Christinadobrzyn commented on Nov 7, 2024

    @Christinadobrzyn
    Christinadobrzyn
    on Nov 7, 2024
    Contributor

    DMd @fedirjh to request payment. Going to close this as complete since that's all that's outstanding.

  24. Christinadobrzyn
    closed this as completedon Nov 7, 2024
  25. github-project-automation
    moved this from Polish to Done in #expensify-bugson Nov 7, 2024

  26. garrettmknight commented on Dec 10, 2024

    @garrettmknight
    garrettmknight
    on Dec 10, 2024
    Contributor

    $250 approved for @fedirjh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions