[HOLD for payment 2024-10-22] Expense - "auto paid with Expensify" system message has <a href="link"> and </a> when pasted

@sakluger

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.43-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

Workspace has set up bank account.
Employee does not have personal bank account.

Go to staging.new.expensify.com
[Employee] Submit an expense in the workspace chat.
[Admin] Pay the expense via Expensify.
[Employee] Click on the expense preview.
[Employee] Click Add bank account button.
[Employee] Add a bank account.
[Employee] Right click on the system message "automatically paid $123.00 with Expensify via workspace rules" > Copy to clipboard.
[Employee] Paste the content in the composer.

Expected Result:

The content will be pasted correctly.

Actual Result:

The pasted content has <a href="link"> and </a>.
The system message also shows <a href="link"> and </a> when the report is opened for the first time (after relogin).

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6622263_1727884910251.first_time_open_report.mp4

Bug6622263_1727883711991.20241002_233604.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sakluger

@luacmartins

Triggered auto assignment to @luacmartins (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

We think that this bug might be related to #wave-collect - Release 1

Edited by proposal-police: This proposal was edited at 2024-10-02 18:27:11 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The pasted content has html anchor tag
The system message also shows html anchor tag when the report is opened for the first time (after relogin).

What is the root cause of that problem?

We're directly using anchor tags in copy:

App/src/languages/en.ts

Lines 928 to 929 in 66d1025

    
           automaticallyPaidWithExpensify: ({payer, amount}: PaidWithExpensifyWithAmountParams) => 
        
               `${payer ? `${payer} ` : ''}automatically paid ${amount} with Expensify via <a href="${CONST.CONFIGURE_REIMBURSEMENT_SETTINGS_HELP_URL}">workspace rules</a>`,

This is a BE bug where OpenApp returns the message's html as plain text:

causing the shouldRenderAsText here to be false (because html and text are the same in this case) and thus the iouMessage renders as plain text:

App/src/pages/home/report/comment/TextCommentFragment.tsx

Line 60 in 0de8f42

    
           if (!shouldRenderAsText(html, text ?? '') && !(containsOnlyEmojis && styleAsDeleted)) {

What changes do you think we should make in order to solve the problem?

We should use markdown link instead of html anchor tag like we did here:

...with Expensify via [workspace rules](${CONST.CONFIGURE_REIMBURSEMENT_SETTINGS_HELP_URL})

Fix the BE

@luacmartins

I don't know if this needs to be a deploy blocker, it's not really blocking users from completing actions in Expensify. @luacmartins what do you think?

Upwork offer: https://www.upwork.com/nx/wm/offer/104438278

I sent it from [$250] Payment issue for E/App PR#50059

@ishpaul777

@ishpaul777 do we need any regression new tests for this one?

@ishpaul777

Payment Summary

Upwork Job

ROLE: @ishpaul777 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@sakluger)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

@ishpaul777

This has already been paid in #50742.

@ishpaul777 let us know if we need any regression tests before we close the issue.

Sorry i missed ping, no i dont think we need regression becuase its found in normal QA process we might have tests covering this already

@sakluger

@sakluger Isn't #50742 a payment issue for different PR ?

Oh wow, you're right - I misread the issue number on that one. My mistake!

Here's an offer for this one: https://www.upwork.com/nx/wm/offer/104577466

@ishpaul777

Paid! Thanks again for staying on top of this @ishpaul777.

@Beamanator

@Beamanator @sakluger @luacmartins Be sure to fill out the Contact List!

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-22] Expense - "auto paid with Expensify" system message has <a href="link"> and </a> when pasted #50090

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

53 remaining items

Payment Summary

BugZero Checklist (@sakluger)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	automaticallyPaidWithExpensify: ({payer, amount}: PaidWithExpensifyWithAmountParams) =>
	`${payer ? `${payer} ` : ''}automatically paid ${amount} with Expensify via <a href="${CONST.CONFIGURE_REIMBURSEMENT_SETTINGS_HELP_URL}">workspace rules</a>`,

[HOLD for payment 2024-10-22] Expense - "auto paid with Expensify" system message has <a href="link"> and </a> when pasted #50090

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 2, 2024

melvin-bot commented on Oct 2, 2024

github-actions commented on Oct 2, 2024

IuliiaHerets commented on Oct 2, 2024

gijoe0295 commented on Oct 2, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

sakluger commented on Oct 2, 2024

53 remaining items

sakluger commented on Oct 17, 2024

sakluger commented on Oct 22, 2024

melvin-bot commented on Oct 22, 2024

Payment Summary

BugZero Checklist (@sakluger)

sakluger commented on Oct 23, 2024

ishpaul777 commented on Oct 23, 2024

ishpaul777 commented on Oct 23, 2024

sakluger commented on Oct 24, 2024

sakluger commented on Oct 24, 2024

melvin-bot commented on Oct 24, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions