Skip to content

[HOLD for payment 2024-10-14] [$125] Add "clear" button to saved search name field #50163

Closed

Description

@dannymcclain

Problem

Saved searches often have super long names, so when users go to rename them, it's cumbersome to clear the name input.

CleanShot 2024-10-03 at 10 27 02@2x

Solution

Let's add the "clear" button that we added to the Group name input to solve the same problem.

CleanShot 2024-10-03 at 10 27 52@2x

Notes

  • The clear button for the saved search name field should look and function identically to the one in the group name field.

cc @Expensify/design @roryabraham

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021841865344980745582
  • Upwork Job ID: 1841865344980745582
  • Last Price Increase: 2024-10-03
  • Automatic offers:
    • dukenv0307 | Reviewer | 104256804
    • nyomanjyotisa | Contributor | 104256806
Issue OwnerCurrent Issue Owner: @stephanieelliott

Activity

  1. added
    ExternalAdded to denote the issue can be worked on by a contributor
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 3, 2024
  2. changed the title [-]Add "clear" button to saved search name field[/-] [+][$250] Add "clear" button to saved search name field[/+] on Oct 3, 2024
  3. melvin-bot commented on Oct 3, 2024

    @melvin-bot
  4. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 3, 2024
  5. melvin-bot commented on Oct 3, 2024

    @melvin-bot

    Triggered auto assignment to @stephanieelliott (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. melvin-bot commented on Oct 3, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (External)

  7. nyomanjyotisa commented on Oct 3, 2024

    @nyomanjyotisa
    Member

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Add "clear" button to saved search name field

    What is the root cause of that problem?

    Change request

    What changes do you think we should make in order to solve the problem?

    Add shouldShowClearButton here

    <InputWrapper
    InputComponent={TextInput}
    inputID={INPUT_IDS.NAME}
    label={translate('search.searchName')}
    accessibilityLabel={translate('search.searchName')}
    role={CONST.ROLE.PRESENTATION}
    onChangeText={(renamedName) => setNewName(renamedName)}
    ref={inputCallbackRef}
    defaultValue={name}
    />

    What alternative solutions did you explore? (Optional)

  8. dukenv0307 commented on Oct 3, 2024

    @dukenv0307
    Contributor

    @nyomanjyotisa Since it's the new design, can you share the video/sceenshots

  9. nyomanjyotisa commented on Oct 3, 2024

    @nyomanjyotisa
    Member

    Here is the screenshot:

    image

    identically to the one in the group name field

    image

  10. 16 remaining items

  11. changed the title [-][$125] Add "clear" button to saved search name field[/-] [+][HOLD for payment 2024-10-14] [$125] Add "clear" button to saved search name field[/+] on Oct 7, 2024
  12. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-14. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
    • [@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@dukenv0307] Determine if we should create a regression test for this bug.
    • [@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  15. dukenv0307 commented on Oct 15, 2024

    @dukenv0307
    Contributor

    BugZero Checklist:

    • The PR that introduced the bug has been identified. Link to the PR: N/A
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. Yes
    • If we decide to create a regression test for the bug, please propose the [regression test steps to ensure the same bug will not reach production again.

    Regression test:

    1. Go to the Search Page
    2. Click on Filters on the top right
    3. Select one of the filter
    4. Save search
    5. On the saved section, rename the saved search
    6. Verify the clear button displayed on the search name field
  16. stephanieelliott commented on Oct 16, 2024

    @stephanieelliott
    Contributor
  17. self-assigned this
    on Oct 28, 2024
  18. dukenv0307 commented on Dec 3, 2024

    @dukenv0307
    Contributor

    @stephanieelliott Please help reopen the issue to handle payment, thank you.

  19. stephanieelliott commented on May 29, 2025

    @stephanieelliott
    Contributor

    I don't know how I missed payment on this one -- so so sorry for the long wait!

    Summarizing payment on this issue:

    Upwork job is here: https://www.upwork.com/jobs/~021841865344980745582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions