You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-14] [$125] Add "clear" button to saved search name field #50163
changed the title [-][$125] Add "clear" button to saved search name field[/-][+][HOLD for payment 2024-10-14] [$125] Add "clear" button to saved search name field[/+]on Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@dukenv0307] The PR that introduced the bug has been identified. Link to the PR:
[@dukenv0307] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@dukenv0307] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@dukenv0307] Determine if we should create a regression test for this bug.
[@dukenv0307] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The PR that introduced the bug has been identified. Link to the PR: N/A
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Determine if we should create a regression test for this bug. Yes
If we decide to create a regression test for the bug, please propose the [regression test steps to ensure the same bug will not reach production again.
Regression test:
Go to the Search Page
Click on Filters on the top right
Select one of the filter
Save search
On the saved section, rename the saved search
Verify the clear button displayed on the search name field
Activity
[-]Add "clear" button to saved search name field[/-][+][$250] Add "clear" button to saved search name field[/+]melvin-bot commentedon Oct 3, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021841865344980745582
melvin-bot commentedon Oct 3, 2024
Triggered auto assignment to @stephanieelliott (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 3, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @dukenv0307 (
External)nyomanjyotisa commentedon Oct 3, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Add "clear" button to saved search name field
What is the root cause of that problem?
Change request
What changes do you think we should make in order to solve the problem?
Add
shouldShowClearButtonhereApp/src/pages/Search/SavedSearchRenamePage.tsx
Lines 62 to 71 in 897da0e
What alternative solutions did you explore? (Optional)
dukenv0307 commentedon Oct 3, 2024
@nyomanjyotisa Since it's the new design, can you share the video/sceenshots
nyomanjyotisa commentedon Oct 3, 2024
Here is the screenshot:
identically to the one in the group name field
16 remaining items
[-][$125] Add "clear" button to saved search name field[/-][+][HOLD for payment 2024-10-14] [$125] Add "clear" button to saved search name field[/+]melvin-bot commentedon Oct 7, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.45-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 7, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
dukenv0307 commentedon Oct 15, 2024
BugZero Checklist:
Regression test:
stephanieelliott commentedon Oct 16, 2024
Thanks! Regression test issue here: https://github.com/Expensify/Expensify/issues/new
dukenv0307 commentedon Dec 3, 2024
@stephanieelliott Please help reopen the issue to handle payment, thank you.
stephanieelliott commentedon May 29, 2025
I don't know how I missed payment on this one -- so so sorry for the long wait!
Summarizing payment on this issue:
Upwork job is here: https://www.upwork.com/jobs/~021841865344980745582