You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list #50227
Version Number: 9.0.44-7 Reproducible in staging?: Y Reproducible in production?: Y Email or phone of affected tester (no customers):applausetester+pso@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Precondition:
User has saved a long list of searches.
Go to staging.new.expensify.com
Go to Search.
Scroll down the saved search list.
Expected Result:
The saved search list should be scrollable.
Actual Result:
The saved search list is not scrollable when there is a long list.
@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
This issue stems from the current PR and is still within the regression period. Wrapping SearchTypeMenu in Animated.View is causing the scroll to stop working.
changed the title [-]Saved search - Saved search list is not scrollable when there is a long list[/-][+][Search v2.3] - Saved search list is not scrollable when there is a long list[/+]on Oct 4, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
[@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Okay, original C+ who worked on the initial implementation implemented the fix, but there's a new C+ in this case (@ikevin127) and that's the only payment due here it seems, given the regression
changed the title [-][HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list[/-][+][$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list[/+]on Oct 14, 2024
[@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A.
[@ikevin127] Determine if we should create a regression test for this bug.
[@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
Regression Test Proposal
Precondition: User has saved a long list of searches.
Activity
melvin-bot commentedon Oct 4, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Oct 4, 2024
We think that this bug might be related to #wave-control
IuliiaHerets commentedon Oct 4, 2024
@greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
jayeshmangwani commentedon Oct 4, 2024
This issue stems from the current PR and is still within the regression period. Wrapping SearchTypeMenu in Animated.View is causing the scroll to stop working.
cc: @SzymczakJ @rayane-djouah @luacmartins
jayeshmangwani commentedon Oct 4, 2024
Its in production #48258 (comment)
rayane-d commentedon Oct 4, 2024
PR is here: #50244
cc @SzymczakJ @luacmartins
[-]Saved search - Saved search list is not scrollable when there is a long list[/-][+][Search v2.3] - Saved search list is not scrollable when there is a long list[/+]luacmartins commentedon Oct 4, 2024
Thanks.
11 remaining items
melvin-bot commentedon Oct 9, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
greg-schroeder commentedon Oct 14, 2024
Okay, original C+ who worked on the initial implementation implemented the fix, but there's a new C+ in this case (@ikevin127) and that's the only payment due here it seems, given the regression
[-][HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list[/-][+][$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list[/+]melvin-bot commentedon Oct 14, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021845946742438854336
melvin-bot commentedon Oct 14, 2024
Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.
greg-schroeder commentedon Oct 14, 2024
Sending you a manual offer that I'll pay on 10/16 @ikevin127
ikevin127 commentedon Oct 15, 2024
Regression Test Proposal
Precondition: User has saved a long list of searches.
Do we agree 👍 or 👎.