Skip to content

[$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list #50227

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.44-7
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • User has saved a long list of searches.
  1. Go to staging.new.expensify.com
  2. Go to Search.
  3. Scroll down the saved search list.

Expected Result:

The saved search list should be scrollable.

Actual Result:

The saved search list is not scrollable when there is a long list.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6624165_1728032604137.20241004_165905.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021845946742438854336
  • Upwork Job ID: 1845946742438854336
  • Last Price Increase: 2024-10-14

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 4, 2024
  2. melvin-bot commented on Oct 4, 2024

    @melvin-bot

    Triggered auto assignment to @greg-schroeder (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Oct 4, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-control

  4. IuliiaHerets commented on Oct 4, 2024

    @IuliiaHerets
    Author

    @greg-schroeder FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. jayeshmangwani commented on Oct 4, 2024

    @jayeshmangwani
    Contributor

    This issue stems from the current PR and is still within the regression period. Wrapping SearchTypeMenu in Animated.View is causing the scroll to stop working.

    cc: @SzymczakJ @rayane-djouah @luacmartins

  6. jayeshmangwani commented on Oct 4, 2024

    @jayeshmangwani
    Contributor

    Its in production #48258 (comment)

  7. rayane-d commented on Oct 4, 2024

    @rayane-d
    Contributor
  8. changed the title [-]Saved search - Saved search list is not scrollable when there is a long list[/-] [+][Search v2.3] - Saved search list is not scrollable when there is a long list[/+] on Oct 4, 2024
  9. luacmartins commented on Oct 4, 2024

    @luacmartins
    Contributor

    Thanks.

  10. 11 remaining items

  11. melvin-bot commented on Oct 9, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@ikevin127] The PR that introduced the bug has been identified. Link to the PR:
    • [@ikevin127] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@ikevin127] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@ikevin127] Determine if we should create a regression test for this bug.
    • [@ikevin127] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@greg-schroeder] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  12. greg-schroeder commented on Oct 14, 2024

    @greg-schroeder
    Contributor

    Okay, original C+ who worked on the initial implementation implemented the fix, but there's a new C+ in this case (@ikevin127) and that's the only payment due here it seems, given the regression

  13. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 14, 2024
  14. changed the title [-][HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list[/-] [+][$250] [HOLD for payment 2024-10-16] [Search v2.3] - Saved search list is not scrollable when there is a long list[/+] on Oct 14, 2024
  15. melvin-bot commented on Oct 14, 2024

    @melvin-bot
  16. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 14, 2024
  17. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    Current assignee @ikevin127 is eligible for the External assigner, not assigning anyone new.

  18. greg-schroeder commented on Oct 14, 2024

    @greg-schroeder
    Contributor

    Sending you a manual offer that I'll pay on 10/16 @ikevin127

  19. ikevin127 commented on Oct 15, 2024

    @ikevin127
    Contributor

    Regression Test Proposal

    Precondition: User has saved a long list of searches.

    1. Go to Search.
    2. Scroll down the saved search list.
    3. Verify that the saved search list is scrollable.

    Do we agree 👍 or 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions