You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-30] Expensify Card - Cards are not assigned in table for newly created accounts #50248
Invite a Gmail address that doesn't have an account yet
Navigate to Workspace settings - Expensify Card
Click on the "Issue new card" button
Add bank account details and finish the BA flow
Click on the "Issue new card" button
Select the new member
Select "Virtual card"
Add the card with any limit type, limit and name
Navigate to Workspace settings - Members
Click on the member added in step 7
Expected Result:
After assigning the card, it should be displayed in the cards table and assigned to the member.
Actual Result:
The virtual card is missing from the "Expensify Card" page and also from the workspace member profile page. I'm also unable to add a virtual card with the Workspace Member profile - New card flow.
Workaround:
No workaround found. No way to issue Ecards to new members
Platforms:
Which of our officially supported platforms is this issue occurring on?
Please re-state the problem that we are trying to solve in this issue.
Cards are not assigned in table for newly created accounts
What is the root cause of that problem?
The API response is not successful for new users with unvalidated account:
The card never gets assigned hence it doesn't get showed in table or member profile page.
What changes do you think we should make in order to solve the problem?
We should block the action to create virtual cards for unvalidated accounts. we can do so by showing the issuer a modal or by not showing the new user in the search list at all.
(for modal, we would need the design of how the error should look) and (for not showing we can just filter the list of assignees available by filtering out the unvalidated accounts here
Same can be done for other company card page if bug exists there too:
We will return early if the account is unvalidated:
Please re-state the problem that we are trying to solve in this issue.
Can't create a virtual card for an unvalidated account.
What is the root cause of that problem?
When attempting to create a virtual card for an unvalidated account, the backend returns the error message: "The assignee account has not been validated." However, this issue does not occur when creating a physical card. We should verify whether we need to prevent users from creating a physical card for an unvalidated account as well.
What changes do you think we should make in order to solve the problem?
In the assignee step page, we should filter out all unvalidated accounts from the list
The logic for retrieving the sections list in both files is identical. I recommend creating a utility function to obtain the assignee section and using it in both files.
In the Member Detail Page
We can disable the Issue Card button and show a label explaining why we can't issue a new card for this user. I believe this approach offers a better user experience by clearly communicating the reason for the restriction
The second option is to show a modal when the user tries to issue a card to an unvalidated account
What alternative solutions did you explore? (Optional)
@cretadn22 what exactly is different in your proposal than mine? I can just see that you have elaborated on what I wrote as a brief :)) and we require that every proposal should be unique
@isagoico can you please share the email used here and check if the accounts been validated or not? If you can see the response of the call that would be helpful in future too, whenever something is not happening as expected add console logs and network logs. Thanks
@mountiny I believe my proposal answers your question.
When attempting to create a virtual card for an unvalidated account, the backend returns the error message: "The assignee account has not been validated." However, this issue does not occur when creating a physical card. We should verify whether we need to prevent users from creating a physical card for an unvalidated account as well.
Should we allow assigning physical and virtual cars to unvalidated accounts?
changed the title [-]Expensify Card - Cards are not assigned in table for newly created accounts[/-][+][HOLD for payment 2024-10-30] Expensify Card - Cards are not assigned in table for newly created accounts[/+]on Oct 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@garrettmknight] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
The regression test for this was already handled as part of the workspace feeds project. The fix was in backend to ensure we return the card in the https response too so it show sup immediately.
I think we can close this one out as we have handled the payments for the project already
Activity
melvin-bot commentedon Oct 4, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.isagoico commentedon Oct 4, 2024
Note: We're able to assign cards to existing accounts. Take the following example from a test workspace:
I'm able to assign cards to applausetester+ig1@applause.expensifail.com but not to isagoicotest+newtest@gmail.com (new account.
twilight2294 commentedon Oct 4, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Cards are not assigned in table for newly created accounts
What is the root cause of that problem?
The API response is not successful for new users with unvalidated account:
The card never gets assigned hence it doesn't get showed in table or member profile page.
What changes do you think we should make in order to solve the problem?
We should block the action to create virtual cards for unvalidated accounts. we can do so by showing the issuer a
modalor by not showing the new user in the search list at all.(for modal, we would need the design of how the error should look) and (for not showing we can just filter the list of assignees available by filtering out the
unvalidated accountshereSame can be done for other company card page if bug exists there too:
We will return early if the account is unvalidated:
App/src/pages/workspace/expensifyCard/issueNew/AssigneeStep.tsx
Lines 80 to 84 in 10b8547
App/src/pages/workspace/expensifyCard/issueNew/AssigneeStep.tsx
Line 74 in 10b8547
What alternative solutions did you explore? (Optional)
cretadn22 commentedon Oct 5, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Can't create a virtual card for an unvalidated account.
What is the root cause of that problem?
When attempting to create a virtual card for an unvalidated account, the backend returns the error message: "The assignee account has not been validated." However, this issue does not occur when creating a physical card. We should verify whether we need to prevent users from creating a physical card for an unvalidated account as well.
What changes do you think we should make in order to solve the problem?
App/src/pages/workspace/expensifyCard/issueNew/AssigneeStep.tsx
Line 85 in 99f280b
I noticed that we have two files:
The logic for retrieving the sections list in both files is identical. I recommend creating a utility function to obtain the assignee section and using it in both files.
What alternative solutions did you explore? (Optional)
twilight2294 commentedon Oct 5, 2024
@cretadn22 what exactly is different in your proposal than mine? I can just see that you have elaborated on what I wrote as a brief :)) and we require that every proposal should be unique
We have that in contributor guidelines as well:
c.c. @dylanexpensify
mountiny commentedon Oct 6, 2024
@isagoico can you please share the email used here and check if the accounts been validated or not? If you can see the response of the call that would be helpful in future too, whenever something is not happening as expected add console logs and network logs. Thanks
cretadn22 commentedon Oct 7, 2024
@mountiny I believe my proposal answers your question.
Should we allow assigning physical and virtual cars to unvalidated accounts?
34 remaining items
melvin-bot commentedon Oct 22, 2024
@garrettmknight, @koko57, @mountiny, @DylanDylann Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
koko57 commentedon Oct 23, 2024
PR is merged, this issue can be retested
mountiny commentedon Oct 23, 2024
Asked for a retest here
[-]Expensify Card - Cards are not assigned in table for newly created accounts[/-][+][HOLD for payment 2024-10-30] Expensify Card - Cards are not assigned in table for newly created accounts[/+]melvin-bot commentedon Oct 23, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-30. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 23, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
mountiny commentedon Oct 24, 2024
The regression test for this was already handled as part of the workspace feeds project. The fix was in backend to ensure we return the card in the https response too so it show sup immediately.
I think we can close this one out as we have handled the payments for the project already