[HOLD for payment 2024-11-14] [$250] Search - Search icon is not responsive after tapping on room mention in Chat and exit chat

@alexpensify

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.45-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): applausetester+pso@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Go to workspace chat.
Send a message containing #admins room mention.
Go to Search > Chat.
Tap on the #admins mention.
Swipe to the right to close the chat.
Tap on the Search icon.

Expected Result:

User should be able to navigate to Search after swiping to right to close the room chat when it is opened from Search.

Actual Result:

Search icon is not responsive after tapping on room mention in Chat and closing the chat.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6626382_1728242537349.ScreenRecording_10-07-2024_03-17-45_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021847130088347504306
Upwork Job ID: 1847130088347504306
Last Price Increase: 2024-10-25
Automatic offers:

rayane-djouah | Reviewer | 104596829
Nodebrute | Contributor | 104596830

Issue Owner

Current Issue Owner: @alexpensify

@alexpensify

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think that this bug might be related to #wave-control

@alexpensify

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search icon is not responsive after tapping on room mention in Chat and exit chat

What is the root cause of that problem?

The first issue is that when we navigate back by swiping, we are returned to the Home screen instead of the Search screen. The second issue is that clicking on #admin or any room name on wide screens should open the report in the RHP, rather than navigating to it directly. It's because we navigate to ROUTES.REPORT_WITH_ID instead of ROUTES.SEARCH_REPORT

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 76 in 6d8e739

    
           const navigationRoute = reportID ? ROUTES.REPORT_WITH_ID.getRoute(reportID) : undefined;

What changes do you think we should make in order to solve the problem?

When a room mention is clicked from the search pane to address both issues, we should open the report in the RHP instead of navigating directly to it. We can do something like this

  let navigationRoute = reportID ? ROUTES.REPORT_WITH_ID.getRoute(reportID) : undefined;
    const topmostCentralPaneRoute = getTopmostCentralPaneRoute(navigationRef.getRootState() as State<RootStackParamList>)
    const backTo = Navigation.getActiveRoute();
    if(topmostCentralPaneRoute?.name === SCREENS.SEARCH.CENTRAL_PANE){
        navigationRoute = reportID ?  ROUTES.SEARCH_REPORT.getRoute({reportID,backTo}) :undefined
    }

In the above code we are checking with getTopmostCentralPaneRoute === searchpanel if yes then we will navigate to ROUTES.SEARCH

Note

This is just pseudo-code, and we can refine it further in the PR

Result ios

Screen.Recording.2024-10-07.at.2.10.18.AM.mov

Result (wide screen)

Screen.Recording.2024-10-07.at.2.10.37.AM.mov

What alternative solutions did you explore? (Optional)

Another alternative solution would be to use getUrlWithBackToParam

App/src/ROUTES.ts

Lines 266 to 269 in 6d8e739

    
           REPORT_WITH_ID: { 
        
               route: 'r/:reportID?/:reportActionID?', 
        
               getRoute: (reportID: string, reportActionID?: string, referrer?: string) => { 
        
                   const baseRoute = reportActionID ? (`r/${reportID}/${reportActionID}` as const) : (`r/${reportID}` as const);

and pass the active route here as backTo param

App/src/components/HTMLEngineProvider/HTMLRenderers/MentionReportRenderer/index.tsx

Line 76 in 6d8e739

    
           const navigationRoute = reportID ? ROUTES.REPORT_WITH_ID.getRoute(reportID) : undefined;

Other minor details can be addressed in the PR.

Adding this one to my test list and will get to it later this week.

@alexpensify

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

Still on my testing list

No update

@AndrewGable

@AndrewGable, @alexpensify, @rayane-djouah, @Nodebrute Whoops! This issue is 2 days overdue. Let's get this updated quick!

Thanks! I'll work on the QA test prep later this week.

Other GHs have been a priority; I'll work on the regression test soon.

@AndrewGable

@AndrewGable, @alexpensify, @rayane-djouah, @Nodebrute Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

With the slower week, I'll be working on the last step soon.

Closing - all set here

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-14] [$250] Search - Search icon is not responsive after tapping on room mention in Chat and exit chat #50317

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

56 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	REPORT_WITH_ID: {
	route: 'r/:reportID?/:reportActionID?',
	getRoute: (reportID: string, reportActionID?: string, referrer?: string) => {
	const baseRoute = reportActionID ? (`r/${reportID}/${reportActionID}` as const) : (`r/${reportID}` as const);

[HOLD for payment 2024-11-14] [$250] Search - Search icon is not responsive after tapping on room mention in Chat and exit chat #50317

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 6, 2024

IuliiaHerets commented on Oct 6, 2024

IuliiaHerets commented on Oct 6, 2024

Nodebrute commented on Oct 6, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alexpensify commented on Oct 7, 2024

melvin-bot commented on Oct 11, 2024

alexpensify commented on Oct 11, 2024

alexpensify commented on Oct 15, 2024

56 remaining items

melvin-bot commented on Nov 18, 2024

alexpensify commented on Nov 19, 2024

alexpensify commented on Nov 22, 2024

melvin-bot commented on Nov 25, 2024

alexpensify commented on Nov 25, 2024

alexpensify commented on Dec 3, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions