Skip to content

[Due for payment 2025-07-25] Write unit tests for updated ReportActionItem text depending on given originalMessage data #50351

Closed

Description

@Beamanator

Background:

strongly encouraged suggestion: Write some automated tests to cover this change. It's a very good candidate for unit tests, and they'd go a long way to make this code more robust and avoid it breaking in the future.

That ^ suggestion was given here and I agree we should write unit tests for the changes in that PR 👍 I'm going to make this external b/c it would be great to get external help on this 🙏

Expected Result:

Please add unit tests for:

  1. UI tests rendering <ReportActionItem> using @testing-library/react-native.
  2. Additional getReportName tests covering changes from Update "automatically approved" report action copy #49909

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 7, 2024
  2. self-assigned this
    on Oct 7, 2024
  3. melvin-bot commented on Oct 7, 2024

    @melvin-bot

    Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. Beamanator commented on Oct 7, 2024

    @Beamanator
    ContributorAuthor
  5. allgandalf commented on Oct 8, 2024

    @allgandalf
    Contributor

    @Beamanator should i wait for #49909 to get merged ?

  6. Beamanator commented on Oct 8, 2024

    @Beamanator
    ContributorAuthor

    Oh good call 😅 You caaaan start writing tests if you want, but obviously they shouldn't pass till #49909 is merged 😬

  7. Beamanator commented on Oct 8, 2024

    @Beamanator
    ContributorAuthor

    Boom, PR merged!

  8. allgandalf commented on Oct 11, 2024

    @allgandalf
    Contributor

    PR will be ready over the weekend 👍

  9. Christinadobrzyn commented on Oct 15, 2024

    @Christinadobrzyn
    Contributor

    Ooh - looks like PR is in production - #49909

    Adding a payment date to this GH.

  10. changed the title [-]Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data[/-] [+][Payment due Oct 18] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data[/+] on Oct 15, 2024
  11. 95 remaining items

  12. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.82-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-07-25. 🎊

    For reference, here are some details about the assignees on this issue:

    • @allgandalf requires $250 payment (Needs manual offer from BZ)
  13. melvin-bot commented on Jul 18, 2025

    @melvin-bot

    @allgandalf @Christinadobrzyn The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. Christinadobrzyn commented on Jul 23, 2025

    @Christinadobrzyn
    Contributor

    @allgandalf do we need a regression test?

  15. allgandalf commented on Jul 23, 2025

    @allgandalf
    Contributor

    nope, it was a No QA, so only pending payment

  16. changed the title [-][Due for payment 2025-07-25] [hold for #51296] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data[/-] [+][Due for payment 2025-07-25] Write unit tests for updated `ReportActionItem` text depending on given `originalMessage` data[/+] on Jul 25, 2025
  17. Christinadobrzyn commented on Jul 25, 2025

    @Christinadobrzyn
    Contributor

    Payment Summary

    Contributor+: @allgandalf due $250 via Upwork (https://www.upwork.com/nx/wm/workroom/41204947/overview)

    @allgandalf @Beamanator can you confirm this payment summary is accurate?

  18. allgandalf commented on Jul 25, 2025

    @allgandalf
    Contributor

    yes the above summary is correct!

  19. Christinadobrzyn commented on Jul 25, 2025

    @Christinadobrzyn
    Contributor

    Thanks @allgandalf - I paid you in Upwork. Payment summary here - #50351 (comment)

    No regression test needed, closing!

  20. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Jul 25, 2025
  21. moved this from Done to Hold for Payment in #expensify-bugson Jul 28, 2025
  22. moved this from Hold for Payment to Tracking in #expensify-bugson Jul 28, 2025
  23. moved this from Tracking to Done in #expensify-bugson Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions