Skip to content

[HOLD for payment 2024-10-25] Debug Mode - "Has RBR" is not shown for report that has RBR in LHN #50403

New issue
New issue
Closed
Closed
[HOLD for payment 2024-10-25] Debug Mode - "Has RBR" is not shown for report that has RBR in LHN#50403
Assignees
mountinypac-guerreiroadelekennedyDylanDylann
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 8, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.46-1
Reproducible in staging?: Y
Reproducible in production?: Unable to check Prod. There is no debug option in prod
Issue was found when executing this PR: #48442
Email or phone of affected tester (no customers): applausetester+ds@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Enable "Debug mode" in troubleshoot
  2. On home page, open a chat report from LHN that has a RBR
  3. Click on the header of the chat you just opened, then click on Debug

Expected Result:

On the Details tab, "Has RBR" is shown in "Visible in LHN" for report that has RBR in LHN

Actual Result:

On the Details tab, "Has GBR" is shown instead of "Has RBR" in "Visible in LHN" for report that has RBR in LHN. For reports that has GBR "has GBR" is shown.

Workaround:

Unknown

Platforms:

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6628206_1728383227811.Screen_Recording_2024-10-08_at_1.05.39_in_the_afternoon.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 8, 2024
  2. melvin-bot
    assigned
    carlosmiceli
    on Oct 8, 2024

  3. melvin-bot commented on Oct 8, 2024

    @melvin-bot
    melvin-botBot
    on Oct 8, 2024 – with Melvin Bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot
    assigned
    adelekennedy
    on Oct 8, 2024

  5. melvin-bot commented on Oct 8, 2024

    @melvin-bot
    melvin-botBot
    on Oct 8, 2024 – with Melvin Bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. melvin-bot
    added
    DailyKSv2
    on Oct 8, 2024
  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 8, 2024

  8. github-actions commented on Oct 8, 2024

    @github-actions
    github-actionsBot
    on Oct 8, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  9. mountiny
    added
    DailyKSv2
    and removed
    DeployBlockerCashThis issue or pull request should block deployment
    HourlyKSv2
    on Oct 8, 2024
  10. mountiny
    self-assigned this
    on Oct 8, 2024

  11. 15 remaining items

  12. melvin-bot
    changed the title [-]Debug Mode - "Has RBR" is not shown for report that has RBR in LHN[/-] [+][HOLD for payment 2024-10-25] Debug Mode - "Has RBR" is not shown for report that has RBR in LHN[/+] on Oct 18, 2024
  13. melvin-bot
    removed
    ReviewingHas a PR in review
    on Oct 18, 2024

  14. melvin-bot commented on Oct 18, 2024

    @melvin-bot
    melvin-botBot
    on Oct 18, 2024 – with Melvin Bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on Oct 18, 2024

    @melvin-bot
    melvin-botBot
    on Oct 18, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-25. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on Oct 18, 2024

    @melvin-bot
    melvin-botBot
    on Oct 18, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
    • [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@DylanDylann] Determine if we should create a regression test for this bug.
    • [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  17. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 25, 2024

  18. melvin-bot commented on Oct 25, 2024

    @melvin-bot
    melvin-botBot
    on Oct 25, 2024 – with Melvin Bot

    Payment Summary

    Upwork Job

    • Contributor: @pac-guerreiro is from an agency-contributor and not due payment
    • ROLE: @DylanDylann paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@adelekennedy)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct

  19. adelekennedy commented on Oct 28, 2024

    @adelekennedy
    adelekennedy
    on Oct 28, 2024
    Contributor

    Payouts due:

  20. adelekennedy commented on Oct 30, 2024

    @adelekennedy
    adelekennedy
    on Oct 30, 2024
    Contributor

    @DylanDylann bump also on the checklist

  21. DylanDylann commented on Oct 30, 2024

    @DylanDylann
    DylanDylann
    on Oct 30, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    [@DylanDylann] The PR that introduced the bug has been identified. Link to the PR: #48442
    [@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Just discussed with the author
    [@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
    [@DylanDylann] Determine if we should create a regression test for this bug. Yes
    [@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

    Regression Test Proposal

    1. Enable Debug mode in troubleshoot
    2. On home page, open a chat report from LHN that has a RBR
    3. Click on the header of the chat you just opened, then click on Debug
    4. On the Details tab, Has RBR is shown in Visible in LHN for report that has RBR in LHN

    Do we agree 👍 or 👎

  22. melvin-bot
    added
    Overdue
    on Nov 1, 2024

  23. melvin-bot commented on Nov 4, 2024

    @melvin-bot
    melvin-botBot
    on Nov 4, 2024 – with Melvin Bot

    @mountiny, @pac-guerreiro, @adelekennedy, @DylanDylann Huh... This is 4 days overdue. Who can take care of this?

  24. adelekennedy
    closed this as completedon Nov 6, 2024
  25. melvin-bot
    removed
    Overdue
    on Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions