[HOLD for payment 2024-11-26] [$250] Unable to Act on Report Due to Deleted Workspace, Stuck with RBR in Focus Mode Without Edit Access

@allgandalf

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.47-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @allgandalf
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1728540959841099

Action Performed:

Submit an expense with violation
Select focus mode in preferences
Delete the Workspace where the expenses was submitted
Observe LHN

Expected Result:

Report in archived status

Actual Result:

See RBR in LHN with the report, but cannot act on it as don't have edit access anymore to that report, but also cannot do anything here, it stays in my LHN

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Recording.642.mp4

Onyx data:

{ "chatReportID": "4695747423350738", "chatType": "", "currency": "INR", "description": "", "errorFields": {}, "hasOutstandingChildRequest": false, "hasOutstandingChildTask": false, "hasParentAccess": true, "isCancelledIOU": false, "isOwnPolicyExpenseChat": false, "isPinned": false, "isWaitingOnBankAccount": false, "lastActionType": "CLOSED", "lastActorAccountID": "16559988", "lastMessageHtml": "closed this report", "lastMessageText": "closed this report", "lastReadSequenceNumber": 0, "lastReadTime": "2024-10-10 06:16:13.007", "lastVisibleActionCreated": "2024-04-08 08:54:26.839", "lastVisibleActionLastModified": "2024-04-08 08:54:26.839", "managerID": 0, "nonReimbursableTotal": 0, "notificationPreference": "hidden", "oldPolicyName": "Whogandalf's Workspace 27", "ownerAccountID": 16559988, "parentReportActionID": "6007246625411673721", "parentReportID": "4695747423350738", "participants": { "16559988": { "hidden": true, "notificationPreference": "hidden" } }, "permissions": [], "policyID": "3DEDDF79F054B00A", "private_isArchived": "2024-07-18 11:24:28.169", "reportID": "4817250283487348", "reportName": "Expense Report #5426340451518743", "stateNum": 2, "statusNum": 2, "total": 0, "type": "expense", "unheldTotal": 0, "welcomeMessage": "", "writeCapability": "all", "isLoadingPrivateNotes": false, "privateNotes": { "16559988": { "note": "" } } }

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021845769561131002585
Upwork Job ID: 1845769561131002585
Last Price Increase: 2024-10-21
Automatic offers:

allgandalf | Reviewer | 104576294

Issue Owner

Current Issue Owner: @

Issue Owner

Current Issue Owner: @sonialiap

@sonialiap

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@sonialiap

Note

Can i be the C+ for this issue @sonialiap , I reported this bug and have prior context

Edited by proposal-police: This proposal was edited at 2024-10-17 14:42:26 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The RBR still shows for deleted workspace chat and its expense report and thread.

What is the root cause of that problem?

There are 3 RBRs here. 1 in LHN,

App/src/libs/OptionsListUtils.ts

Lines 489 to 527 in 8f90bf8

    
           function getAllReportActionsErrorsAndReportActionThatRequiresAttention(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): ReportErrorsAndReportActionThatRequiresAttention { 
        
               const reportActionsArray = Object.values(reportActions ?? {}); 
        
               const reportActionErrors: OnyxCommon.ErrorFields = {}; 
        
               let reportAction: OnyxEntry<ReportAction>; 
        
               for (const action of reportActionsArray) { 
        
                   if (action && !isEmptyObject(action.errors)) { 
        
                       Object.assign(reportActionErrors, action.errors); 
        
                       if (!reportAction) { 
        
                           reportAction = action; 
        
                       } 
        
                   } 
        
               } 
        
               const parentReportAction: OnyxEntry<ReportAction> = 
        
                   !report?.parentReportID || !report?.parentReportActionID ? undefined : allReportActions?.[report.parentReportID ?? '-1']?.[report.parentReportActionID ?? '-1']; 
        
               if (ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionUtils.isTransactionThread(parentReportAction)) { 
        
                   const transactionID = ReportActionUtils.isMoneyRequestAction(parentReportAction) ? ReportActionUtils.getOriginalMessage(parentReportAction)?.IOUTransactionID : null; 
        
                   const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`]; 
        
                   if (TransactionUtils.hasMissingSmartscanFields(transaction ?? null) && !ReportUtils.isSettled(transaction?.reportID)) { 
        
                       reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage'); 
        
                       reportAction = undefined; 
        
                   } 
        
               } else if ((ReportUtils.isIOUReport(report) || ReportUtils.isExpenseReport(report)) && report?.ownerAccountID === currentUserAccountID) { 
        
                   if (ReportUtils.shouldShowRBRForMissingSmartscanFields(report?.reportID ?? '-1') && !ReportUtils.isSettled(report?.reportID)) { 
        
                       reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage'); 
        
                       reportAction = ReportUtils.getReportActionWithMissingSmartscanFields(report?.reportID ?? '-1'); 
        
                   } 
        
               } else if (ReportUtils.hasSmartscanError(reportActionsArray)) { 
        
                   reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage'); 
        
                   reportAction = ReportUtils.getReportActionWithSmartscanError(reportActionsArray); 
        
               } 
        
               return { 
        
                   errors: reportActionErrors, 
        
                   reportAction, 
        
               }; 
        
           }

1 in report preview,

App/src/components/ReportActionItem/ReportPreview.tsx

Lines 162 to 168 in 8f90bf8

    
           const hasErrors = 
        
               (hasMissingSmartscanFields && !iouSettled) || 
        
               // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing 
        
               ReportUtils.hasViolations(iouReportID, transactionViolations) || 
        
               ReportUtils.hasWarningTypeViolations(iouReportID, transactionViolations) || 
        
               (ReportUtils.isReportOwner(iouReport) && ReportUtils.hasReportViolations(iouReportID)) || 
        
               ReportUtils.hasActionsWithErrors(iouReportID);

and 1 in the expense/transaction preview.

App/src/components/ReportActionItem/MoneyRequestPreview/MoneyRequestPreviewContent.tsx

Line 147 in 8f90bf8

    
           const shouldShowRBR = hasNoticeTypeViolations || hasViolations || hasFieldErrors || (!isFullySettled && !isFullyApproved && isOnHold) || hasDuplicates;

None of the conditions check for the report archive status. The expense report will stay on the LHN because we always show it if there are errors other than failed receipt.

App/src/libs/SidebarUtils.ts

Lines 121 to 135 in 8f90bf8

    
           const hasErrorsOtherThanFailedReceipt = 
        
               doesTransactionThreadReportHasViolations || 
        
               doesReportHaveViolations || 
        
               Object.values(allReportErrors).some((error) => error?.[0] !== Localize.translateLocal('iou.error.genericSmartscanFailureMessage')); 
        
           const isReportInAccessible = report?.errorFields?.notFound; 
        
           if (ReportUtils.isOneTransactionThread(report.reportID, report.parentReportID ?? '0', parentReportAction)) { 
        
               return; 
        
           } 
        
           if (hasErrorsOtherThanFailedReceipt && !isReportInAccessible) { 
        
               reportsToDisplay.push({ 
        
                   ...report, 
        
                   hasErrorsOtherThanFailedReceipt: true, 
        
               }); 
        
               return; 
        
           }

Why do the workspace chat and expense/transaction thread not show even if they have the RBR? The reportActions in `SidebarUtils.getOrderedReportIDs is coming from

App/src/hooks/useReportIDs.tsx

Line 87 in 5f1ea58

    
           const [allReportActions] = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS, {selector: (c) => mapOnyxCollectionItems(c, reportActionsSelector)});

and somehow the selector that was recently added in #49918 returns a wrong array of actions. For the transaction thread, the parent report action here is undefined,

App/src/libs/OptionsListUtils.ts

Lines 503 to 504 in 5f1ea58

    
           const parentReportAction: OnyxEntry<ReportAction> = 
        
               !report?.parentReportID || !report?.parentReportActionID ? undefined : allReportActions?.[report.parentReportID ?? '-1']?.[report.parentReportActionID ?? '-1'];

so, isTransactionThread is always false. It's undefined because we access the allReportActions object without appending the reportActions_ key prefix.

App/src/libs/OptionsListUtils.ts

Line 506 in 5f1ea58

    
           if (ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionUtils.isTransactionThread(parentReportAction)) {

What changes do you think we should make in order to solve the problem?

We need to check for the report archive status when getting all report errors.

App/src/libs/ReportUtils.ts

Lines 6303 to 6318 in 20b7017

    
           if (ReportActionsUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionsUtils.isTransactionThread(parentReportAction)) { 
        
               const transactionID = ReportActionsUtils.isMoneyRequestAction(parentReportAction) ? ReportActionsUtils.getOriginalMessage(parentReportAction)?.IOUTransactionID : null; 
        
               const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`]; 
        
               if (TransactionUtils.hasMissingSmartscanFields(transaction ?? null) && !isSettled(transaction?.reportID)) { 
        
                   reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage'); 
        
                   reportAction = undefined; 
        
               } 
        
           } else if ((isIOUReport(report) || isExpenseReport(report)) && report?.ownerAccountID === currentUserAccountID) { 
        
               if (shouldShowRBRForMissingSmartscanFields(report?.reportID ?? '-1') && !isSettled(report?.reportID)) { 
        
                   reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage'); 
        
                   reportAction = getReportActionWithMissingSmartscanFields(report?.reportID ?? '-1'); 
        
               } 
        
           } else if (hasSmartscanError(reportActionsArray)) { 
        
               reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage'); 
        
               reportAction = getReportActionWithSmartscanError(reportActionsArray); 
        
           }

if (!ReportUtils.isArchivedRoom(report)) {
    ...
}

@sonialiap

Note

Can i be the C+ for this issue @sonialiap , I reported this bug and have prior context

Job added to Upwork: https://www.upwork.com/jobs/~021845769561131002585

@bernhardoj

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.63-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Don't show RBR if workspace is archived #51561

If no regressions arise, payment will be issued on 2024-11-26. 🎊

For reference, here are some details about the assignees on this issue:

@bernhardoj requires payment through NewDot Manual Requests
@allgandalf requires payment automatic offer (Reviewer)
@allgandalf requires payment automatic offer (Reviewer)

@allgandalf

@allgandalf @sonialiap @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@allgandalf

@allgandalf please complete the checklist so that I can release the payment for you tomorrow 😊

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/50468/files#r1857277702
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue: https://github.com/Expensify/Expensify/issues/448193

Regression Test Proposal

Precondition:

Have a workspace created

Test:

Open a workspace chat
Submit an expense that will show RBR (for example scan expense with a random image)
Delete the workspace

Verify the workspace chat doesn't show RBR anymore

Do we agree 👍 or 👎

@allgandalf

@allgandalf please complete the checklist so that I can release the payment for you tomorrow 😊

Sorry for the delay 😅 , I completed the checklist !

Requested in ND.

Waiting for payment summary.

@bernhardoj

Payment summary:

@bernhardoj $250 via ND
@allgandalf $250 paid via upwork ✔️

@JmillsExpensify

@JmillsExpensify good to approve the ND request 💰

@bernhardoj

$250 approved for @bernhardoj

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-26] [$250] Unable to Act on Report Due to Deleted Workspace, Stuck with RBR in Focus Mode Without Edit Access #50573

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

44 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function getAllReportActionsErrorsAndReportActionThatRequiresAttention(report: OnyxEntry<Report>, reportActions: OnyxEntry<ReportActions>): ReportErrorsAndReportActionThatRequiresAttention {
	const reportActionsArray = Object.values(reportActions ?? {});
	const reportActionErrors: OnyxCommon.ErrorFields = {};
	let reportAction: OnyxEntry<ReportAction>;

	for (const action of reportActionsArray) {
	if (action && !isEmptyObject(action.errors)) {
	Object.assign(reportActionErrors, action.errors);

	if (!reportAction) {
	reportAction = action;
	}
	}
	}
	const parentReportAction: OnyxEntry<ReportAction> =
	!report?.parentReportID \|\| !report?.parentReportActionID ? undefined : allReportActions?.[report.parentReportID ?? '-1']?.[report.parentReportActionID ?? '-1'];

	if (ReportActionUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionUtils.isTransactionThread(parentReportAction)) {
	const transactionID = ReportActionUtils.isMoneyRequestAction(parentReportAction) ? ReportActionUtils.getOriginalMessage(parentReportAction)?.IOUTransactionID : null;
	const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
	if (TransactionUtils.hasMissingSmartscanFields(transaction ?? null) && !ReportUtils.isSettled(transaction?.reportID)) {
	reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
	reportAction = undefined;
	}
	} else if ((ReportUtils.isIOUReport(report) \|\| ReportUtils.isExpenseReport(report)) && report?.ownerAccountID === currentUserAccountID) {
	if (ReportUtils.shouldShowRBRForMissingSmartscanFields(report?.reportID ?? '-1') && !ReportUtils.isSettled(report?.reportID)) {
	reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
	reportAction = ReportUtils.getReportActionWithMissingSmartscanFields(report?.reportID ?? '-1');
	}
	} else if (ReportUtils.hasSmartscanError(reportActionsArray)) {
	reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
	reportAction = ReportUtils.getReportActionWithSmartscanError(reportActionsArray);
	}

	return {
	errors: reportActionErrors,
	reportAction,
	};
	}

	const hasErrors =
	(hasMissingSmartscanFields && !iouSettled) \|\|
	// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
	ReportUtils.hasViolations(iouReportID, transactionViolations) \|\|
	ReportUtils.hasWarningTypeViolations(iouReportID, transactionViolations) \|\|
	(ReportUtils.isReportOwner(iouReport) && ReportUtils.hasReportViolations(iouReportID)) \|\|
	ReportUtils.hasActionsWithErrors(iouReportID);

	const hasErrorsOtherThanFailedReceipt =
	doesTransactionThreadReportHasViolations \|\|
	doesReportHaveViolations \|\|
	Object.values(allReportErrors).some((error) => error?.[0] !== Localize.translateLocal('iou.error.genericSmartscanFailureMessage'));
	const isReportInAccessible = report?.errorFields?.notFound;
	if (ReportUtils.isOneTransactionThread(report.reportID, report.parentReportID ?? '0', parentReportAction)) {
	return;
	}
	if (hasErrorsOtherThanFailedReceipt && !isReportInAccessible) {
	reportsToDisplay.push({
	...report,
	hasErrorsOtherThanFailedReceipt: true,
	});
	return;
	}

	if (ReportActionsUtils.wasActionTakenByCurrentUser(parentReportAction) && ReportActionsUtils.isTransactionThread(parentReportAction)) {
	const transactionID = ReportActionsUtils.isMoneyRequestAction(parentReportAction) ? ReportActionsUtils.getOriginalMessage(parentReportAction)?.IOUTransactionID : null;
	const transaction = allTransactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`];
	if (TransactionUtils.hasMissingSmartscanFields(transaction ?? null) && !isSettled(transaction?.reportID)) {
	reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
	reportAction = undefined;
	}
	} else if ((isIOUReport(report) \|\| isExpenseReport(report)) && report?.ownerAccountID === currentUserAccountID) {
	if (shouldShowRBRForMissingSmartscanFields(report?.reportID ?? '-1') && !isSettled(report?.reportID)) {
	reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
	reportAction = getReportActionWithMissingSmartscanFields(report?.reportID ?? '-1');
	}
	} else if (hasSmartscanError(reportActionsArray)) {
	reportActionErrors.smartscan = ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('iou.error.genericSmartscanFailureMessage');
	reportAction = getReportActionWithSmartscanError(reportActionsArray);
	}

[HOLD for payment 2024-11-26] [$250] Unable to Act on Report Due to Deleted Workspace, Stuck with RBR in Focus Mode Without Edit Access #50573

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 10, 2024

allgandalf commented on Oct 10, 2024

bernhardoj commented on Oct 10, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

allgandalf commented on Oct 10, 2024

melvin-bot commented on Oct 14, 2024

44 remaining items

melvin-bot commented on Nov 19, 2024

melvin-bot commented on Nov 19, 2024

sonialiap commented on Nov 25, 2024

allgandalf commented on Nov 25, 2024

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

allgandalf commented on Nov 25, 2024

bernhardoj commented on Nov 26, 2024

JmillsExpensify commented on Nov 26, 2024

sonialiap commented on Nov 27, 2024

sonialiap commented on Nov 27, 2024

JmillsExpensify commented on Nov 27, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions