You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-29] [$62.50] Android - Chat search - Unable to reach the bottom of chat list when scrolling down #50649
Version Number: 9.0.48-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):applausetester+kh081006@applause.expensifail.com Issue reported by: Applause - Internal Team
Action Performed:
Launch New Expensify app
Go to any chat
Send many messages (so that the All list in Search > Chat is scrollable)
Go to Search > Chat
Scroll down the list in All tab
Expected Result:
The bottom of the chat list can be reached
Actual Result:
User is unable to reach the bottom of chat list
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6631850_1728651988839.1728651753636_Screen_Recording_20241011_210108_New_Expensify.mp4
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Android - Chat search - Unable to reach the bottom of chat list when scrolling down[/-][+][$250] Android - Chat search - Unable to reach the bottom of chat list when scrolling down[/+]on Oct 11, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
[@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@mkhutornyi] Determine if we should create a regression test for this bug.
[@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
Regression Test Proposal
Open Search page
Switch to Chat tab. (filter so the results are not too long)
Scroll to the bottom of the list
Verify the last item is fully visible
(tbh I think we can skip regression test since this is android-only and minor style issue)
Activity
melvin-bot commentedon Oct 11, 2024
Triggered auto assignment to @joekaufmanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Oct 11, 2024
@joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
lanitochka17 commentedon Oct 11, 2024
We think that this bug might be related to #wave-control
bernhardoj commentedon Oct 11, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The bottom of the chat list can't be fully shown.
What is the root cause of that problem?
We have a contentContainerStyle to the search list which adds a margin top. It's to offset the list from the page header which was added in #48258.
App/src/pages/Search/SearchPageBottomTab.tsx
Line 134 in 45a3a13
However, because we use a margin, the height of the list is reduced by the amount of the margin-top (116).
What changes do you think we should make in order to solve the problem?
Use paddingTop instead of marginTop. It will offset the top but won't reduce the visible height on the screen.
App/src/styles/index.ts
Lines 3649 to 3651 in 2f1b6f1
joekaufmanexpensify commentedon Oct 11, 2024
Reproduced. A very minor issue, but an issue nonetheless. I think we can fix this, but should be lower budget, as is very minor change.
[-]Android - Chat search - Unable to reach the bottom of chat list when scrolling down[/-][+][$250] Android - Chat search - Unable to reach the bottom of chat list when scrolling down[/+]melvin-bot commentedon Oct 11, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021844817953624508019
melvin-bot commentedon Oct 11, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (
External)21 remaining items
melvin-bot commentedon Oct 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
joekaufmanexpensify commentedon Oct 28, 2024
@mkhutornyi could you complete BZ here so we can prep for payment?
mkhutornyi commentedon Oct 28, 2024
Regression Test Proposal
(tbh I think we can skip regression test since this is android-only and minor style issue)
joekaufmanexpensify commentedon Oct 29, 2024
Agreed. Skipping regression test makes sense to me here. TY for completing checklist!
joekaufmanexpensify commentedon Oct 29, 2024
All set to issue payment here. We need to pay:
bernhardoj commentedon Oct 29, 2024
Requested in ND.
joekaufmanexpensify commentedon Oct 29, 2024
TY!
joekaufmanexpensify commentedon Oct 29, 2024
@mkhutornyi $62.50 sent and contract ended
joekaufmanexpensify commentedon Oct 29, 2024
All set. Thanks everyone!
melvin-bot commentedon Oct 29, 2024
@marcochavezf @joekaufmanexpensify Be sure to fill out the Contact List!
JmillsExpensify commentedon Oct 30, 2024
$62.50 approved for @bernhardoj