Skip to content

[HOLD for payment 2024-10-29] [$62.50] Android - Chat search - Unable to reach the bottom of chat list when scrolling down #50649

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

  1. Launch New Expensify app
  2. Go to any chat
  3. Send many messages (so that the All list in Search > Chat is scrollable)
  4. Go to Search > Chat
  5. Scroll down the list in All tab

Expected Result:

The bottom of the chat list can be reached

Actual Result:

User is unable to reach the bottom of chat list

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6631850_1728651988839.1728651753636_Screen_Recording_20241011_210108_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021844817953624508019
  • Upwork Job ID: 1844817953624508019
  • Last Price Increase: 2024-10-11
  • Automatic offers:
    • mkhutornyi | Reviewer | 104433861
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 11, 2024
  2. melvin-bot commented on Oct 11, 2024

    @melvin-bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Oct 11, 2024

    @lanitochka17
    Author

    @joekaufmanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. lanitochka17 commented on Oct 11, 2024

    @lanitochka17
    Author

    We think that this bug might be related to #wave-control

  5. bernhardoj commented on Oct 11, 2024

    @bernhardoj
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    The bottom of the chat list can't be fully shown.

    What is the root cause of that problem?

    We have a contentContainerStyle to the search list which adds a margin top. It's to offset the list from the page header which was added in #48258.

    contentContainerStyle={!selectionMode?.isEnabled ? [styles.searchListContentContainerStyles] : undefined}

    However, because we use a margin, the height of the list is reduced by the amount of the margin-top (116).

    What changes do you think we should make in order to solve the problem?

    Use paddingTop instead of marginTop. It will offset the top but won't reduce the visible height on the screen.

    App/src/styles/index.ts

    Lines 3649 to 3651 in 2f1b6f1

    searchListContentContainerStyles: {
    marginTop: variables.searchListContentMarginTop,
    },

  6. joekaufmanexpensify commented on Oct 11, 2024

    @joekaufmanexpensify
    Contributor

    Reproduced. A very minor issue, but an issue nonetheless. I think we can fix this, but should be lower budget, as is very minor change.

  7. changed the title [-]Android - Chat search - Unable to reach the bottom of chat list when scrolling down[/-] [+][$250] Android - Chat search - Unable to reach the bottom of chat list when scrolling down[/+] on Oct 11, 2024
  8. melvin-bot commented on Oct 11, 2024

    @melvin-bot
  9. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 11, 2024
  10. melvin-bot commented on Oct 11, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

  11. 21 remaining items

  12. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@mkhutornyi] The PR that introduced the bug has been identified. Link to the PR:
    • [@mkhutornyi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@mkhutornyi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@mkhutornyi] Determine if we should create a regression test for this bug.
    • [@mkhutornyi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. joekaufmanexpensify commented on Oct 28, 2024

    @joekaufmanexpensify
    Contributor

    @mkhutornyi could you complete BZ here so we can prep for payment?

  14. mkhutornyi commented on Oct 28, 2024

    @mkhutornyi
    Contributor

    Regression Test Proposal

    1. Open Search page
    2. Switch to Chat tab. (filter so the results are not too long)
    3. Scroll to the bottom of the list
    4. Verify the last item is fully visible

    (tbh I think we can skip regression test since this is android-only and minor style issue)

  15. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    Contributor

    Agreed. Skipping regression test makes sense to me here. TY for completing checklist!

  16. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    Contributor

    All set to issue payment here. We need to pay:

  17. bernhardoj commented on Oct 29, 2024

    @bernhardoj
    Contributor

    Requested in ND.

  18. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    Contributor

    TY!

  19. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    Contributor

    @mkhutornyi $62.50 sent and contract ended

  20. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    Contributor

    All set. Thanks everyone!

  21. moved this from Release 3: Fall 2024 (Nov) to Done in #expensify-bugson Oct 29, 2024
  22. melvin-bot commented on Oct 29, 2024

    @melvin-bot
  23. JmillsExpensify commented on Oct 30, 2024

    @JmillsExpensify
    Contributor

    $62.50 approved for @bernhardoj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions