Skip to content

[HOLD for payment 2025-01-15] [HOLD for payment 2024-12-25] Benchmark performance bottlenecks when opening chats #50652

New issue
New issue
Closed
Closed
[HOLD for payment 2025-01-15] [HOLD for payment 2024-12-25] Benchmark performance bottlenecks when opening chats#50652
Assignees
hannojgmountinyadhorodyskilaurenreidexpensifyrayane-d
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Description

@adhorodyski
adhorodyski
opened on Oct 11, 2024

Coming from the discussion thread under https://expensify.slack.com/archives/C05LX9D6E07/p1728314452317409

Problem

Lack of solid performance benchmarks across the core app workflows, baselines for proposing performance improvements.

Solution

  • Focus on 1 scenario of opening a chat
  • Benchmark it in detail to get the granular results (also for each phase) so we have solid numbers for whom specifically it's slow and why. There are also analytics we can use for this to have more datapoints.
  • Pinpoint the areas for improvement we see
  • Map how the proposal from initial thread/nitro modules/anything other can fit to improve it

cc @hannojg

Issue OwnerCurrent Issue Owner: @laurenreidexpensify
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021873115691475801087
  • Upwork Job ID: 1873115691475801087
  • Last Price Increase: 2024-12-28

Activity

  1. adhorodyski commented on Oct 11, 2024

    @adhorodyski
    adhorodyski
    on Oct 11, 2024
    ContributorAuthor

    @mountiny could you please assign this one to me & @hannojg? Thanks!

  2. hannojg commented on Oct 11, 2024

    @hannojg
    hannojg
    on Oct 11, 2024
    Contributor

    Thanks! 👋

  3. mountiny
    assigned
    hannojg
    and
    adhorodyski
    on Oct 14, 2024
  4. mountiny
    added this to [#whatsnext] #qualityon Oct 14, 2024
  5. mountiny
    moved this to LOW in [#whatsnext] #qualityon Oct 14, 2024
  6. melvin-bot
    added
    MonthlyKSv2
    on Oct 14, 2024
  7. muttmuure
    moved this from LOW to HIGH in [#whatsnext] #qualityon Oct 15, 2024

  8. adhorodyski commented on Oct 16, 2024

    @adhorodyski
    adhorodyski
    on Oct 16, 2024
    ContributorAuthor

    Update
    Our bottom line is to get super solid on what precisely is slow (have granular measurements) and for whom specifically.

    Who
    To be able to say how many people something affects (in different percentiles), we need to have something to segment by. We'll extend our performance analytics' metadata (in all envs, including e2e tests) to include the below fields. These will help us group measurements by the types of accounts. (PR: #50881)

    • number of reports ✅
    • number of reportActions 🔄
    • number of personalDetails ✅
    • number of policies 🔄
    • number of transactions 🔄
    • number of transactionViolations 🔄

    What
    To be able to pinpoint what exactly is slow, we'll implement granular metrics in code, across both App & Onyx. Here's a breakdown of all the phases we decided to focus on.

    • APPLYING_UPDATES (coming over https, until we schedule notifying subscribers)
      • DATABASE_WRITE (actual save operations like multiset and multimerge)
    • NOTIFYING_SUBSCRIBERS (multiple key(s)Changed triggered by scheduleNotifyCollectionSubscribers)
      • DATABASE_READ
      • REACT_PROVIDER - (useOnyx/withOnyx)
    • ONYX_DATA_POSTPROCESSING (from receiving a new update (subscriber got called) until we have the final data)

    How
    TBC

  9. adhorodyski commented on Oct 16, 2024

    @adhorodyski
    adhorodyski
    on Oct 16, 2024
    ContributorAuthor

    cc @mountiny we'd like to ask you for any feedback about this 1st batch (please invite others!). Is there an area we're missing? I want to make sure we focus on the right parts when profiling this, the exact tools (like e2e suites) will come next once we fully agree on the who&what.

  10. melvin-bot
    added
    ReviewingHas a PR in review
    WeeklyKSv2
    and removed
    MonthlyKSv2
    WeeklyKSv2
    on Oct 21, 2024

  11. 108 remaining items

  12. mountiny commented on Jan 22, 2025

    @mountiny
    mountiny
    on Jan 22, 2025
    Contributor

    @adhorodyski if you mean this #50652 (comment) yes lets try to follow up

  13. laurenreidexpensify commented on Jan 23, 2025

    @laurenreidexpensify
    laurenreidexpensify
    on Jan 23, 2025
    Contributor

    @rayane-djouah are you onboarded yet for payment?

  14. melvin-bot
    removed
    Overdue
    on Jan 23, 2025

  15. rayane-d commented on Jan 23, 2025

    @rayane-d
    rayane-d
    on Jan 23, 2025
    Contributor

    @laurenreidexpensify Not yet. Could you please check the status with the team?

  16. laurenreidexpensify commented on Jan 27, 2025

    @laurenreidexpensify
    laurenreidexpensify
    on Jan 27, 2025
    Contributor

    @rayane-djouah have done, am bumping the team to get it resolved today 👍

  17. rayane-d commented on Jan 29, 2025

    @rayane-d
    rayane-d
    on Jan 29, 2025
    Contributor

    @laurenreidexpensify Resolved! Could you kindly provide a payment summary?

  18. garrettmknight commented on Jan 29, 2025

    @garrettmknight
    garrettmknight
    on Jan 29, 2025
    Contributor

    @laurenreidexpensify got the payment request in ND, just need the payment summary when you get a chance. 😄

  19. laurenreidexpensify
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Feb 3, 2025
  20. melvin-bot
    added
    Overdue
    on Feb 3, 2025

  21. laurenreidexpensify commented on Feb 3, 2025

    @laurenreidexpensify
    laurenreidexpensify
    on Feb 3, 2025
    Contributor

    payment summary

    @rayane-d $250 C+ please request in ND

  22. laurenreidexpensify
    closed this as completedon Feb 3, 2025
  23. melvin-bot
    removed
    Overdue
    on Feb 3, 2025
  24. github-project-automation
    moved this from HIGH to Done in [#whatsnext] #qualityon Feb 3, 2025

  25. garrettmknight commented on Feb 3, 2025

    @garrettmknight
    garrettmknight
    on Feb 3, 2025
    Contributor

    $250 approved for @rayane-d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNewFeatureSomething to build that is a new item.

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions