Skip to content

[HOLD for payment 2024-10-24] [HOLD for payment 2024-10-22] iOS - IOU - Page flickers when selecting different payment option on IOU preview #50722

Closed

Description

@izarutskaya

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.48.0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5077885
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

  1. Open the Hybrid app/NewDot app and log in as user A
  2. On a secondary device as user B send an IOU to user A
  3. On main device as user A open the chat with user B
  4. Select a different payment option on the IOU preview

Expected Result:

The page does not flicker when changing a payment option

Actual Result:

The page flickers when changing a payment option. It also occurs on the transaction details.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6633027_1728764651785.IMG_0436.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @VictoriaExpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerIndicates it should block deploying the API
    on Oct 14, 2024
  2. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 14, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 14, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. izarutskaya commented on Oct 14, 2024

    @izarutskaya
    Author

    Production

    RPReplay_Final1728909064.MP4
  7. izarutskaya commented on Oct 14, 2024

    @izarutskaya
    Author

    I'm not sure what Deploy.. labels is needed since there is no option Use Staging Served in the Hybrid App

  8. 18 remaining items

  9. changed the title [-]iOS - IOU - Page flickers when selecting different payment option on IOU preview[/-] [+][HOLD for payment 2024-10-22] iOS - IOU - Page flickers when selecting different payment option on IOU preview[/+] on Oct 15, 2024
  10. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.48-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-22. 🎊

  12. melvin-bot commented on Oct 15, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dangrous] The PR that introduced the bug has been identified. Link to the PR:
    • [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@dangrous] Determine if we should create a regression test for this bug.
    • [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. dangrous commented on Oct 15, 2024

    @dangrous
    Contributor

    Closing this, it was a revert (and internal) so no regression period needed.

  14. changed the title [-][HOLD for payment 2024-10-22] iOS - IOU - Page flickers when selecting different payment option on IOU preview[/-] [+][HOLD for payment 2024-10-24] [HOLD for payment 2024-10-22] iOS - IOU - Page flickers when selecting different payment option on IOU preview[/+] on Oct 17, 2024
  15. melvin-bot commented on Oct 17, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.49-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-24. 🎊

  16. melvin-bot commented on Oct 17, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@dangrous] The PR that introduced the bug has been identified. Link to the PR:
    • [@dangrous] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@dangrous] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@dangrous] Determine if we should create a regression test for this bug.
    • [@dangrous] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions