Skip to content

[Avatars] - Fix ReportPreview Avatar Patterns #50763

Closed

Description

@grgia

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Context

The ReportPreview Avatar code depends on BE or FE data depending on the report type. This has resulted in avatars and report preview headers breaking frequently.

The logic was nearly solved by this PR - #49172 which changed the logic to use the ownerID for reportPreviews as well as adding a calculation for This worked for all cases except the Send Money Flow where the ownerID is the payee, which is not the original actor.

Solution:

  • Define the rules for avatars as below and have design check them off
  • Define what data we need for avatars and send it in the reportpreview object (similar to how we send childReportActorID)
  • Send the avatar data from the BE and use that for the report preview case
  • Use this flow to create a UI-based test rail for these avatars / headers to prevent future regressions

View all open jobs on GitHub

Activity

  1. self-assigned this
    on Oct 15, 2024
  2. melvin-bot commented on Oct 18, 2024

    @melvin-bot

    @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

  3. added and removed on Oct 21, 2024
  4. grgia commented on Oct 21, 2024

    @grgia
    ContributorAuthor

    Not overdue and not daily

  5. grgia commented on Nov 1, 2024

    @grgia
    ContributorAuthor

    Not overdue

  6. grgia commented on Nov 11, 2024

    @grgia
    ContributorAuthor

    ^

  7. 5 remaining items

  8. grgia commented on Dec 18, 2024

    @grgia
    ContributorAuthor

    IOS build is broken

  9. grgia commented on Jan 8, 2025

    @grgia
    ContributorAuthor

    Still ^

  10. grgia commented on Jan 24, 2025

    @grgia
    ContributorAuthor

    ^

  11. added and removed on Feb 6, 2025
  12. grgia commented on Feb 6, 2025

    @grgia
    ContributorAuthor

    Closing as low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions