Repository navigation
[C+ Checklist Needs Completion] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard #50779
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.49-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Interna Team
Action Performed:
- Go to staging.new.expensify.com
- Log in as a copilot.
- Go to Account settings.
- Click on the account switcher.
- Navigate through the account list via keyboard.
Expected Result:
The current account will no longer be highlighted and the selected account will be highlighted (same behavior as workspace switcher).
Actual Result:
Both the current account and the selected account are highlighted when navigating via keyboard.
Workaround:
Unknown
Platforms:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6634911_1728972462581.20241015_140418.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021846231572731332050
- Upwork Job ID: 1846231572731332050
- Last Price Increase: 2024-10-15
- Automatic offers:
- jjcoffee | Reviewer | 104458668
- nkdengineer | Contributor | 104458669
Activity
melvin-bot commentedon Oct 15, 2024
Triggered auto assignment to @mjasikowski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 15, 2024
Triggered auto assignment to @greg-schroeder (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 15, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 15, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mjasikowski commentedon Oct 15, 2024
Account switcher component was changed in this PR: #49051 - this is most likely the offender
nkdengineer commentedon Oct 15, 2024
@mjasikowski In this PR, we discussed this and agreed it isn't a problem.
mjasikowski commentedon Oct 15, 2024
@Expensify/design can you weigh in here and let us know if this is OK or expected? I personally have seen this behavior outside of NewApp and I'm used to it in terms of UX, so it doesn't bother me - but nevertheless we need to either change this or readjust QA to take the new keyboard navigation into account when doing tests.
75 remaining items
[-][HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard[/-][+][HOLD for payment 2024-11-18] [HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard[/+]melvin-bot commentedon Nov 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-18. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 11, 2024
@jjcoffee @greg-schroeder The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[-][HOLD for payment 2024-11-18] [HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard[/-][+][HOLD for payment 2024-11-18] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard[/+]greg-schroeder commentedon Nov 11, 2024
Payment date is 11/18 to account for deploy blocker fixes
greg-schroeder commentedon Nov 18, 2024
Timeline:
So, it seems to me that this led to two distinct regression periods.
greg-schroeder commentedon Nov 18, 2024
@mjasikowski @luacmartins Do you agree with the above that there were two regression periods here?
Original payment $250 -> $125 -> $62.50 per the payment guidelines (50% reduction per regression)
greg-schroeder commentedon Nov 18, 2024
Payment summary:
Contributor: @nkdengineer - $62.50 - Upwork
C+: @jjcoffee - $62.50 - Upwork
mjasikowski commentedon Nov 18, 2024
@greg-schroeder agreed on regressions
[-][HOLD for payment 2024-11-18] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard[/-][+][C+ Checklist Needs Completion] [$250] Copilot - Two accounts are highlighted in account list when navigating via keyboard[/+]greg-schroeder commentedon Nov 18, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
greg-schroeder commentedon Nov 18, 2024
Thanks! All that's left is the checklist @jjcoffee
jjcoffee commentedon Nov 18, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A this was never implemented in
PopoverMenu[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
greg-schroeder commentedon Nov 18, 2024
Thanks! Filed regression test