[HOLD for payment 2024-11-07] [HOLD for payment 2024-10-30] [GR Phase 1] Create empty components for all 6 steps and put them together creating a ‘frame’ of the whole process

@bfitzexpensify

Design doc link: https://docs.google.com/document/d/1Y4P7G9h0Easjcea7wyk52gKrNB9o1yTjpmJFYkrHDW4/edit?tab=t.0#bookmark=id.yapqct1l25wj

Issue Owner

Current Issue Owner: @bfitzexpensify

I am Michał from Callstack - expert contributor group. I’d like to work on this job.

Reviewing label has been removed, please complete the "BugZero Checklist".

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

feat: Frame for non USD bank account flow #51019

If no regressions arise, payment will be issued on 2024-10-30. 🎊

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment through NewDot Manual Requests
@MrMuzyk does not require payment (Contractor)

Reviewing label has been removed, please complete the "BugZero Checklist".

@hungvu193

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.55-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Feature/20459 sub steps refactor #51231

If no regressions arise, payment will be issued on 2024-11-07. 🎊

For reference, here are some details about the assignees on this issue:

@hungvu193 requires payment through NewDot Manual Requests
@MrMuzyk does not require payment (Contractor)

@hungvu193

@hungvu193 please complete the new feature checklist

@garrettmknight

Just remember that I reviewed 2 PRs for this issue #51019 and #51231.
Should the price for this issue be 500$? cc @garrettmknight and @madmax330

Yes, total price should be $500 for 2 PRs, but with the regression, the total payout will be $250.

Yes, total price should be $500 for 2 PRs, but with the regression, the total payout will be $250.

I think that would be fair if we only apply penalty to the second PR (which one caused the regression). I'm not sure why we didn't create a separate issue for the refactor substeps 😬

@hungvu193

That's fair - so 1st PR at $250, and second PR at $125 with the regression.

@hungvu193 can you propose regression test steps to ensure the new feature will work correctly on production in further releases, and then I'll post the payment summary?

Sure thing. I'll propose regression test later today 😁

Regression Test:

Enable payments flow:

Log in to the App
Go to Settings -> Wallet
Add bank account
Click "Enable wallet"
Test all the "Personal info" steps full name, address, date of birth.

Reimbursement account - personal info flow:

Log in to the App
Create a new workspace
Invite new member to the workspace
Go to More features section and enable the Expensify Card option
Go to Expensify Card section that just appeared
Tap Issue new card
Go through the process of connecting to the bank account.
At some point in the process you'll need to provide requestor information like first and last name, date of birth etc. - test if it works correctly

Reimbursement account - beneficial owner info flow:

Repeat steps 1-7 described above
On the later steps of the process, you'll be asked: "Do you own 25% or more of Alberta Bobbeth Charleson?" - select "No"
On the next step: "Do any individuals own 25% or more of Alberta Bobbeth Charleson?" - select "Yes"
You'll land on the next personal info multiple steps form - test it if it works correctly.

Missing personal info for issuing the card flow:

Log in to the App as User A.
Go to the Workspace that you are admin of.
Invite a completely new user (User B).
Turn on Expensify Card for this workspace if not done yet.
Set it up
Tap "Issue new card" and issue the card for User B.
Log in to the App as User B.
Go to the Workspace chat - you should see the "Add shipping details" button - tap it.
You'll see the multiple-step form asking you to fill in your personal details - test it and make sure it works as expected.

@hungvu193

Thank you!

Payment summary:

@hungvu193 to be paid $375 through NewDot Manual Requests
@MrMuzyk does not require payment (Contractor)

@hungvu193

$375 approved for @hungvu193

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-07] [HOLD for payment 2024-10-30] [GR Phase 1] Create empty components for all 6 steps and put them together creating a ‘frame’ of the whole process #50893

16 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-11-07] [HOLD for payment 2024-10-30] [GR Phase 1] Create empty components for all 6 steps and put them together creating a ‘frame’ of the whole process #50893

Description

Activity

MrMuzyk commented on Oct 17, 2024

melvin-bot commented on Oct 23, 2024

melvin-bot commented on Oct 23, 2024

16 remaining items

melvin-bot commented on Oct 31, 2024

melvin-bot commented on Oct 31, 2024

garrettmknight commented on Nov 6, 2024

hungvu193 commented on Nov 7, 2024

bfitzexpensify commented on Nov 7, 2024

hungvu193 commented on Nov 7, 2024

bfitzexpensify commented on Nov 7, 2024

hungvu193 commented on Nov 7, 2024

hungvu193 commented on Nov 7, 2024

bfitzexpensify commented on Nov 7, 2024

garrettmknight commented on Nov 20, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions