You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-11-20] [GR Phase 2] Step 3 Business info screen (without save API call) #50899
Update on my end. For now I've created draft PR. I'm expecting to create proper PR tomorrow. There might be some conflicts appearing soon. Apart from that I need to rebase it, test on all platforms and gather recordings.
Taking longer than expected due to complex situation with forms and various selectors. I've simplified logic of our brand new component that we added in previous PR (PushRowWithModal) and replaced usage of StateSelector.
State/Country selectors need to be looked at as a lot of it can be simplified. We have a few components that do the same thing in different ways. I will try have a look at it after we're done with this feature.
changed the title [-][GR Phase 2] Step 3 Business info screen (without save API call)[/-][+][HOLD for payment 2024-11-20] [GR Phase 2] Step 3 Business info screen (without save API call)[/+]on Nov 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
Not moving forward with a regression test, as this is part of the global reimbursement project. When built overall, the project team should take care of handing over the suite of regression tests to Applause.
Activity
MrMuzyk commentedon Oct 24, 2024
I am Michał from Callstack - expert contributor group. I’d like to work on this job.
MrMuzyk commentedon Oct 29, 2024
Update on my end. For now I've created draft PR. I'm expecting to create proper PR tomorrow. There might be some conflicts appearing soon. Apart from that I need to rebase it, test on all platforms and gather recordings.
MrMuzyk commentedon Oct 30, 2024
Taking longer than expected due to complex situation with forms and various selectors. I've simplified logic of our brand new component that we added in previous PR (PushRowWithModal) and replaced usage of StateSelector.
State/Country selectors need to be looked at as a lot of it can be simplified. We have a few components that do the same thing in different ways. I will try have a look at it after we're done with this feature.
[-][GR Phase 2] Step 3 Business info screen (without save API call)[/-][+][HOLD for payment 2024-11-20] [GR Phase 2] Step 3 Business info screen (without save API call)[/+]melvin-bot commentedon Nov 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 20, 2024
Issue is ready for payment but no BZ is assigned. @trjExpensify you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Nov 20, 2024
Payment Summary
Upwork Job
BugZero Checklist (@trjExpensify)
trjExpensify commentedon Nov 20, 2024
Confirming payments as follows:
Not moving forward with a regression test, as this is part of the global reimbursement project. When built overall, the project team should take care of handing over the suite of regression tests to Applause.
Closing!
garrettmknight commentedon Nov 20, 2024
$250 approved for @hungvu193