Skip to content

[HOLD for payment 2025-02-04] [GR Phase 3] Step 3 - navigation, default data, logic and API call to save it #50905

Closed

Activity

  1. MrMuzyk commented on Nov 14, 2024

    @MrMuzyk
    Contributor

    I am Michał from Callstack - expert contributor group. I’d like to work on this job.

  2. MrMuzyk commented on Nov 21, 2024

    @MrMuzyk
    Contributor

    Implementation is ongoing. Waiting on more details regarding one of the fields and implementation of the API.

    Apart from that, step 2 logic (#50898) has to be implemented so we can fully test this issue

  3. MrMuzyk commented on Dec 16, 2024

    @MrMuzyk
    Contributor

    In order to finish this issue the following needs to happen:

    • feat: Update corpay fields logic, integrate API #52812 has to get merged (Step 1 & 2 logic). This creates bankAccountID which is needed to proceed in next steps
    • Data send in Step 2 has to be saved somewhere in onyx. At the moment it's not and we cannot access the bankAccountID returned from Step 2. It should be saved inside reimbursementAccount together with all the data saved in Steps 1 & 2.
    • Need a final decision on picklists in Step 3. There is a picklist called Trade volume range. It is not on designs and I haven't got a final decision if we should add it or not. If we have to add it then more directions, labels and translations are needed
  4. MrMuzyk commented on Dec 20, 2024

    @MrMuzyk
    Contributor

    I will be OOO from 21.12 - 06.01. Latest update for this issue:

    • new picklist has been added
    • testing recordings have been added
    • It is still waiting on feat: Update corpay fields logic, integrate API #52812 to get merged, however it is rebased with latest changes and was kept up to date
    • BE update is still needed - Data send in Step 2 has to be saved somewhere in onyx. At the moment it's not and we cannot access the bankAccountID returned from Step 2. It should be saved inside reimbursementAccount together with all the data saved in Steps 1 & 2. I believe only minor changes will be needed - reading default values when user goes back to this step
  5. hungvu193 commented on Dec 31, 2024

    @hungvu193
    Contributor

    #52812 is now merge. We can continue with your draft PR when you're back @MrMuzyk

  6. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Jan 28, 2025
  7. changed the title [-][GR Phase 3] Step 3 - navigation, default data, logic and API call to save it[/-] [+][HOLD for payment 2025-02-04] [GR Phase 3] Step 3 - navigation, default data, logic and API call to save it[/+] on Jan 28, 2025
  8. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  9. melvin-bot commented on Jan 28, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-04. 🎊

    For reference, here are some details about the assignees on this issue:

    • @hungvu193 requires payment through NewDot Manual Requests
    • @MrMuzyk does not require payment (Contractor)
  10. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Feb 3, 2025
  11. melvin-bot commented on Feb 3, 2025

    @melvin-bot

    Current assignee @sakluger is eligible for the Bug assigner, not assigning anyone new.

  12. sakluger commented on Feb 3, 2025

    @sakluger
    Contributor

    Summarizing payment on this issue:

    Contributor: @hungvu193 $250, please request on Newdot
    Contributor+: @MrMuzyk no payment required, contractor

  13. garrettmknight commented on Feb 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @hungvu193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions