You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-02-04] [GR Phase 3] Step 3 - navigation, default data, logic and API call to save it #50905
Data send in Step 2 has to be saved somewhere in onyx. At the moment it's not and we cannot access the bankAccountID returned from Step 2. It should be saved inside reimbursementAccount together with all the data saved in Steps 1 & 2.
Need a final decision on picklists in Step 3. There is a picklist called Trade volume range. It is not on designs and I haven't got a final decision if we should add it or not. If we have to add it then more directions, labels and translations are needed
BE update is still needed - Data send in Step 2 has to be saved somewhere in onyx. At the moment it's not and we cannot access the bankAccountID returned from Step 2. It should be saved inside reimbursementAccount together with all the data saved in Steps 1 & 2. I believe only minor changes will be needed - reading default values when user goes back to this step
changed the title [-][GR Phase 3] Step 3 - navigation, default data, logic and API call to save it[/-][+][HOLD for payment 2025-02-04] [GR Phase 3] Step 3 - navigation, default data, logic and API call to save it[/+]on Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
Activity
MrMuzyk commentedon Nov 14, 2024
I am Michał from Callstack - expert contributor group. I’d like to work on this job.
MrMuzyk commentedon Nov 21, 2024
Implementation is ongoing. Waiting on more details regarding one of the fields and implementation of the API.
Apart from that, step 2 logic (#50898) has to be implemented so we can fully test this issue
MrMuzyk commentedon Dec 16, 2024
In order to finish this issue the following needs to happen:
reimbursementAccounttogether with all the data saved in Steps 1 & 2.Trade volume range. It is not on designs and I haven't got a final decision if we should add it or not. If we have to add it then more directions, labels and translations are neededMrMuzyk commentedon Dec 20, 2024
I will be OOO from 21.12 - 06.01. Latest update for this issue:
hungvu193 commentedon Dec 31, 2024
#52812 is now merge. We can continue with your draft PR when you're back @MrMuzyk
[-][GR Phase 3] Step 3 - navigation, default data, logic and API call to save it[/-][+][HOLD for payment 2025-02-04] [GR Phase 3] Step 3 - navigation, default data, logic and API call to save it[/+]melvin-bot commentedon Jan 28, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 28, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-04. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 3, 2025
Current assignee @sakluger is eligible for the Bug assigner, not assigning anyone new.
sakluger commentedon Feb 3, 2025
Summarizing payment on this issue:
Contributor: @hungvu193 $250, please request on Newdot
Contributor+: @MrMuzyk no payment required, contractor
garrettmknight commentedon Feb 3, 2025
$250 approved for @hungvu193