You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search #50973
Version Number: 9.0.50-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers):applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Open report.
Click search on the top right.
Enter the name of user with no chat history (must be the user whose chat has never been opened before).
Click on the user.
Expected Result:
The chat with that user will open.
Actual Result:
Nothing happens after clicking on user with no chat history on Search.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Search - Nothing happens after clicking on user with no chat history on Search[/-][+][HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search[/+]on Oct 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
[@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rayane-djouah] Determine if we should create a regression test for this bug.
[@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search[/-][+][HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search[/+]on Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
[@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@rayane-djouah] Determine if we should create a regression test for this bug.
[@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 17, 2024
Triggered auto assignment to @madmax330 (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 17, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 17, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 17, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
mkzie2 commentedon Oct 17, 2024
Edited by proposal-police: This proposal was edited at 2024-10-17 07:33:11 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Nothing happens after clicking on user with no chat history on Search.
What is the root cause of that problem?
We use
dismissModalWithReportto navigate to the newly created report with the new user:App/src/components/Search/SearchRouter/SearchRouterList.tsx
Lines 163 to 165 in c7847b9
App/src/libs/actions/Report.ts
Lines 1048 to 1050 in c7847b9
But since we open from Report screen and it is not included in these screens:
App/src/libs/Navigation/dismissModalWithReport.ts
Lines 36 to 46 in c7847b9
causing the
dismissModalWithReportdoes not navigate.What changes do you think we should make in order to solve the problem?
Add
SCREENS.REPORTto the above cases.Kicu commentedon Oct 17, 2024
I will take a look at this one.
rayane-d commentedon Oct 17, 2024
Thanks @Kicu
cc @luacmartins
10 remaining items
[-]Search - Nothing happens after clicking on user with no chat history on Search[/-][+][HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search[/+]melvin-bot commentedon Oct 18, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 18, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.50-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-25. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 18, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search[/-][+][HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] Search - Nothing happens after clicking on user with no chat history on Search[/+]melvin-bot commentedon Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: