Skip to content

[HOLD for payment 2024-10-29] [$250] Search - No tooltip when hovering over the search icon #50977

New issue
New issue
Closed
Closed
[HOLD for payment 2024-10-29] [$250] Search - No tooltip when hovering over the search icon#50977
Assignees
luacmartinsMonilBhavsarjoekaufmanexpensifyrayane-dSzymczakJ
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh1310018@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Open any report.
  3. Hover over search icon on the top right.

Expected Result:

There will be tooltip when hovering over the search icon.

Actual Result:

There is no tooltip when hovering over the search icon.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6637206_1729134483527.tooltip.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846935135638966053
  • Upwork Job ID: 1846935135638966053
  • Last Price Increase: 2024-10-17
Issue OwnerCurrent Issue Owner: @
Issue OwnerCurrent Issue Owner: @joekaufmanexpensify

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 17, 2024
  2. melvin-bot
    assigned
    joekaufmanexpensify
    on Oct 17, 2024

  3. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botBot
    on Oct 17, 2024 – with Melvin Bot

    Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  4. melvin-bot
    assigned
    MonilBhavsar
    on Oct 17, 2024
  5. melvin-bot
    added
    DailyKSv2
    on Oct 17, 2024

  6. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botBot
    on Oct 17, 2024 – with Melvin Bot

    Triggered auto assignment to @MonilBhavsar (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  7. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botBot
    on Oct 17, 2024 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  8. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 17, 2024

  9. github-actions commented on Oct 17, 2024

    @github-actions
    github-actionsBot
    on Oct 17, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  10. nkdengineer commented on Oct 17, 2024

    @nkdengineer
    nkdengineer
    on Oct 17, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    Search - No tooltip when hovering over the search icon

    What is the root cause of that problem?

    We don't wrap this icon in a Tooltip component

    What changes do you think we should make in order to solve the problem?

    We should wrap this icon in a Tooltip component with text is search

    What alternative solutions did you explore? (Optional)

  11. mkzie2 commented on Oct 17, 2024

    @mkzie2
    mkzie2
    on Oct 17, 2024
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    What is the root cause of that problem?

    The SearchButton component does not have a tooltip:

    App/src/components/Search/SearchRouter/SearchButton.tsx

    Line 26 in 935067e

    <PressableWithoutFeedback

    What changes do you think we should make in order to solve the problem?

    Wrap Tooltip around whose content can be "Find"

    Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

  12. MonilBhavsar
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 17, 2024

  13. 32 remaining items

  14. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botBot
    on Oct 22, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-29. 🎊

    For reference, here are some details about the assignees on this issue:

  15. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botBot
    on Oct 22, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rayane-djouah] The PR that introduced the bug has been identified. Link to the PR:
    • [@rayane-djouah] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rayane-djouah] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rayane-djouah] Determine if we should create a regression test for this bug.
    • [@rayane-djouah] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@joekaufmanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  16. joekaufmanexpensify commented on Oct 28, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 28, 2024
    Contributor

    @rayane-djouah can you complete BZ here so we can prep for payment?

  17. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 28, 2024

  18. rayane-d commented on Oct 28, 2024

    @rayane-d
    rayane-d
    on Oct 28, 2024
    Contributor

    BugZero Checklist

    • The PR that introduced the bug has been identified. Link to the PR: Add SearchRouter component and context to display it #48785
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48785/files#r1819588103
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug. This was treated as a follow-up PR as part of the search project, and regression tests will be added during the project wrap-up. Additionally, this bug was caught during regression testing, so there is likely already a test case for it
    • If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

  19. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 29, 2024
    Contributor

    TY! all set to issue payment.

  20. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 29, 2024
    Contributor

    We only need to pay @rayane-djouah $250 here for C+ via Upwork.

  21. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 29, 2024
    Contributor

    @rayane-djouah offer sent for $250!

  22. rayane-d commented on Oct 29, 2024

    @rayane-d
    rayane-d
    on Oct 29, 2024
    Contributor

    @joekaufmanexpensify Offer accepted, thank you!

  23. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 29, 2024
    Contributor

    @rayane-djouah $250 sent and contract ended!

  24. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 29, 2024
    Contributor

    Upwork job closed.

  25. joekaufmanexpensify commented on Oct 29, 2024

    @joekaufmanexpensify
    joekaufmanexpensify
    on Oct 29, 2024
    Contributor

    All set. Thanks everyone!

  26. joekaufmanexpensify
    closed this as completedon Oct 29, 2024
  27. github-project-automation
    moved this from Polish to Done in #expensify-bugson Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions