Skip to content

[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Receipt - Receipt 3dots menu doesn't show options to replace and delete receipt #50980

New issue
New issue
Closed
Closed
[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Receipt - Receipt 3dots menu doesn't show options to replace and delete receipt#50980
Assignees
BeamanatorPujan92RachCHopkinsmkzie2
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 17, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: v9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Open 1:1 with an user (or workspace chat)
  3. Submit an expense
  4. Open the expense
  5. Tap plus placeholder and using camera upload an image
  6. Tap on receipt -- 3 dots
  7. Note the receipt options

Expected Result:

Receipt 3dots menu must show options to replace and delete receipt.

Actual Result:

Receipt 3dots menu doesn't show options to replace and delete receipt.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6637231_1729136707540.Screenrecorder-2024-10-17-09-01-26-36.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021846827472906199686
  • Upwork Job ID: 1846827472906199686
  • Last Price Increase: 2024-10-17
  • Automatic offers:
    • mkzie2 | Contributor | 104459504
Issue OwnerCurrent Issue Owner: @RachCHopkins

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 17, 2024
  2. melvin-bot
    assigned
    Beamanator
    on Oct 17, 2024

  3. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botBot
    on Oct 17, 2024 – with Melvin Bot

    Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot
    assigned
    RachCHopkins
    on Oct 17, 2024

  5. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botBot
    on Oct 17, 2024 – with Melvin Bot

    Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botBot
    on Oct 17, 2024 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions
    added
    Engineering
    HourlyKSv2
    on Oct 17, 2024
  8. melvin-bot
    added
    DailyKSv2
    on Oct 17, 2024

  9. github-actions commented on Oct 17, 2024

    @github-actions
    github-actionsBot
    on Oct 17, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  10. melvin-bot
    removed
    HourlyKSv2
    on Oct 17, 2024
  11. Beamanator
    added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 17, 2024
  12. melvin-bot
    changed the title [-]Receipt - Receipt 3dots menu doesn't show options to replace and delete receipt[/-] [+][$250] Receipt - Receipt 3dots menu doesn't show options to replace and delete receipt[/+] on Oct 17, 2024

  13. melvin-bot commented on Oct 17, 2024

    @melvin-bot
    melvin-botBot
    on Oct 17, 2024 – with Melvin Bot

    Job added to Upwork: https://www.upwork.com/jobs/~021846827472906199686

  14. 39 remaining items

  15. melvin-bot
    changed the title [-][HOLD for payment 2024-10-25] [$250] Receipt - Receipt 3dots menu doesn't show options to replace and delete receipt[/-] [+][HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Receipt - Receipt 3dots menu doesn't show options to replace and delete receipt[/+] on Oct 22, 2024

  16. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botBot
    on Oct 22, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-29. 🎊

    For reference, here are some details about the assignees on this issue:

  17. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botBot
    on Oct 22, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@Pujan92] The PR that introduced the bug has been identified. Link to the PR:
    • [@Pujan92] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@Pujan92] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@Pujan92] Determine if we should create a regression test for this bug.
    • [@Pujan92] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  18. RachCHopkins commented on Oct 25, 2024

    @RachCHopkins
    RachCHopkins
    on Oct 25, 2024
    Contributor

    @Pujan92 can you please complete the checklist so that I can issue payment?

  19. Pujan92 commented on Oct 25, 2024

    @Pujan92
    Pujan92
    on Oct 25, 2024
    Contributor

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    Regression Test Steps

    1. Submit an expense and add a receipt to it
    2. Goto that expense and open an image modal
    3. Click on 3 dots menu
    4. Verify Replace and Delete receipt options are shown
  20. melvin-bot
    added
    DailyKSv2
    and removed
    WeeklyKSv2
    on Oct 25, 2024

  21. melvin-bot commented on Oct 28, 2024

    @melvin-bot
    melvin-botBot
    on Oct 28, 2024 – with Melvin Bot

    @Beamanator, @Pujan92, @RachCHopkins, @mkzie2 Whoops! This issue is 2 days overdue. Let's get this updated quick!

  22. melvin-bot
    added
    Overdue
    on Oct 28, 2024

  23. RachCHopkins commented on Oct 29, 2024

    @RachCHopkins
    RachCHopkins
    on Oct 29, 2024
    Contributor

    Will pay this tomorrow!

  24. melvin-bot
    removed
    Overdue
    on Oct 29, 2024

  25. RachCHopkins commented on Oct 30, 2024

    @RachCHopkins
    RachCHopkins
    on Oct 30, 2024
    Contributor

    Payment Summary:

    Contributor: @mkzie2 paid $250 via Upwork
    Contributor+: @Pujan92 to be paid $250 via Newdot manual request
    Upwork job here

  26. RachCHopkins commented on Oct 30, 2024

    @RachCHopkins
    RachCHopkins
    on Oct 30, 2024
    Contributor

    Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

  27. RachCHopkins
    closed this as completedon Oct 30, 2024

  28. garrettmknight commented on Nov 6, 2024

    @garrettmknight
    garrettmknight
    on Nov 6, 2024
    Contributor

    $250 approved for @Pujan92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions