You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-29] Search - Contacts with no chat history are also categorized under "Recent chats" #50998
Version Number: 9.0.50-0 Reproducible in staging?: Y Reproducible in production?: N/A - new feature, doesn't exist in prod Email or phone of affected tester (no customers):applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Log in with a new private domain account (Expensifail).
Open FAB > Start chat.
Note that the contacts under "Recent chats" are only Concierge and yourself.
Open Concierge.
Click Search icon.
Note that Recent chats include all the contacts instead of just Concierge and yourself.
Expected Result:
In Search modal, "Recent chats" should only include Concierge and self DM, while the other contacts should be under "Contacts" section.
Actual Result:
In Search modal, "Recent chats" includes Concierge, self DM and the rest of the contacts which user has never chatted with before.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
@luacmartins @Expensify/design I initially thought it was intentional to include all search report options under one section title ("Recent chats"). Do we need to split the options into "Recent searches", "Recent chats", and "Contacts", or should we exclude the contacts options from the list?
changed the title [-]Search - Contacts with no chat history are also categorized under "Recent chats"[/-][+][HOLD for payment 2024-10-29] Search - Contacts with no chat history are also categorized under "Recent chats"[/+]on Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@MariaHCD / @luacmartins] The PR that introduced the bug has been identified. Link to the PR:
[@MariaHCD / @luacmartins] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@MariaHCD / @luacmartins] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@SzymczakJ] Determine if we should create a regression test for this bug.
[@SzymczakJ] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@VictoriaExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
I don't think anyone needs to be paid here - @SzymczakJ is a contractor and everyone else is internal. If I've missed someone that needs payment, let me know!
Otherwise, we are just waiting for the checklist to be complete and we can close this out
Activity
melvin-bot commentedon Oct 17, 2024
Triggered auto assignment to @MariaHCD (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 17, 2024
Triggered auto assignment to @VictoriaExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 17, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 17, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
rayane-d commentedon Oct 17, 2024
@luacmartins @Expensify/design I initially thought it was intentional to include all search report options under one section title ("Recent chats"). Do we need to split the options into "Recent searches", "Recent chats", and "Contacts", or should we exclude the contacts options from the list?
rayane-d commentedon Oct 17, 2024
cc @Kicu @SzymczakJ
daledah commentedon Oct 17, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
In Search modal, "Recent chats" includes Concierge, self DM and the rest of the contacts which user has never chatted with before.
What is the root cause of that problem?
In
SearchRouter, we merge recent reports and personal details as one:App/src/components/Search/SearchRouter/SearchRouter.tsx
Lines 86 to 93 in 987ff1b
And in 'SearchRouterList`, we only have "Recent Chats" section, not "Contacts" section:
App/src/components/Search/SearchRouter/SearchRouterList.tsx
Line 147 in 987ff1b
What changes do you think we should make in order to solve the problem?
Add a param
personalDetailListstoSearchRouterListand add "Contacts" section:Then in here, remove
currentSearchOptions.personalDetailsfromrecentReportsCreate
personalDetailListsmemo in 'SearchRouterand pass it toSearchRouterList`:POC
What alternative solutions did you explore? (Optional)
20 remaining items
[-]Search - Contacts with no chat history are also categorized under "Recent chats"[/-][+][HOLD for payment 2024-10-29] Search - Contacts with no chat history are also categorized under "Recent chats"[/+]melvin-bot commentedon Oct 22, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-29. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Oct 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
melvin-bot commentedon Oct 29, 2024
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.
melvin-bot commentedon Oct 31, 2024
@MariaHCD, @luacmartins, @VictoriaExpensify, @SzymczakJ Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Nov 4, 2024
@MariaHCD, @luacmartins, @VictoriaExpensify, @SzymczakJ Still overdue 6 days?! Let's take care of this!
luacmartins commentedon Nov 5, 2024
Waiting on payment @VictoriaExpensify
VictoriaExpensify commentedon Nov 6, 2024
I don't think anyone needs to be paid here - @SzymczakJ is a contractor and everyone else is internal. If I've missed someone that needs payment, let me know!
Otherwise, we are just waiting for the checklist to be complete and we can close this out