You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Search - "Invite a friend, get [amount]$" banner is not displayed on Search page #51004
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
What changes do you think we should make in order to solve the problem?
first of all we need to extend the ReferralProgramCTA props to have a new prop onPress this will be called when the user clicks on the referral here --> onPress?.();
Activity
melvin-bot commentedon Oct 17, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 17, 2024
Triggered auto assignment to @dylanexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 17, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 17, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
abzokhattab commentedon Oct 17, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
Referral banner is not added to the new search modal
What is the root cause of that problem?
there is no
footerContentadded at the search router list that displays the the referral ctaApp/src/components/Search/SearchRouter/SearchRouterList.tsx
Lines 169 to 178 in a3e9366
What changes do you think we should make in order to solve the problem?
ReferralProgramCTAprops to have a new proponPressthis will be called when the user clicks on the referral here -->onPress?.();SearchRouterList, we should add:footerContentto theSelectionListinside the SearchRouterList as following:POC:
Screen.Recording.2024-10-17.at.13.45.18.mov
What alternative solutions did you explore? (Optional)
Nodebrute commentedon Oct 17, 2024
This was intentionally removed in PR #49984 due to limited space. See the discussion here: https://github.com/Expensify/App/pull/49984/files#r1797615648.
rayane-d commentedon Oct 17, 2024
Yeah, this was intentionally removed
cc @luacmartins
dylanexpensify commentedon Oct 17, 2024
TY! Closing