[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Android - Search - Keyboard does not auto open in Search modal

@jayeshmangwani

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.50-0
Reproducible in staging?: Y
Reproducible in production?: N/A - new feature, doesn't exist in prod
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Launch New Expensify app.
Open a report.
Tap Search icon.

Expected Result:

Keyboard will auto open.

Actual Result:

Keyboard does not auto open.

Workaround:

Unknown

Platforms:

Screenshots/Videos

Bug6637494_1729158638593.1729158562598_Screen_Recording_20241017_174902_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021846960678624915682
Upwork Job ID: 1846960678624915682
Last Price Increase: 2024-10-17
Automatic offers:

abzokhattab | Contributor | 104471055

Issue Owner

Current Issue Owner: @jayeshmangwani

@srikarparsi

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@sakluger

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

💬 A slack conversation has been started in #expensify-open-source

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Edited by proposal-police: This proposal was edited at 2024-10-17 18:17:16 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Search - Keyboard does not auto open in Search modal

What is the root cause of that problem?

keyboard doesnt open up because we dont use the useAutoFocusInput inside the SearchRouterInput component like we do in other textInput fields and the autoFocus doesn't work well on android with modals

What changes do you think we should make in order to solve the problem?

we should assign the ref to the inputCallbackRef value of the useAutoFocusInput hook:

    const {inputCallbackRef } = useAutoFocusInput();

then use it in the TextInput here:

                        ref={inputCallbackRef}

then we could remove the autoFocus as its now handled by the useAutoFocusInput

What alternative solutions did you explore? (Optional)

optionally we can delay the focus so that the input field focuses correctly by adding shouldDelayFocus

@289Adam289

cc @289Adam289 @Kicu @SzymczakJ @luacmartins

Was this tested on a physical phone? Cos I'm testing this on android emulator right now (Pixel) and the keyboard does open:

rec-search-keyboard-andr.mp4

rec-search-keyboard-andr2.mp4

I did however noticed exactly one case where it didn't open, but I cannot reproduce it consistently. All the other cases it did open.
I can test on a physical device later, but I'm curious if other people can reproduce this easily?

@jayeshmangwani

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jayeshmangwani] Determine if we should create a regression test for this bug.
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@jayeshmangwani

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

Fix android input focus in the search router component #51064

If no regressions arise, payment will be issued on 2024-10-29. 🎊

For reference, here are some details about the assignees on this issue:

@jayeshmangwani requires payment through NewDot Manual Requests
@abzokhattab requires payment automatic offer (Contributor)

@jayeshmangwani

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR:
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@jayeshmangwani] Determine if we should create a regression test for this bug.
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@sakluger] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

@abzokhattab

Weird - I'm not sure why the second payment hold was added, this was deployed to prod 7 days ago. I'll prep the payment summary.

Summarizing payment on this issue:

Contributor: @abzokhattab $250, paid via Upwork
Contributor+: @jayeshmangwani $250, please complete the BZ checklist, then request on Newdot

@jayeshmangwani

[@jayeshmangwani] The PR that introduced the bug has been identified. Link to the PR: Add SearchRouter component and context to display it #48785
[@jayeshmangwani] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add SearchRouter component and context to display it #48785 (comment)
[@jayeshmangwani] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
[@jayeshmangwani] Determine if we should create a regression test for this bug. N/A
[@jayeshmangwani] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

@sakluger

@sakluger I’ve checked the first two items on the checklist. For the third, I’m not sure if discussion is necessary here, as it could have been addressed in the PR review. As for items 4 and 5, I don’t think dedicated regression tests are needed.

@jayeshmangwani

Thanks @jayeshmangwani!

@sakluger

@sakluger @luacmartins @srikarparsi Be sure to fill out the Contact List!

@jayeshmangwani

$250 approved for @jayeshmangwani

Navigation Menu

Repository navigation

[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Android - Search - Keyboard does not auto open in Search modal #51010

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

51 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[HOLD for payment 2024-10-29] [HOLD for payment 2024-10-25] [$250] Android - Search - Keyboard does not auto open in Search modal #51010

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 17, 2024

melvin-bot commented on Oct 17, 2024

melvin-bot commented on Oct 17, 2024

github-actions commented on Oct 17, 2024

abzokhattab commented on Oct 17, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

rayane-d commented on Oct 17, 2024

Kicu commented on Oct 17, 2024

51 remaining items

melvin-bot commented on Oct 18, 2024

melvin-bot commented on Oct 22, 2024

melvin-bot commented on Oct 22, 2024

sakluger commented on Oct 25, 2024

jayeshmangwani commented on Oct 26, 2024

jayeshmangwani commented on Oct 26, 2024

sakluger commented on Oct 28, 2024

melvin-bot commented on Oct 28, 2024

garrettmknight commented on Nov 6, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions