You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-05-27] [$250] The system message that appears when someone requests to join a workspace isn't appearing correctly #51069
changed the title [-]The system message that appears when someone requests to join a workspace isn't appearing correctly[/-][+][$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/+]on Oct 29, 2024
changed the title [-][$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/-][+][Due for payment 2025-05-27] [$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/+]on May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@hoangzinh@zanyrenney@hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Log in as user A
Go to workspace settings
Click "share" and copy the URL
Open the URL and login with different account user B
Log in back to user A and go to #admin room of the workspace
Verify that: System message should be user B requested to join user A workspace
Activity
melvin-bot commentedon Oct 18, 2024
Triggered auto assignment to @anmurali (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.nkdengineer commentedon Oct 18, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
user B requested to join the workspace (invited by user A).
What is the root cause of that problem?
The action of this report Action is
ACTIONABLEJOINREQUESTand we are not handling this action in the front-end.What changes do you think we should make in order to solve the problem?
ReportUtilsIn
ReportActionItemhereIn
OptionsListUtils.tshereIn
ContextMenuActions.tsxhereWhat alternative solutions did you explore? (Optional)
melvin-bot commentedon Oct 21, 2024
@anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!
melvin-bot commentedon Oct 23, 2024
@anmurali Huh... This is 4 days overdue. Who can take care of this?
melvin-bot commentedon Oct 25, 2024
@anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!
melvin-bot commentedon Oct 29, 2024
@anmurali 10 days overdue. Is anyone even seeing these? Hello?
[-]The system message that appears when someone requests to join a workspace isn't appearing correctly[/-][+][$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/+]melvin-bot commentedon Oct 29, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021851379795160737664
50 remaining items
[-][$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/-][+][Due for payment 2025-05-27] [$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/+]melvin-bot commentedon May 20, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon May 20, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-05-27. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon May 20, 2025
@hoangzinh @zanyrenney @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
zanyrenney commentedon May 27, 2025
@hoangzinh please complete the checklist ahead of payment.
hoangzinh commentedon May 27, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Invite user to workspace via invite link #37525 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Test:
Do we agree 👍 or 👎
hoangzinh commentedon May 27, 2025
Requested payment in ND
zanyrenney commentedon May 29, 2025
Payment summary
@hoangzinh requires payment through NewDot Manual Requests - please request $250
@nkdengineer requires payment automatic offer (Contributor) - paid $250 and ended contract via upwork.
garrettmknight commentedon Jun 3, 2025
$250 approved for @hoangzinh