Skip to content

[Due for payment 2025-05-27] [$250] The system message that appears when someone requests to join a workspace isn't appearing correctly #51069

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.50-6
Reproducible in staging?: y
Reproducible in production?: y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @jamesdeanexpensify
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729117570646089

Action Performed:

  1. Log in as user A
  2. Go to workspace settings
  3. Click "share" and copy the URL
  4. Open the URL and login with different account user B
  5. Log in back to user A and go to #admin room of the workspace

Expected Result:

System message should be user B requested to join user A workspace

Actual Result:

user B requested to join the workspace (invited by user A).

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Snip - (5) New Expensify - Google Chrome (2)
image (14)
image (13)

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021851379795160737664
  • Upwork Job ID: 1851379795160737664
  • Last Price Increase: 2024-10-29
  • Automatic offers:
    • nkdengineer | Contributor | 104682613
Issue OwnerCurrent Issue Owner: @zanyrenney

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 18, 2024
  2. melvin-bot commented on Oct 18, 2024

    @melvin-bot

    Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. nkdengineer commented on Oct 18, 2024

    @nkdengineer
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    user B requested to join the workspace (invited by user A).

    What is the root cause of that problem?

    The action of this report Action is ACTIONABLEJOINREQUEST and we are not handling this action in the front-end.

    What changes do you think we should make in order to solve the problem?

    1. We should create new translation key for this action
            joinRequest: ({user, workspaceName}: {user: string, workspaceName: string} ) => ` ${user} requested to join ${workspaceName}`,
    
    1. Create a util to get the join request message in ReportUtils
    function getJoinRequestMessage(reportAction: ReportAction<typeof CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST>) {
        return Localize.translateLocal('joinRequest', {user: ..., workspaceName: ...});
    }
    
    1. Do the same way as we do for other actions to add a case for the join request in other places

    In ReportActionItem here

    else if (action.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) {
        children = <ReportActionItemBasicMessage message={ReportUtils.getJoinRequestMessage(action)} />;
    }
    

    In OptionsListUtils.ts here

    if (parentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) { 
       return getJoinRequestMessage(parentReportAction); 
    } 
    

    In ContextMenuActions.tsx here

    else if (reportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.ACTIONABLEJOINREQUEST) { 
         const displayMessage = ReportUtils.getJoinRequestMessage(reportAction); 
         Clipboard.setString(displayMessage); 
    

    What alternative solutions did you explore? (Optional)

  4. melvin-bot commented on Oct 21, 2024

    @melvin-bot

    @anmurali Whoops! This issue is 2 days overdue. Let's get this updated quick!

  5. melvin-bot commented on Oct 23, 2024

    @melvin-bot

    @anmurali Huh... This is 4 days overdue. Who can take care of this?

  6. melvin-bot commented on Oct 25, 2024

    @melvin-bot

    @anmurali 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

  7. melvin-bot commented on Oct 29, 2024

    @melvin-bot

    @anmurali 10 days overdue. Is anyone even seeing these? Hello?

  8. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 29, 2024
  9. changed the title [-]The system message that appears when someone requests to join a workspace isn't appearing correctly[/-] [+][$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/+] on Oct 29, 2024
  10. melvin-bot commented on Oct 29, 2024

    @melvin-bot
  11. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 29, 2024
  12. 50 remaining items

  13. changed the title [-][$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/-] [+][Due for payment 2025-05-27] [$250] The system message that appears when someone requests to join a workspace isn't appearing correctly[/+] on May 20, 2025
  14. melvin-bot commented on May 20, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  15. melvin-bot commented on May 20, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.46-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-05-27. 🎊

    For reference, here are some details about the assignees on this issue:

  16. melvin-bot commented on May 20, 2025

    @melvin-bot

    @hoangzinh @zanyrenney @hoangzinh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  17. zanyrenney commented on May 27, 2025

    @zanyrenney
    Contributor

    @hoangzinh please complete the checklist ahead of payment.

  18. hoangzinh commented on May 27, 2025

    @hoangzinh
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: Invite user to workspace via invite link #37525 (comment)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Log in as user A
    2. Go to workspace settings
    3. Click "share" and copy the URL
    4. Open the URL and login with different account user B
    5. Log in back to user A and go to #admin room of the workspace
    6. Verify that: System message should be user B requested to join user A workspace

    Do we agree 👍 or 👎

  19. hoangzinh commented on May 27, 2025

    @hoangzinh
    Contributor

    Requested payment in ND

  20. zanyrenney commented on May 29, 2025

    @zanyrenney
    Contributor

    Payment summary

    @hoangzinh requires payment through NewDot Manual Requests - please request $250
    @nkdengineer requires payment automatic offer (Contributor) - paid $250 and ended contract via upwork.

  21. garrettmknight commented on Jun 3, 2025

    @garrettmknight
    Contributor

    $250 approved for @hoangzinh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorNot a priority

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions