Repository navigation
[HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Onboarding - Onboarding does not show up when creating new account for the second time #51115
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com on incognito mode.
- Sign up with a new Gmail account.
- Complete the onboarding.
- Log out.
- Sign up with another new Gmail account.
Expected Result:
Onboarding will show up for every new account created (production behavior).
Actual Result:
Onboarding does not show up for the second new Gmail account.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Uploading Bug6639192_1729287472033!20241019_053558.mp4…
Activity
melvin-bot commentedon Oct 19, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 19, 2024
Triggered auto assignment to @Beamanator (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Oct 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 19, 2024
💬 A slack conversation has been started in #expensify-open-source
Kalydosos commentedon Oct 20, 2024
Edited by proposal-police: This proposal was edited at 2024-10-20 20:49:16 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
Onboarding does not show up when creating new account for the second time
What is the root cause of that problem?
when signing up for the second account, the fetch statuses of onyx keys nvp_onboarding, nvp_trynewdot and is_single_new_dot_entry are "loading" even though their values are undefined. The keys nvp_onboarding, nvp_trynewdot values are updated to false in the signup process but the key is_single_new_dot_entry is not updated which leads to its fetch status to be locked at "loading". That affects the triggering of the onboarding process which is stuck in the line below
App/src/hooks/useOnboardingFlow.ts
Lines 27 to 29 in d6f883a
as isSingleNewDotEntryMetadata status keep returning "loading"
What changes do you think we should make in order to solve the problem?
the onyx key is_single_new_dot_entry value is used for NativeModules.HybridAppModule, see line below
App/src/hooks/useOnboardingFlow.ts
Lines 33 to 35 in d6f883a
we will consider the onyx key only in the context of NativeModules.HybridAppModule for the onboarding process (that key fetch status is always "loaded" during the first account creation) by changing the lines
App/src/hooks/useOnboardingFlow.ts
Lines 27 to 29 in d6f883a
into this
RESULT
it works like a charm
2024-10-20.20-48-33.mp4
What alternative solutions did you explore? (Optional)
we could also change the lines
App/src/hooks/useOnboardingFlow.ts
Lines 27 to 29 in d6f883a
into this
as a shorter version of the main changes proposed but i think the main changes taking extra precautions (isSingleNewDotEntry !== undefined ||NativeModules.HybridAppModule) is a good thing
Beamanator commentedon Oct 21, 2024
@Kalydosos - thanks for your proposal! Since this is a Deploy Blocker, we also want to figure out where this came from (since this is most likely due to a very recent PR). Can you help find which PR caused this?
Beamanator commentedon Oct 21, 2024
I will test to see if this has to do with #49602
14 remaining items
[-]Onboarding - Onboarding does not show up when creating new account for the second time[/-][+][HOLD for payment 2024-10-29] Onboarding - Onboarding does not show up when creating new account for the second time[/+]melvin-bot commentedon Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-29. 🎊
melvin-bot commentedon Oct 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-10-29] Onboarding - Onboarding does not show up when creating new account for the second time[/-][+][HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Onboarding - Onboarding does not show up when creating new account for the second time[/+]melvin-bot commentedon Oct 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-30. 🎊
melvin-bot commentedon Oct 23, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: