You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND #51121
Version Number: 9.0.51-0 Reproducible in staging?: Can't check Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Issue was found when executing this PR:#49602 Email or phone of affected tester (no customers):applausetester+kh1410003@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Launch hybrid app.
Go to OD if the app is in ND.
Open menu.
Tap Trips.
Tap app back button.
Tap Try New Expensify.
Tap app back button.
Expected Result:
User is able to return to New Expensify from OD after opening Book travel page from OD.
Actual Result:
App is stuck at Book travel page after opening Trips from OD and then open Try New Expensify.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
changed the title [-]Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/-][+][HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/+]on Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR:
[@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@carlosmiceli] Determine if we should create a regression test for this bug.
[@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
changed the title [-][HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/-][+][HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/+]on Oct 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR:
[@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@carlosmiceli] Determine if we should create a regression test for this bug.
[@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Activity
melvin-bot commentedon Oct 19, 2024
Triggered auto assignment to @OfstadC (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 19, 2024
Triggered auto assignment to @carlosmiceli (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Oct 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 19, 2024
💬 A slack conversation has been started in #expensify-open-source
IuliiaHerets commentedon Oct 19, 2024
We think that this bug might be related to #vip-travel
carlosmiceli commentedon Oct 19, 2024
This is most likely the PR that caused it: #49602
10 remaining items
[-]Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/-][+][HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/+]melvin-bot commentedon Oct 22, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-29. 🎊
melvin-bot commentedon Oct 22, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
[-][HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/-][+][HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/+]melvin-bot commentedon Oct 23, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-10-30. 🎊
melvin-bot commentedon Oct 23, 2024
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: