Skip to content

[HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND #51121

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.51-0
Reproducible in staging?: Can't check
Reproducible in production?: N/A - new feature, doesn't exist in prod
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue was found when executing this PR: #49602
Email or phone of affected tester (no customers): applausetester+kh1410003@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Launch hybrid app.
  2. Go to OD if the app is in ND.
  3. Open menu.
  4. Tap Trips.
  5. Tap app back button.
  6. Tap Try New Expensify.
  7. Tap app back button.

Expected Result:

User is able to return to New Expensify from OD after opening Book travel page from OD.

Actual Result:

App is stuck at Book travel page after opening Trips from OD and then open Try New Expensify.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6639681_1729345161828.1729344665620_Screen_Recording_20241019_213058.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @OfstadC

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2024
  2. melvin-bot commented on Oct 19, 2024

    @melvin-bot

    Triggered auto assignment to @OfstadC (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 19, 2024

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Oct 19, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 19, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. IuliiaHerets commented on Oct 19, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #vip-travel

  7. carlosmiceli commented on Oct 19, 2024

    @carlosmiceli
    Contributor

    This is most likely the PR that caused it: #49602

  8. 10 remaining items

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Oct 22, 2024
  10. changed the title [-]Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/-] [+][HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/+] on Oct 22, 2024
  11. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.51-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-29. 🎊

  12. melvin-bot commented on Oct 22, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR:
    • [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@carlosmiceli] Determine if we should create a regression test for this bug.
    • [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
  13. changed the title [-][HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/-] [+][HOLD for payment 2024-10-30] [HOLD for payment 2024-10-29] Hybrid Android - App is stuck at Book travel page after opening Trips from OD and then Try ND[/+] on Oct 23, 2024
  14. melvin-bot commented on Oct 23, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.52-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-10-30. 🎊

  15. melvin-bot commented on Oct 23, 2024

    @melvin-bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@carlosmiceli] The PR that introduced the bug has been identified. Link to the PR:
    • [@carlosmiceli] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@carlosmiceli] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@carlosmiceli] Determine if we should create a regression test for this bug.
    • [@carlosmiceli] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@OfstadC] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions