Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: N
Issue was found when executing this PR: #48652
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Click on the search icon in any report.
- Enter an email address that has custom avatar and display name.
Expected Result:
The search result will show user with custom avatar and display name.
Actual Result:
The search result shows user with fallback avatar and email address as display name instead of custom avatar and custom display name.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6639700_1729346685510.bandicam_2024-10-19_22-01-20-118.mp4
Metadata
Metadata
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.EngineeringReviewingHas a PR in reviewHas a PR in reviewWeeklyKSv2KSv2
Activity
melvin-bot commentedon Oct 19, 2024
Triggered auto assignment to @isabelastisser (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 19, 2024
Triggered auto assignment to @MarioExpensify (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 19, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 19, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
hannojg commentedon Oct 21, 2024
Hey, I was responsible for the accused PR. Feel free to assign this to me I can look into it today!
hannojg commentedon Oct 21, 2024
Hm, i can neither reproduce this on staging or latest dev commit:
Screen.Recording.2024-10-21.at.10.18.47.mov
The PR hasn't changed anything about how we display search results, it just changed how we filter for them. So i am not really sure if the PR could've caused such behaviour.
MarioExpensify commentedon Oct 21, 2024
I also cannot reproduce here, either from the Desktop or the WebApp, both react to the search the same as Production App.
Maybe we could get this retested?
33 remaining items
isabelastisser commentedon Nov 25, 2024
Hey @chrispader, can you please follow up on the questions above? Thanks!
chrispader commentedon Nov 25, 2024
Hey so sorry for the massive delay! I was totally busy on another PR and should have looked into this way earlier! 🫠
I investigated the problem and can clearly reproduce the problem for a particular set of accounts/email addresses.
Problem
The problem essentially is that the response received from the backend for
SearchForReportssometimes returns alogin(email) property in the fetched (to-be merged)personalDetails, whereas sometimes not.If no
loginproperty is provided in the response from the backend, the personal details option received fromuseOptionsList()will not have aloginproperty and therefore the logic inOptionsListUtils.filterOptions()is not able to match it to the email that the user types in the search field.Because the logic couldn't find any personal details item, we will just add a "blank" options list item to the options list and therefore the default avatar is used.
Solution
Because of this i would argue that this is a backend issue and the
SearchForReportsshould always return aloginproperty for the Onyx keypersonalDetailsList_. Looking into the local Onyx DB, we also don't really have any other data to match the (typed in) email address to the personal details, except for the name (could be ambiguous) or the account ID, where we would have to do a very complex and costly lookup.Backend responses for different accounts/email addresses and Onyx DB screenshot
yonghongkok2@gmail.com: (same as in the repro video)hanno@margelo.com:personalDetailsList_key:chrispader commentedon Nov 25, 2024
I don't think it is on purpose, that the backend doesn't send a
loginproperty for some accounts, right?Or am i missing something here?
cc @marcaaron @isabelastisser
marcaaron commentedon Nov 26, 2024
AFAICT there's really only one case where we would not return a
loginin thepersonalDetail.There is a property called
isKnownUserand if it'sfalsethen nologinis returned (actually a few other fields will not be returned eitherpronouns,timezone,phoneNumberandvalidated). Internal code here.I think this feature is working as intended. @puneetlath worked on this and can give a second opinion. But my guess for this issue based on the evidence provided is that we didn't make the connection to
isKnownUserfeature.puneetlath commentedon Nov 26, 2024
That sounds correct to me. You should get the full personal details, including login, when you "know" someone. You should get the partial personal details when you don't.
chrispader commentedon Nov 26, 2024
Ok i understand. Does that mean, that since we don't receive these infos, we also don't want to show things like the avatar?
Without the email, address we cannot really match it with the search input... e.g. when i'm searching for an email address of a user i "don't know", e.g. "yonghongkok2@gmail.com", we receive the missing data like avatar and name from the
SearchForReportsquery, but cannot match it with the mail address.marcaaron commentedon Nov 26, 2024
I think what is being reported is probably fine and we should close this out (but seems like it could reopen again as a suspected bug). We could maybe improve the UX so that "not known" users show up with a
?avatar or something, but I don't feel strongly about prioritizing this right now.isabelastisser commentedon Dec 5, 2024
Closing this!