Closed
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: v9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #50543
Email or phone of affected tester (no customers): applausetester+ck1018@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Navigate to staging.new.expensify.com
- Click on FAB > Submit Expense > Scan > Upload a receipt > Choose a recipient > Submit
- Notice that "Allow location access" modal is displayed
Expected Result:
Get It" option should be displayed in allow location access modal
Actual Result:
"Get it" button not displayed in Allow location access modal when scan expense
Instead "Continue" button is displayed
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6639212_1729289167862.Recording__111.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021848254647579098944
- Upwork Job ID: 1848254647579098944
- Last Price Increase: 2024-10-21
Issue Owner
Current Issue Owner: @s77rtMetadata
Metadata
Assignees
Labels
BugSomething is broken. Auto assigns a BugZero manager.Something is broken. Auto assigns a BugZero manager.DailyKSv2KSv2ExternalAdded to denote the issue can be worked on by a contributorAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsApply this label when an issue is open to proposals by contributors
Type
Projects
- StatusShow more project fieldsDone
Activity
melvin-bot commentedon Oct 19, 2024
Triggered auto assignment to @kadiealexander (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.IuliiaHerets commentedon Oct 19, 2024
We think that this bug might be related to #wave-collect - Release 1
IuliiaHerets commentedon Oct 19, 2024
@kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
[-]"Get it" button not displayed in Allow location access modal when scan expense[/-][+][$250] "Get it" button not displayed in Allow location access modal when scan expense[/+]melvin-bot commentedon Oct 21, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021848254647579098944
melvin-bot commentedon Oct 21, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (
External)omoh128 commentedon Oct 21, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
The location permission modal is displaying incorrect button text ("Continue") instead of the required "Get it" text when requesting location access.
What is the root cause of that problem?
The component is using the wrong translation key. Currently in
App/src/components/LocationPermissionModal/index.tsx:What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
Using a hardcoded string directly in the component.
if (!hasError) {
return "Get it";
}
melvin-bot commentedon Oct 21, 2024
📣 @omoh128! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
s77rt commentedon Oct 21, 2024
This is not a valid. Looking at the code we will show "Got it" only if you block location access on web platform. IOW
Is location access blocked ? "Got it" (web) / "Settings" (native). Otherwise "Continue"
@kadiealexander Let's close this one