Skip to content

[$250] "Get it" button not displayed in Allow location access modal when scan expense #51124

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: v9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: Y
Issue was found when executing this PR: #50543
Email or phone of affected tester (no customers): applausetester+ck1018@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Navigate to staging.new.expensify.com
  2. Click on FAB > Submit Expense > Scan > Upload a receipt > Choose a recipient > Submit
  3. Notice that "Allow location access" modal is displayed

Expected Result:

Get It" option should be displayed in allow location access modal

Actual Result:

"Get it" button not displayed in Allow location access modal when scan expense

Instead "Continue" button is displayed

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6639212_1729289167841!Screenshot_2024-10-18_at_5 56 46_PM
Bug6639212_1729289167862.Recording__111.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021848254647579098944
  • Upwork Job ID: 1848254647579098944
  • Last Price Increase: 2024-10-21
Issue OwnerCurrent Issue Owner: @s77rt

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 19, 2024
  2. melvin-bot commented on Oct 19, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Oct 19, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-collect - Release 1

  4. IuliiaHerets commented on Oct 19, 2024

    @IuliiaHerets
    Author

    @kadiealexander FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 21, 2024
  6. changed the title [-]"Get it" button not displayed in Allow location access modal when scan expense[/-] [+][$250] "Get it" button not displayed in Allow location access modal when scan expense[/+] on Oct 21, 2024
  7. melvin-bot commented on Oct 21, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 21, 2024
  9. melvin-bot commented on Oct 21, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

  10. omoh128 commented on Oct 21, 2024

    @omoh128

    Proposal

    Please re-state the problem that we are trying to solve in this issue.
    The location permission modal is displaying incorrect button text ("Continue") instead of the required "Get it" text when requesting location access.

    What is the root cause of that problem?
    The component is using the wrong translation key. Currently in App/src/components/LocationPermissionModal/index.tsx:

    if (!hasError) {
        return translate('common.continue');
    }

    What changes do you think we should make in order to solve the problem?

    1. Add new translation key in language files:
    // en.ts
    common: {
        getIt: "Get it"
    }
    
    // es.ts
    common: {
        getIt: "Entendido"  
    }
    
    Using a conditional translation based on the modal context.
    
    
    if (!hasError) {
        return isLocationModal ? translate('common.getIt') : translate('common.continue');
    }
    
    Creating a separate component for location-specific modals,
    
    
    const LocationAccessButton = () => {
        return <Button text={translate('common.getIt')} />;
    };
    1. Update the modal component to use the new translation key:
    if (!hasError) {
        return translate('common.getIt');
    }

    What alternative solutions did you explore? (Optional)

    Using a hardcoded string directly in the component.

    if (!hasError) {
    return "Get it";
    }

  11. melvin-bot commented on Oct 21, 2024

    @melvin-bot

    📣 @omoh128! 📣
    Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
    Please follow these steps:

    1. Make sure you've read and understood the contributing guidelines.
    2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
    3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
    4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
      Screen Shot 2022-11-16 at 4 42 54 PM
      Format:
    Contributor details
    Your Expensify account email: <REPLACE EMAIL HERE>
    Upwork Profile Link: <REPLACE LINK HERE>
    
  12. s77rt commented on Oct 21, 2024

    @s77rt
    Member

    This is not a valid. Looking at the code we will show "Got it" only if you block location access on web platform. IOW
    Is location access blocked ? "Got it" (web) / "Settings" (native). Otherwise "Continue"

    @kadiealexander Let's close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions