You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[$250] Search - "is not a valid email address" when starting a DM with phone user via Search #51137
Version Number: 9.0.51-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers):applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Click on the search icon on any report.
Enter a valid phone number.
Click on the search result to initiate a DM with the phone number.
Expected Result:
No error should show up because user should be able to initiate a DM with phone number user via Search.
Actual Result:
App shows "is not a valid email address" when starting a DM with phone user via Search.
Note that user can initiate DM with the same phone number via Start chat in FAB.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Edited by proposal-police: This proposal was edited at 2024-10-21 06:21:30 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
App shows "is not a valid email address" when starting a DM with phone user via Search.
Note that user can initiate DM with the same phone number via Start chat in FAB.
What is the root cause of that problem?
When generating the userToInvite data in new chat page:
Same as @289Adam289 and @jasperhuangg, I was not able to reproduce the issue, tried both on Dev (using both dev and staging server) and on Staging with the same phone number as OP video and the behaviour on my side when using 0714637364 phone number is:
the new user suggestion doesn't show up
the only error that shows up on my side is if the phone number is not valid, ex. 3234567864, stating:
Caution
The provided phone number belongs to a landline or VoIP, please use your email address instead.
If I use a valid phone number, starting with / without + and country code, say +13237069264, 13237069264 or 3237069264:
the new user suggestion shows up and if I click on it the report opens without any errors
Suggestion
Opened Report
🔴 I'm not sure what the parameters of @kavimuru reproducing the issue are, but unless we're able to consistently reproduce, I won't be able to move forward reviewing the existing proposal because I won't be able to verify the fix.
@puneetlath@jasperhuangg@ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
Activity
melvin-bot commentedon Oct 20, 2024
Triggered auto assignment to @jasperhuangg (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.github-actions commentedon Oct 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 20, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 20, 2024
💬 A slack conversation has been started in #expensify-open-source
truph01 commentedon Oct 21, 2024
Edited by proposal-police: This proposal was edited at 2024-10-21 06:21:30 UTC.
Proposal
Please re-state the problem that we are trying to solve in this issue.
App shows "is not a valid email address" when starting a DM with phone user via Search.
Note that user can initiate DM with the same phone number via Start chat in FAB.
What is the root cause of that problem?
App/src/libs/OptionsListUtils.ts
Line 2534 in 893ef36
we already have logic to format the search value string if it is phone number:
App/src/libs/OptionsListUtils.ts
Lines 2475 to 2476 in 893ef36
but we don't do it in Search:
App/src/components/Search/SearchRouter/SearchRouter.tsx
Lines 125 to 131 in 893ef36
What changes do you think we should make in order to solve the problem?
What alternative solutions did you explore? (Optional)
289Adam289 commentedon Oct 21, 2024
Hi! I cannot reproduce the bug. Can I ask for more reproduction steps?
Screen.Recording.2024-10-21.at.16.51.32.mp4
truph01 commentedon Oct 21, 2024
@289Adam289 I saw in your video, your searched
+15123xxx. Can you try0123xxx?24 remaining items
melvin-bot commentedon Oct 27, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (
External)ikevin127 commentedon Oct 28, 2024
ikevin127 commentedon Oct 29, 2024
Same as @289Adam289 and @jasperhuangg, I was not able to reproduce the issue, tried both on Dev (using both dev and staging server) and on Staging with the same phone number as OP video and the behaviour on my side when using
0714637364phone number is:3234567864, stating:Caution
The provided phone number belongs to a landline or VoIP, please use your email address instead.
If I use a valid phone number, starting with / without
+and country code, say+13237069264,13237069264or3237069264:🔴 I'm not sure what the parameters of @kavimuru reproducing the issue are, but unless we're able to consistently reproduce, I won't be able to move forward reviewing the existing proposal because I won't be able to verify the fix.
melvin-bot commentedon Nov 3, 2024
@puneetlath @jasperhuangg @ikevin127 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
melvin-bot commentedon Nov 4, 2024
@puneetlath, @jasperhuangg, @ikevin127 Eep! 4 days overdue now. Issues have feelings too...
puneetlath commentedon Nov 4, 2024
Ok, I think let's just close this for now since no one is able to reproduce.