You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-12-05] Review duplicates - Review duplicates button does not disappear after the expense is paid #51141
Version Number: 9.0.51-1 Reproducible in staging?: Y Reproducible in production?: N Email or phone of affected tester (no customers):applausetester+kh081006@applause.expensifail.com Issue reported by: Applause Internal Team
Action Performed:
Go to staging.new.expensify.com
Create a new workspace.
Submit an expense to the workspace chat.
Pay the expense.
Submit the same expense in Step 3 to the workspace chat.
Click on the expense preview.
Click Pay elsewhere and pay it.
Expected Result:
Review duplicates button will disappear after the expense is paid.
Actual Result:
Review duplicates button does not disappear after the expense is paid. It only disappears after the page is refreshed.
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf@adelekennedy@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:
Where bug was reported:
2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
2b. Reported on staging (eg. found during regression or PR testing)
2d. Reported on a PR
2z. Other:
Who reported the bug:
3a. Expensify user
3b. Expensify employee
3c. Contributor
3d. QA
3z. Other:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A (This was a BE bug, with optimistic data fix on the FE)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
The account should be on canUseDupeDetection
Test:
Create a new workspace.
Submit an expense to the workspace chat.
Pay the expense.
Submit the same expense in Step 3 to the workspace chat.
Click on the expense preview.
Click Pay elsewhere and pay it.
Verify the Review duplicates button disappears after the expense is paid.
Activity
melvin-bot commentedon Oct 20, 2024
Triggered auto assignment to @adelekennedy (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 20, 2024
Triggered auto assignment to @marcochavezf (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 20, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 20, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
IuliiaHerets commentedon Oct 20, 2024
We think that this bug might be related to #wave-control
Shahidullah-Muffakir commentedon Oct 20, 2024
Related PR #50133
daledah commentedon Oct 21, 2024
This is likely a BE Bug, as
PayMoneyRequestdoesn't removetransactionViolationsin Onyx:We can add optimistic data to remove
transactionViolationsfrom the FE side, but I think we should apply the same change to BE as well.27 remaining items
melvin-bot commentedon Nov 28, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 28, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-12-05. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 28, 2024
@allgandalf @adelekennedy @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Dec 5, 2024
Payment Summary
Upwork Job
BugZero Checklist (@adelekennedy)
allgandalf commentedon Dec 5, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A (This was a BE bug, with optimistic data fix on the FE)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify the Review duplicates button disappears after the expense is paid.
Do we agree 👍 or 👎
adelekennedy commentedon Dec 6, 2024
@allgandalf what is your upwork profile so I can send you an offer?
melvin-bot commentedon Dec 10, 2024
@marcochavezf, @adelekennedy, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!
adelekennedy commentedon Dec 11, 2024
Just got your message on Slack @allgandalf paying out now
adelekennedy commentedon Dec 11, 2024
payment made!