Skip to content

[HOLD for payment 2024-12-05] Review duplicates - Review duplicates button does not disappear after the expense is paid #51141

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.51-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Create a new workspace.
  3. Submit an expense to the workspace chat.
  4. Pay the expense.
  5. Submit the same expense in Step 3 to the workspace chat.
  6. Click on the expense preview.
  7. Click Pay elsewhere and pay it.

Expected Result:

Review duplicates button will disappear after the expense is paid.

Actual Result:

Review duplicates button does not disappear after the expense is paid. It only disappears after the page is refreshed.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6640180_1729422842946.20241020_184629.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @adelekennedy

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 20, 2024
  2. melvin-bot commented on Oct 20, 2024

    @melvin-bot

    Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 20, 2024

    @melvin-bot

    Triggered auto assignment to @marcochavezf (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 20, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 20, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. IuliiaHerets commented on Oct 20, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-control

  7. Shahidullah-Muffakir commented on Oct 20, 2024

    @Shahidullah-Muffakir
    Contributor

    Related PR #50133

  8. daledah commented on Oct 21, 2024

    @daledah
    Contributor

    This is likely a BE Bug, as PayMoneyRequest doesn't remove transactionViolations in Onyx:

    Screenshot 2024-10-21 at 12 07 40 Screenshot 2024-10-21 at 12 08 19

    We can add optimistic data to remove transactionViolations from the FE side, but I think we should apply the same change to BE as well.

  9. 27 remaining items

  10. melvin-bot commented on Nov 28, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Nov 28, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.67-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-12-05. 🎊

    For reference, here are some details about the assignees on this issue:

    • @allgandalf requires payment (Needs manual offer from BZ)
  12. melvin-bot commented on Nov 28, 2024

    @melvin-bot

    @allgandalf @adelekennedy @allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  13. melvin-bot commented on Dec 5, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@adelekennedy)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  14. allgandalf commented on Dec 5, 2024

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: N/A (This was a BE bug, with optimistic data fix on the FE)

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • The account should be on canUseDupeDetection

    Test:

    1. Create a new workspace.
    2. Submit an expense to the workspace chat.
    3. Pay the expense.
    4. Submit the same expense in Step 3 to the workspace chat.
    5. Click on the expense preview.
    6. Click Pay elsewhere and pay it.

    Verify the Review duplicates button disappears after the expense is paid.

    Do we agree 👍 or 👎

  15. adelekennedy commented on Dec 6, 2024

    @adelekennedy
    Contributor

    @allgandalf what is your upwork profile so I can send you an offer?

  16. melvin-bot commented on Dec 10, 2024

    @melvin-bot

    @marcochavezf, @adelekennedy, @allgandalf Whoops! This issue is 2 days overdue. Let's get this updated quick!

  17. adelekennedy commented on Dec 11, 2024

    @adelekennedy
    Contributor

    Just got your message on Slack @allgandalf paying out now

  18. adelekennedy commented on Dec 11, 2024

    @adelekennedy
    Contributor

    payment made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringInternalRequires API changes or must be handled by Expensify staff

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions