Skip to content

[HOLD for payment 2024-11-18] [$250] iOS - App crashes when opening attachments in #expensify-roadmap public room #51181

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.51.2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
Issue reported by: Applause Internal Team

Action Performed:

  1. Open the app and log in
  2. Send the link to the #expensify-roadmap public room https://staging.new.expensify.com/r/868417741568295 in any chat
  3. Open the link
  4. Scroll up and open any attachment

Expected Result:

The attachment is opened

Actual Result:

The app crashes. Sometimes attachments open, but the app crashes when swiping to another attachment.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6641063_1729518281267!ios.txt

Bug6641063_1729518281258.IMG_0541.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021849220985376407970
  • Upwork Job ID: 1849220985376407970
  • Last Price Increase: 2024-10-23
  • Automatic offers:
    • shubham1206agra | Reviewer | 104573284
Issue OwnerCurrent Issue Owner: @puneetlath

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 21, 2024
  2. melvin-bot commented on Oct 21, 2024

    @melvin-bot

    Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. IuliiaHerets commented on Oct 21, 2024

    @IuliiaHerets
    Author

    @puneetlath FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 23, 2024
  5. changed the title [-]iOS - App crashes when opening attachments in #expensify-roadmap public room[/-] [+][$250] iOS - App crashes when opening attachments in #expensify-roadmap public room[/+] on Oct 23, 2024
  6. melvin-bot commented on Oct 23, 2024

    @melvin-bot
  7. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Oct 23, 2024
  8. melvin-bot commented on Oct 23, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

  9. 23 remaining items

  10. puneetlath commented on Nov 18, 2024

    @puneetlath
    Contributor

    @shubham1206agra friendly reminder about the checklist.

  11. melvin-bot commented on Nov 22, 2024

    @melvin-bot

    @puneetlath, @JKobrynski, @shubham1206agra Whoops! This issue is 2 days overdue. Let's get this updated quick!

  12. shubham1206agra commented on Nov 28, 2024

    @shubham1206agra
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/30829/files#r1862540734

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not Required

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Test:

    1. Open the app and log in
    2. Send the link to the #expensify-roadmap public room https://staging.new.expensify.com/r/868417741568295 (or https://dev.new.expensify.com:8082/r/868417741568295. in development) in any chat
    3. Open the link
    4. Scroll up and open any attachment
    5. Verify the app is not crashing, and there are no related errors in the console

    Do we agree 👍 or 👎

  13. puneetlath commented on Dec 4, 2024

    @puneetlath
    Contributor

    Looks like the original offer expired. @shubham1206agra please ping me here when you've accepted this one: https://www.upwork.com/nx/wm/offer/105192072

  14. shubham1206agra commented on Dec 11, 2024

    @shubham1206agra
    Contributor

    @puneetlath Can you finish the payment here?

  15. puneetlath commented on Dec 11, 2024

    @puneetlath
    Contributor

    All paid. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.ExternalAdded to denote the issue can be worked on by a contributorWeeklyKSv2

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions