Repository navigation
[HOLD for payment 2024-11-28] [$250] Contact Methods - Navigated back to "New contact method" when going back to online #51189
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.51-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): dave0123seife@gmail.com
Issue reported by: Applause - Internal Team
Action Performed:
- Navigate to account settings > Profile
- Click on "Contact Method"
- Click on "New Contact method"
- Add a email > Add
- In the verification page go Offline and return back online
Expected Result:
User is not Navigated back to "New contact method" when going back to online
Actual Result:
Navigated back to "New contact method" when going back to online
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
Bug6641216_1729527065628.Screen_Recording_2024-10-21_at_6.57.57_in_the_evening.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021853397434469388025
- Upwork Job ID: 1853397434469388025
- Last Price Increase: 2024-11-11
- Automatic offers:
- wildan-m | Contributor | 104874938
Activity
melvin-bot commentedon Oct 21, 2024
Triggered auto assignment to @zanyrenney (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Oct 21, 2024
@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
ChavdaSachin commentedon Oct 21, 2024
No more reproducible, it was solved here
#49445
zanyrenney commentedon Oct 23, 2024
Closing as solved above!
lanitochka17 commentedon Oct 29, 2024
Issue is still reproducible on the mWeb/Chrome on the latest build 9.0.55-2
Record_2024-10-29-14-44-02.mp4
zanyrenney commentedon Oct 29, 2024
Hmm i can't reproduce this.
zanyrenney commentedon Oct 31, 2024
@lanitochka17 still about to reproduce?
lanitochka17 commentedon Oct 31, 2024
User is still Navigated back to "New contact method". But now tester is seeing that user is navigated to "New contact method" page when pressing on cmd + D.
Screen.Recording.2024-10-31.at.5.53.19.in.the.afternoon.mp4
33 remaining items
[-][$250] Contact Methods - Navigated back to "New contact method" when going back to online[/-][+][HOLD for payment 2024-11-28] [$250] Contact Methods - Navigated back to "New contact method" when going back to online[/+]melvin-bot commentedon Nov 21, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 21, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.64-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 21, 2024
@fedirjh @zanyrenney @fedirjh The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
zanyrenney commentedon Nov 28, 2024
I have asked @fedirjh to complete checklist
fedirjh commentedon Nov 28, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: Show No access Modal when Copilot tries to add new contact method on behalf of owner. #50643 (comment)
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Offlineand returnOnlineDo we agree 👍 or 👎
zanyrenney commentedon Nov 28, 2024
https://github.com/Expensify/Expensify/issues/448571
zanyrenney commentedon Nov 28, 2024
payment summary
@wildan-m requires payment automatic offer (Contributor) - paid $250 via upwork
@fedirjh requires payment through NewDot Manual Requests - please request $250 via ND.
garrettmknight commentedon Dec 10, 2024
$250 approved for @fedirjh