Repository navigation
[HOLD for payment 2024-11-20] [$250] FAB - Track expense option is not present in FAB for Expensifail account #51242
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Log in with a new Expensifail account.
- Open FAB.
Expected Result:
Track expense option will be present.
Actual Result:
Track expense option is not present in FAB for Expensifail account.
This issue is not reproducible on Gmail.
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6641966_1729596849447.20241022_193129.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021855906845087708354
- Upwork Job ID: 1855906845087708354
- Last Price Increase: 2024-11-11
Activity
melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @johncschuster (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @Julesssss (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 22, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Julesssss commentedon Oct 22, 2024
Occurring because the selfDM is not being detected. Checking to see if this is intentional.
Julesssss commentedon Oct 22, 2024
Checking to see if reverting this PR resolves the issue.
Julesssss commentedon Oct 22, 2024
Yeah, my revert PR resolves the bug.
43 remaining items
melvin-bot commentedon Nov 13, 2024
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Nov 13, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.60-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-20. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 13, 2024
@brunovjk @johncschuster @brunovjk The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
johncschuster commentedon Nov 13, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal Template
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
quinthar commentedon Nov 16, 2024
Fixed for me, thanks!
johncschuster commentedon Nov 18, 2024
Payment Summary:
Contributor: @brunovjk paid $250 via Upwork following regression threshold
Upwork job here! Please apply
brunovjk commentedon Nov 19, 2024
@johncschuster should I complete the BugZero checklist here? Thanks.
johncschuster commentedon Nov 19, 2024
@brunovjk, yes, please!
brunovjk commentedon Nov 19, 2024
BugZero Checklist:
Bug classification
Source of bug:
FloatingActionButtonAndPopovertouseOnyx. The memoization dependencies were incomplete, causingselfDMReportIDto returnundefined. A fix was implemented to update dependencies by addingisCreateMenuActive.Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: No PR directly introduced this bug.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion:
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
Regression Test Proposal
Test:
Do we agree 👍 or 👎
melvin-bot commentedon Nov 20, 2024
Payment Summary
Upwork Job
BugZero Checklist (@johncschuster)
johncschuster commentedon Nov 20, 2024
Paid! Thanks for your contributions, @brunovjk!