Repository navigation
[$250] Expense - Expense amount is not added but substracted when submitting from the expense report #51249
Description
If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!
Version Number: 9.0.52-1
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team
Action Performed:
- Go to staging.new.expensify.com
- Go to FAB > Submit expense > Manual.
- Submit a manual expense to any user.
- In the main chat, click on the expense preview.
- In the expense report, click + > Submit expense > Manual (important).
- Submit a manual expense of the same amount in Step 3.
Expected Result:
The total amount of the expenses will be calculated correctly.
Actual Result:
The expense amount is 0.00.
Expense amount is not added but substracted when submitting from the expense report
Workaround:
Unknown
Platforms:
- Android: Standalone
- Android: HybridApp
- Android: mWeb Chrome
- iOS: Standalone
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
Screenshots/Videos
Bug6642009_1729600385033.20241022_203023.mp4
Upwork Automation - Do Not Edit
- Upwork Job URL: https://www.upwork.com/jobs/~021848735249840900998
- Upwork Job ID: 1848735249840900998
- Last Price Increase: 2024-10-22
Activity
melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @lschurr (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Oct 22, 2024
Triggered auto assignment to @flodnv (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 22, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 22, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 22, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021848735249840900998
[-]Expense - Expense amount is not added but substracted when submitting from the expense report[/-][+][$250] Expense - Expense amount is not added but substracted when submitting from the expense report[/+]7 remaining items
flodnv commentedon Oct 22, 2024
Looking at server logs, I'm wondering if this is because the first RequestMoney creates the transaction with a negative amount, and subsequent ones create the transaction with a positive amount
flodnv commentedon Oct 22, 2024
@bernhardoj are you able to reproduce on the latest main?
flodnv commentedon Oct 22, 2024
I think this is happening because the App code on staging is sending a
policyIDwhen it should not be.flodnv commentedon Oct 22, 2024
Caused by this PR #49412
Removing this line fixes this bug.
flodnv commentedon Oct 22, 2024
I'm proposing we revert the PR: https://expensify.slack.com/archives/C01GTK53T8Q/p1729612151981119
flodnv commentedon Oct 22, 2024
@ishpaul777 is taking over this.
melvin-bot commentedon Nov 5, 2024
@flodnv @lschurr @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!
flodnv commentedon Nov 6, 2024
This was fixed
melvin-bot commentedon Nov 6, 2024
@flodnv @lschurr Be sure to fill out the Contact List!