Skip to content

[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Profile - "Failed to add this contact method" error appears when correct magic code is entered #51274

New issue
New issue
Closed
Closed
[HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Profile - "Failed to add this contact method" error appears when correct magic code is entered#51274
Assignees
rlinozalexpensify
Labels
Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Description

@IuliiaHerets
IuliiaHerets
opened on Oct 22, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.52-2
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): applausetester+kh081006@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to Account settings > Profile > Contact method.
  3. Click New contact method.
  4. Enter a new contact method > Click Add.
  5. Enter incorrect magic code.
  6. Click RHP back button without clearing the magic code and the error message.
  7. Click Add.
  8. Enter incorrect magic code.
  9. Clear the field.
  10. Enter the correct magic code, then hit Enter (important, do not use cursor to click Verify).
  11. Note that the new contact method shows "Failed to add this contact method.".
  12. Click on the new contact method.
  13. Magic code page opens despite the error message.

Expected Result:

In Step 11, there should not be "Failed to add this contact method." error under the new contact method, because the correct magic code is entered in Step 10, and also magic code page opens in the next step (Step 13) which means there is no issue with adding the contact method.

Actual Result:

In Step 11, there is "Failed to add this contact method." error under the new contact method.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6642214_1729611656948.20241022_232609.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. IuliiaHerets
    added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 22, 2024

  2. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botBot
    on Oct 22, 2024 – with Melvin Bot

    Triggered auto assignment to @rlinoz (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  3. melvin-bot
    assigned
    rlinoz
    and
    alexpensify
    on Oct 22, 2024

  4. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botBot
    on Oct 22, 2024 – with Melvin Bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  5. melvin-bot
    added
    DailyKSv2
    on Oct 22, 2024

  6. melvin-bot commented on Oct 22, 2024

    @melvin-bot
    melvin-botBot
    on Oct 22, 2024 – with Melvin Bot

    💬 A slack conversation has been started in #expensify-open-source

  7. github-actions
    added
    Engineering
    HourlyKSv2
    and removed
    DailyKSv2
    on Oct 22, 2024

  8. github-actions commented on Oct 22, 2024

    @github-actions
    github-actionsBot
    on Oct 22, 2024 – with GitHub Actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.

  9. rlinoz commented on Oct 22, 2024

    @rlinoz
    rlinoz
    on Oct 22, 2024
    Contributor

    Caused by: #49445

    Looks like a fix is almost ready: #51267

  10. getusha commented on Oct 22, 2024

    @getusha
    getusha
    on Oct 22, 2024
    Contributor

    I am not able to reproduce this issue

    Screen.Recording.2024-10-22.at.9.01.34.at.night.mov

  11. rlinoz commented on Oct 22, 2024

    @rlinoz
    rlinoz
    on Oct 22, 2024
    Contributor

    @getusha I think you skipped step 8

  12. 14 remaining items

  13. melvin-bot commented on Oct 23, 2024

    @melvin-bot
    melvin-botBot
    on Oct 23, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rlinoz] The PR that introduced the bug has been identified. Link to the PR:
    • [@rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rlinoz] Determine if we should create a regression test for this bug.
    • [@rlinoz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  14. tgolen commented on Oct 23, 2024

    @tgolen
    tgolen
    on Oct 23, 2024
    Contributor

    @rlinoz Why was this one closed without filling out the checklist?

  15. tgolen
    reopened this on Oct 23, 2024
  16. yuwenmemon
    removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 23, 2024

  17. yuwenmemon commented on Oct 23, 2024

    @yuwenmemon
    yuwenmemon
    on Oct 23, 2024
    Contributor

    https://expensify.slack.com/archives/C07J32337/p1729726700727579

  18. rlinoz commented on Oct 24, 2024

    @rlinoz
    rlinoz
    on Oct 24, 2024
    Contributor

    DM'd Tim to better understand the process of dealing with deploy blockers, but meanwhile here is the checklist:

    • The PR that introduced the bug has been identified. Link to the PR: Refactor: reuse ValidateCodeActionModal #49445
    • The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Refactor: reuse ValidateCodeActionModal #49445 (comment), fix was implemented by author so the why is not outlined
    • A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
    • Determine if we should create a regression test for this bug: We have test cases for this, so no need
  19. rlinoz
    closed this as completedon Oct 24, 2024
  20. melvin-bot
    added
    WeeklyKSv2
    and removed
    WeeklyKSv2
    on Oct 25, 2024
  21. melvin-bot
    changed the title [-][HOLD for payment 2024-10-30] Profile - "Failed to add this contact method" error appears when correct magic code is entered[/-] [+][HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] Profile - "Failed to add this contact method" error appears when correct magic code is entered[/+] on Oct 25, 2024

  22. melvin-bot commented on Oct 25, 2024

    @melvin-bot
    melvin-botBot
    on Oct 25, 2024 – with Melvin Bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.53-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-01. 🎊

  23. melvin-bot commented on Oct 25, 2024

    @melvin-bot
    melvin-botBot
    on Oct 25, 2024 – with Melvin Bot

    BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

    • [@rlinoz] The PR that introduced the bug has been identified. Link to the PR:
    • [@rlinoz] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
    • [@rlinoz] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
    • [@rlinoz] Determine if we should create a regression test for this bug.
    • [@rlinoz] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
    • [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

  24. alexpensify commented on Oct 31, 2024

    @alexpensify
    alexpensify
    on Oct 31, 2024
    Contributor

    @rlinoz - I see contributors mentioned in some of the PRs listed here. Are their payments being handled in other GHs or do we need to reopen this one for payments?

  25. rlinoz commented on Oct 31, 2024

    @rlinoz
    rlinoz
    on Oct 31, 2024
    Contributor

    @alexpensify no need, it was a follow up to a previous PR that they worked on

  26. alexpensify commented on Nov 1, 2024

    @alexpensify
    alexpensify
    on Nov 1, 2024
    Contributor

    Ok, keeping this one closed - No payment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions