Skip to content

[HOLD for payment 2024-11-13] [$250] Tags - App returns to tag page after tapping back button on workspace editor #51414

Closed

Description

@IuliiaHerets

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.53-1
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5123688
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause Internal Team

Action Performed:

Precondition:

  • Workspace has imported dependent tags (attached below).
  1. Launch ND or hybrid app.
  2. Go to workspace settings > Tags.
  3. Tap on any main tag.
  4. Tap app back button to go back to main tag page.
  5. Tap app back button to return to workspace editor.
  6. Tap app back button again.

Expected Result:

App will return to workspace list

Actual Result:

App returns to tag page after tapping back button on workspace editor.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6644449_1729774664725.iOS.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021849826177749803490
  • Upwork Job ID: 1849826177749803490
  • Last Price Increase: 2024-10-25
Issue OwnerCurrent Issue Owner: @isabelastisser

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 24, 2024
  2. melvin-bot commented on Oct 24, 2024

    @melvin-bot

    Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Oct 24, 2024

    @melvin-bot

    Triggered auto assignment to @Julesssss (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 24, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Oct 24, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. IuliiaHerets commented on Oct 24, 2024

    @IuliiaHerets
    Author

    We think that this bug might be related to #wave-collect - Release 1

  7. Julesssss commented on Oct 24, 2024

    @Julesssss
    Contributor

    Regression, but not a blocker. Removing label.

  8. 27 remaining items

  9. melvin-bot commented on Nov 6, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  10. melvin-bot commented on Nov 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-13. 🎊

    For reference, here are some details about the assignees on this issue:

    • @ntdiary requires payment through NewDot Manual Requests
  11. melvin-bot commented on Nov 6, 2024

    @melvin-bot

    @ntdiary @isabelastisser The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  12. ntdiary commented on Nov 6, 2024

    @ntdiary
    Contributor

    I didn't review PR #51568, so no need to include me in the payment. 😄

  13. mvtglobally commented on Nov 8, 2024

    @mvtglobally

    Issue not reproducible during KI retests. (First week)

  14. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Reviewer: @ntdiary owed $250 via NewDot

    BugZero Checklist (@isabelastisser)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1849826177749803490/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  15. isabelastisser commented on Nov 13, 2024

    @isabelastisser
    Contributor

    @Julesssss, was this an internal issue? It looks like no external contributor was involved.

  16. Julesssss commented on Nov 14, 2024

    @Julesssss
    Contributor

    Hey, it looks like @twilight2294 was the PR author, and @paultsimura was the C+ reviewer.

  17. paultsimura commented on Nov 14, 2024

    @paultsimura
    Contributor

    Hi, this one was a follow-up, so it can be closed without a payment.

  18. Julesssss commented on Nov 14, 2024

    @Julesssss
    Contributor

    Aha, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributors

Type

No type

Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions