Repository navigation
Latest android release builds are instantly crashing due to JS errors #51454
Description
Slack thread: https://margelo.slack.com/archives/C05LX9D6E07/p1729847485394869
After releasing 9.0.54-0 we are experiencing constant crashes of the android app when build in release mode:
E FATAL EXCEPTION: mqt_native_modules (Ask Gemini)
Process: com.expensify.chat.e2edelta, PID: 27253
com.facebook.react.common.JavascriptException: Error: Exception in HostFunction: Could not enqueue microtask because they are disabled in this runtime, js engine: hermes, stack:
setImmediate@1:527723
setDriver@1:1660584
LocalForage@1:1659118
Steps to reproduce:
- Build the app for android in release mode and run
- Try to run the latest staging app from google play
Activity
hannojg commentedon Oct 25, 2024
@kirillzyusko can you comment here, so you can be assigned for this?
kirillzyusko commentedon Oct 25, 2024
Yes, sure
Commenting to be assigned to this task 👀
melvin-bot commentedon Oct 25, 2024
Triggered auto assignment to @MonilBhavsar (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 25, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 25, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 25, 2024
Current assignee @MonilBhavsar is eligible for the Engineering assigner, not assigning anyone new.
9 remaining items
hannojg commentedon Oct 25, 2024
Did you figure what the root cause is, like why did turning it on caused this crash? Or is that something you're still working on understanding @WoLewicki ? (just very curious about this super weird bug)
WoLewicki commentedon Oct 25, 2024
Yeah, for now we managed to get to a point that:
setImmediateusesqueueMicrotaskunder the hood: https://github.com/facebook/react-native/blob/143b9d172ca755e2457e8dfc6009eeef2475a4a1/packages/react-native/Libraries/Core/Timers/immediateShim.js#L44It also happens on debug, but does not crash the app, that's why we didn't spot it since it's just a native crash. Now we are trying to understand why the flag for
queueMicrotaskis not enabled and if it should be at all.Beamanator commentedon Oct 28, 2024
Requesting CP to get this fixed up, since the revert PRs have been merged:
Beamanator commentedon Oct 28, 2024
CP completed - @hannojg are you online to give it a test?
hannojg commentedon Oct 28, 2024
@kirillzyusko can you test please
Beamanator commentedon Oct 28, 2024
@kirillzyusko confirmed here that the crash is not happening anymore!
mountiny commentedon Oct 28, 2024
Resolved
mountiny commentedon Oct 28, 2024
To close the loop, we are going to look into re-enabling the bridgeless mode on android in the original issue #48163
And also discussing here
melvin-bot commentedon Oct 29, 2024
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.
If a regression has occurred and you are the assigned CM follow the instructions here.
If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.