[Offline] Group chat - Group chat turns to not here page when creating group with non-existing account

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): applausetester+kh2010001@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Go to staging.new.expensify.com
Go offline
Go to FAB > Start chat
Enter any random gmail account (non-existing account)
Click Add to group
Start a group with the user
Go online

Expected Result:

Group chat will not turn to not here page after returning online

Actual Result:

Group chat turns to not here page after creating group chat with non-existing account offline and returning online

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6645533_1729859324388.20241025_201912.mp4

View all open jobs on GitHub

@mallenexpensify

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mallenexpensify

@mallenexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

Edited by proposal-police: This proposal was edited at 2024-10-27 14:23:02 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Group chat - Group chat turns to not here page when creating group with non-existing account

What is the root cause of that problem?

It shows 404 page not found because we did not pass the emailList value when requesting to the OpenReport API after change from offline to online

It's because when we go to offline mode and create new group, the OpenReport API get called 2 times, first when creating the group and second when opening the group chat

App/src/pages/NewChatConfirmPage.tsx

Lines 101 to 108 in 652d2ff

    
           const createGroup = useCallback(() => { 
        
               if (!newGroupDraft) { 
        
                   return; 
        
               } 
        
               const logins: string[] = (newGroupDraft.participants ?? []).map((participant) => participant.login); 
        
               Report.navigateToAndOpenReport(logins, true, undefined, newGroupDraft.reportName ?? '', newGroupDraft.avatarUri ?? '', avatarFile, optimisticReportID.current, true); 
        
           }, [newGroupDraft, avatarFile]);

After this PR #51093 we will replace duplicated OpenReport requests if the request.command and the report id is equal meaning it will replace the previous request with the new one (when opening group chat) which will remove the emailList value (from the previous request createGroup)

App/src/libs/actions/Report.ts

Lines 982 to 983 in 652d2ff

    
           checkAndFixConflictingRequest: (persistedRequests) => 
        
               resolveDuplicationConflictAction(persistedRequests, (request) => request.command === WRITE_COMMANDS.OPEN_REPORT && request.data?.reportID === reportID),

What changes do you think we should make in order to solve the problem?

We should check also for emailList if the previous request and current request is same
We can check also for other param like accountIDList if needed

API.paginate(CONST.API_REQUEST_TYPE.WRITE, WRITE_COMMANDS.OPEN_REPORT, parameters, {optimisticData, successData, failureData}, paginationConfig, {
    checkAndFixConflictingRequest: (persistedRequests) =>
        resolveDuplicationConflictAction(persistedRequests, (request) => request.command === WRITE_COMMANDS.OPEN_REPORT && request.data?.reportID === reportID && request.data?.emailList ===  parameters.emailList),
});

Result

Screen.Recording.2024-10-27.at.07.20.52.mov

What alternative solutions did you explore? (Optional)

@mallenexpensify

@mallenexpensify Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@NJ-2020

@NJ-2020 thanks for the proposal. I'm unsure exactly what I want to do with the issue so I added Needs Reproduction and Weekly. We're shifting internal priorities and I'm unsure where 'offline' issues fall into that.

Okay no problem, thank you

I'm back from OOO on Nov 14th, not assigning another BZ, if one is needed please add or post in #contributor-plus to ask for one to be added, thx.

Just spent 20 mins trying to get into new.expensify.com and staging.new.expensify.com with my mallen@expensifail.com account and had no luck with both, will revisit/test soon

@mallenexpensify

This has been fixed here #52350

cc: @mallenexpensify

@NJ-2020

Thanks @NJ-2020 , throwing retest weekly on it to get tested again before closing.

Issue not reproducible during KI retests. (First week)

Looks like it's fixed 🎉 (also... 🌮🌮🌮🌮🌮)

Navigation Menu

Repository navigation

[Offline] Group chat - Group chat turns to not here page when creating group with non-existing account #51473

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	const createGroup = useCallback(() => {
	if (!newGroupDraft) {
	return;
	}

	const logins: string[] = (newGroupDraft.participants ?? []).map((participant) => participant.login);
	Report.navigateToAndOpenReport(logins, true, undefined, newGroupDraft.reportName ?? '', newGroupDraft.avatarUri ?? '', avatarFile, optimisticReportID.current, true);
	}, [newGroupDraft, avatarFile]);

	checkAndFixConflictingRequest: (persistedRequests) =>
	resolveDuplicationConflictAction(persistedRequests, (request) => request.command === WRITE_COMMANDS.OPEN_REPORT && request.data?.reportID === reportID),

[Offline] Group chat - Group chat turns to not here page when creating group with non-existing account #51473

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 25, 2024

lanitochka17 commented on Oct 25, 2024

NJ-2020 commented on Oct 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

melvin-bot commented on Oct 28, 2024

MelvinBot commented on Oct 29, 2024

mallenexpensify commented on Oct 29, 2024

NJ-2020 commented on Oct 29, 2024

mallenexpensify commented on Nov 6, 2024

mallenexpensify commented on Nov 19, 2024

NJ-2020 commented on Nov 20, 2024

mallenexpensify commented on Nov 21, 2024

mvtglobally commented on Nov 29, 2024

mallenexpensify commented on Dec 2, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions