[HOLD for payment 2024-11-20] [$250] Expense-"Hidden" appears in Members list when the workspace is created via Pay with Expensify

@zanyrenney

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.54-1
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5134693
Email or phone of affected tester (no customers): applausetester+kh1610015@applause.expensifail.com
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

Default individual policy currency for both users must be USD.

Go to staging.new.expensify.com
[User A] Submit an expense in USD to User B
[User B] Go to DM with user A
4/ [User B] Click Pay with Expensify
[User B] Click Business bank account
[User B] Close the RHP
[User B] Go to workspace settings of the newly created workspace
[User B] Go to Members

Expected Result:

There will be no "Hidden" member

Actual Result:

"Hidden" member appears in Members list when the workspace is created via Pay with Expensify in p2p expense

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

Bug6645865_1729878847118.20241026_014655.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021853396876299534935
Upwork Job ID: 1853396876299534935
Last Price Increase: 2024-11-04

Issue Owner

Current Issue Owner: @zanyrenney

@zanyrenney

Triggered auto assignment to @zanyrenney (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@zanyrenney

@zanyrenney FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

We think that this bug might be related to #wave-collect - Release 1

Proposal

Please re-state the problem that we are trying to solve in this issue.

Hidden is shown in the workspace member after moving the expense to a new workspace.

What is the root cause of that problem?

When we select Business bank account as the payment method, we will optimistically create a new workspace based on the IOU report data.

App/src/components/KYCWall/BaseKYCWall.tsx

Lines 110 to 111 in 652d2ff

    
           if (iouReport && ReportUtils.isIOUReport(iouReport)) { 
        
               const {policyID, workspaceChatReportID, reportPreviewReportActionID} = Policy.createWorkspaceFromIOUPayment(iouReport) ?? {};

The problem is, we are trying to create the workspace member from the IOU report ownerEmail.

App/src/libs/actions/Policy/Policy.ts

Line 2134 in 652d2ff

const employeeEmail = iouReport.ownerEmail ?? '';

App/src/libs/actions/Policy/Policy.ts

Lines 2184 to 2191 in 652d2ff

    
           [sessionEmail]: { 
        
               role: CONST.POLICY.ROLE.ADMIN, 
        
               errors: {}, 
        
           }, 
        
           [employeeEmail]: { 
        
               role: CONST.POLICY.ROLE.USER, 
        
               errors: {}, 
        
           },

However, ownerEmail doesn't exist anymore in the IOU report, only ownerAccountID, so it defaults to an empty string.

What changes do you think we should make in order to solve the problem?

There was previously a plan to get the employee email from the personal detail, but I decided to just default it to an empty string because, at that time, the email wasn't really needed.

Previously, the policy member is keyed by their accountID.

So, the solution is to get the employee's email from the personal details data.

const employeeEmail = allPersonalDetails?.[employeeAccountID]?.login ?? '';

I don't think the personal detail login would be undefined, but we can avoid creating the employee optimistic data if employeeEmail is empty.

Wave collect is closed, but adding this to expense.

@zanyrenney

@zanyrenney Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

Oops, i thought I added the external label here - my bad!

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other: We removed ownerEmail from IOU report. However we forgot to update it while selecting Business Bank Account

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on both staging and production
2d. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/39489/files#r1849609429
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: Not a critical bug, we don't need to create a discussion.
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

User B requests money to User A in USD
User A press Pay with Expensify and choose Business Bank Account. Note down the new workspace created
Go to the workspace member page of the newly created workspace
Verify there is no Hidden member

Do we 👍 or 👎 ?

@hungvu193

Payment Summary

Upwork Job

Reviewer: @hungvu193 owed $250 via NewDot
Reviewer: @bernhardoj owed $250 via NewDot

BugZero Checklist (@zanyrenney)

I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1853396876299534935/hired)
I have paid out the Upwork contracts or cancelled the ones that are incorrect
I have verified the payment summary above is correct

Requested in ND.

@zanyrenney

@zanyrenney can you confirm the payment summary when you get a chance?

@garrettmknight

sure thing @garrettmknight - sorry about the delay everyone. I was out yesterday.

Regression test looks good - getting that added now.

https://github.com/Expensify/Expensify/issues/446583

@hungvu193

Closed job on upwork.

Payment Summary

Reviewer: @hungvu193 owed $250 via NewDot - please request via ND
Reviewer: @bernhardoj owed $250 via NewDot - please request via ND

@bernhardoj

$250 approved for @bernhardoj

@hungvu193

$250 approved for @hungvu193

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-20] [$250] Expense-"Hidden" appears in Members list when the workspace is created via Pay with Expensify #51524

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

36 remaining items

BugZero Checklist:

Regression Test Proposal

Payment Summary

BugZero Checklist (@zanyrenney)

Payment Summary

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	if (iouReport && ReportUtils.isIOUReport(iouReport)) {
	const {policyID, workspaceChatReportID, reportPreviewReportActionID} = Policy.createWorkspaceFromIOUPayment(iouReport) ?? {};

	[sessionEmail]: {
	role: CONST.POLICY.ROLE.ADMIN,
	errors: {},
	},
	[employeeEmail]: {
	role: CONST.POLICY.ROLE.USER,
	errors: {},
	},

[HOLD for payment 2024-11-20] [$250] Expense-"Hidden" appears in Members list when the workspace is created via Pay with Expensify #51524

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 26, 2024

lanitochka17 commented on Oct 26, 2024

lanitochka17 commented on Oct 26, 2024

bernhardoj commented on Oct 27, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

zanyrenney commented on Oct 29, 2024

melvin-bot commented on Nov 1, 2024

zanyrenney commented on Nov 4, 2024

36 remaining items

hungvu193 commented on Nov 20, 2024

BugZero Checklist:

Regression Test Proposal

melvin-bot commented on Nov 20, 2024

Payment Summary

BugZero Checklist (@zanyrenney)

bernhardoj commented on Nov 20, 2024

garrettmknight commented on Nov 20, 2024

zanyrenney commented on Nov 21, 2024

zanyrenney commented on Nov 21, 2024

zanyrenney commented on Nov 21, 2024

zanyrenney commented on Nov 21, 2024

Payment Summary

JmillsExpensify commented on Nov 21, 2024

garrettmknight commented on Nov 26, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions