[HOLD for payment 2024-11-13] [$250] Clicking " Please sign in again" does nothing in "Session Expired" page

@carlosmiceli

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number:
Reproducible in staging?: needs reproduction
Reproducible in production?: needs reproduction
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @carlosmiceli
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1729880182560339

Action Performed:

Have a " Your Session has Expired" screen
Click on "Please sign in again"

Expected Result:

User is taken to sign in screen

Actual Result:

Nothing happens

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021851043610237148822
Upwork Job ID: 1851043610237148822
Last Price Increase: 2024-10-28
Automatic offers:

aimane-chnaif | Reviewer | 104689909
NJ-2020 | Contributor | 104689912

Issue Owner

Current Issue Owner: @CortneyOfstad

This has been labelled "Needs Reproduction". Follow the steps here: https://stackoverflowteams.com/c/expensify/questions/16989

@CortneyOfstad

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking " Please sign in again" does nothing in "Session Expired" page

What is the root cause of that problem?

We should use goBack() function instead of navigate(), same like what we do here:

App/src/pages/LogInWithShortLivedAuthTokenPage.tsx

Lines 29 to 32 in 5103b4b

    
           Navigation.isNavigationReady().then(() => { 
        
               // We must call goBack() to remove the /transition route from history 
        
               Navigation.goBack(); 
        
               Navigation.navigate(ROUTES.HOME);

because it will remove the transition route from the history

App/src/pages/ErrorPage/SessionExpiredPage.tsx

Lines 35 to 39 in 5103b4b

    
           if (!NativeModules.HybridAppModule) { 
        
               Session.clearSignInData(); 
        
               Navigation.navigate(); 
        
               return; 
        
           }

Because if we use navigate, the transition history still persists which keeps showing the session expired page

App/src/libs/Navigation/AppNavigator/PublicScreens.tsx

Lines 24 to 33 in 5103b4b

    
           <RootStack.Screen 
        
               name={NAVIGATORS.BOTTOM_TAB_NAVIGATOR} 
        
               options={defaultScreenOptions} 
        
               component={NativeModules.HybridAppModule ? SessionExpiredPage : SignInPage} 
        
           /> 
        
           <RootStack.Screen 
        
               name={SCREENS.TRANSITION_BETWEEN_APPS} 
        
               options={defaultScreenOptions} 
        
               component={LogInWithShortLivedAuthTokenPage} 
        
           />

What changes do you think we should make in order to solve the problem?

We should use goBack instead of navigate

onPress={() => {
    if (!NativeModules.HybridAppModule) {
        Session.clearSignInData();
        Navigation.goBack();
        return;
    }
    NativeModules.HybridAppModule.closeReactNativeApp(true, false);
}}

OR

onPress={() => {
    if (!NativeModules.HybridAppModule) {
        Session.clearSignInData();
        Navigation.isNavigationReady().then(() => {
            Navigation.goBack();

            // OPTIONAL: Navigation.navigate(ROUTES.SIGN_IN_MODAL);
        });
        return;
    }
    NativeModules.HybridAppModule.closeReactNativeApp(true, false);
}}

Result

Screen.Recording.2024-10-27.at.18.29.28.mov

What alternative solutions did you explore? (Optional)

I am not able to recreate, so going to see if the C+ can recreate based on the SO linked above

Job added to Upwork: https://www.upwork.com/jobs/~021851043610237148822

@aimane-chnaif

Ohh, thank you @aimane-chnaif

Reviewing label has been removed, please complete the "BugZero Checklist".

@NJ-2020

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

fix session expired page sign in link #51852

If no regressions arise, payment will be issued on 2024-11-13. 🎊

For reference, here are some details about the assignees on this issue:

@NJ-2020 requires payment automatic offer (Contributor)
@aimane-chnaif requires payment automatic offer (Reviewer)

@aimane-chnaif

@aimane-chnaif @CortneyOfstad The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

BugZero Checklist:

[Contributor] Classify the bug:

Bug classification

Source of bug:

1a. Result of the original design (eg. a case wasn't considered)
1b. Mistake during implementation
1c. Backend bug
1z. Other:

Where bug was reported:

2a. Reported on production
2b. Reported on staging (deploy blocker)
2c. Reported on a PR
2z. Other:

Who reported the bug:

[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

Link to comment: https://github.com/Expensify/App/pull/48007/files#r1830232657
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

Link to issue:

Regression Test Proposal

Precondition:

N/A

Test:

Sign in on OD
Click support > Concierge
Copy the transition link and close the tab
Logout on ND
Wait for 1 or 2 minute to wait until the auth token expired
Paste the transition link on ND
Click the "Please sign in again".
Verify that it got redirected to the sign in page

Do we agree 👍 or 👎

@aimane-chnaif

Thank you @aimane-chnaif!

@NJ-2020

Payment Summary

@NJ-2020 — paid $250 via Upwork
@aimane-chnaif — paid $250 via Upwork

Regression Test

https://github.com/Expensify/Expensify/issues/443985

Navigation Menu

Repository navigation

[HOLD for payment 2024-11-13] [$250] Clicking " Please sign in again" does nothing in "Session Expired" page #51546

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

23 remaining items

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

Payment Summary

Regression Test

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	Navigation.isNavigationReady().then(() => {
	// We must call goBack() to remove the /transition route from history
	Navigation.goBack();
	Navigation.navigate(ROUTES.HOME);

	if (!NativeModules.HybridAppModule) {
	Session.clearSignInData();
	Navigation.navigate();
	return;
	}

	<RootStack.Screen
	name={NAVIGATORS.BOTTOM_TAB_NAVIGATOR}
	options={defaultScreenOptions}
	component={NativeModules.HybridAppModule ? SessionExpiredPage : SignInPage}
	/>
	<RootStack.Screen
	name={SCREENS.TRANSITION_BETWEEN_APPS}
	options={defaultScreenOptions}
	component={LogInWithShortLivedAuthTokenPage}
	/>

[HOLD for payment 2024-11-13] [$250] Clicking " Please sign in again" does nothing in "Session Expired" page #51546

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

MelvinBot commented on Oct 28, 2024

melvin-bot commented on Oct 28, 2024

NJ-2020 commented on Oct 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

Result

What alternative solutions did you explore? (Optional)

CortneyOfstad commented on Oct 28, 2024

melvin-bot commented on Oct 28, 2024

23 remaining items

NJ-2020 commented on Nov 4, 2024

melvin-bot commented on Nov 6, 2024

melvin-bot commented on Nov 6, 2024

melvin-bot commented on Nov 6, 2024

aimane-chnaif commented on Nov 6, 2024

BugZero Checklist:

Regression Test Proposal

Precondition:

Test:

CortneyOfstad commented on Nov 12, 2024

CortneyOfstad commented on Nov 13, 2024

Payment Summary

Regression Test

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions