You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-11-11] [Custom feeds] The freeform fields have incorrect limit #51564
Reported here - find more details in the slack thread.
BUG: When adding a commercial feed, freeform fields do not have the field length limit discussed in the design document. They should all be capped at 100 characters.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Issue is ready for payment but no BZ is assigned. @sakluger you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
@mountiny , in #51948 we again updated the behaviour to show error if the length is more than 100 characters, the PR linked to this issue had limited the text to 100 characters. So regression test would be outdated for this issue, i will complete the checklist now LMK what should be done with regression test
Activity
melvin-bot commentedon Oct 28, 2024
Triggered auto assignment to @abekkala (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.VickyStash commentedon Oct 28, 2024
Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
VickyStash commentedon Oct 28, 2024
The PR has been opened for the review!
5 remaining items
melvin-bot commentedon Nov 4, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-11. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 4, 2024
@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Nov 11, 2024
Issue is ready for payment but no BZ is assigned. @sakluger you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Nov 11, 2024
Payment Summary
Upwork Job
BugZero Checklist (@sakluger)
mountiny commentedon Nov 11, 2024
@allgandalf could you please complete the checklist? thanks!
sakluger commentedon Nov 12, 2024
I sent an offer via Upwork. Now we're just waiting for the checklist to be completed and for the offer to be accepted.
allgandalf commentedon Nov 12, 2024
@mountiny , in #51948 we again updated the behaviour to show error if the length is more than 100 characters, the PR linked to this issue had limited the text to 100 characters. So regression test would be outdated for this issue, i will complete the checklist now LMK what should be done with regression test
The PR that introduced the bug has been identified. Link to the PR: Feat: Add company card feed flow #48119
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/48119/files#r1837706385
mountiny commentedon Nov 12, 2024
@allgandalf we can handle the test in #51899
sakluger commentedon Nov 12, 2024
Thank you! I paid the contract, we're all done here.