Repository navigation
[Custom feeds] Land on the pending feed page after creating a second feed #51567
Description
Reported in Slack here - check for more details
BUG: After adding a second card feed, you're supposed to land on the feed pending screen for the second feed. Instead you land back on the first feed. Shown in 🧵
Issue Owner
Current Issue Owner: @allgandalfMetadata
Metadata
Assignees
Type
Projects
- Status
Activity
melvin-bot commentedon Oct 28, 2024
Triggered auto assignment to @garrettmknight (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.koko57 commentedon Oct 28, 2024
I would like to help with this issue 🙂
mountiny commentedon Oct 28, 2024
no payments will be needed
koko57 commentedon Oct 29, 2024
Working on this today. I've noticed that we have no loading state like we just applied in the Expensify card when making the call to API - maybe we should add one? And Error handling?
Screen.Recording.2024-10-29.at.19.05.56.mov
8 remaining items
melvin-bot commentedon Nov 7, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-14. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Nov 7, 2024
@allgandalf The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
melvin-bot commentedon Nov 14, 2024
Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!
melvin-bot commentedon Nov 14, 2024
Payment Summary
Upwork Job
BugZero Checklist (@lschurr)
lschurr commentedon Nov 14, 2024
Checked with @mountiny on this one - we will handle payments once the custom feeds project is done. @allgandalf could you work on the checklist? #51567 (comment)
mountiny commentedon Nov 14, 2024
Yes, thanks! once the checklist is done, we can close
[-][HOLD for payment 2024-11-14] [Custom feeds] Land on the pending feed page after creating a second feed [/-][+][Custom feeds] Land on the pending feed page after creating a second feed [/+]allgandalf commentedon Nov 17, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: N/A, there is no offending PR, we never updated Onyx data for the API untill this issue.
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify that : After adding a new feed the pending page is displayed for that newly added feed feed
Do we agree 👍 or 👎
mountiny commentedon Nov 18, 2024
I think these tests will be handled by testing added by @joekaufmanexpensify for the project. I am going to close this as we will handle the payments together later for the project. Thanks for the rest for the checklist