Skip to content

[Due for payment 2025-02-28] [$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed #51574

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.54
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5121232&group_by=cases:section_id&group_order=asc&group_id=294998
Issue reported by: Applause - Internal Team

Action Performed:

  1. Start the Submit expense flow in a 1:1 conversation with a user you have access to
  2. Select the scan option
  3. Upload a picture that will fail the scan process
  4. Wait for the scan to fail
  5. Log in as the other account
  6. Navigate to the IOU that failed the scan
  7. Verify the receiver is not asked to fill out the missing information

Expected Result:

The receiving end of the IOU should not be asked to fill out information if the scan failed

Actual Result:

The receiving end of the IOU is asked to fill out information if the scan failed but can't

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
2.New.Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021854642765194540226
  • Upwork Job ID: 1854642765194540226
  • Last Price Increase: 2024-11-14
  • Automatic offers:
    • FitseTLT | Contributor | 105019830
Issue OwnerCurrent Issue Owner: @alexpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 28, 2024
  2. melvin-bot commented on Oct 28, 2024

    @melvin-bot

    Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Oct 28, 2024

    @lanitochka17
    Author

    @alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. FitseTLT commented on Oct 28, 2024

    @FitseTLT
    Contributor

    Proposal

    Please re-state the problem that we are trying to solve in this issue.

    1:1 Submit expense - Scan failure should not ask receiver to enter information

    What is the root cause of that problem?

    We are displaying the same Enter an amount text for both side of the users

    translationPath: 'common.error.enterAmount',

    What changes do you think we should make in order to solve the problem?

    We should display this copy only if the user canEditAmount and add another appropriate copy (like No amount set yet) and display it when the user can't modify the amount

                        translationPath: canEditAmount ? 'common.error.enterAmount' : 'common.error.noAmount',
    
    

    We should do the same enterDate and enterMerchant

    What alternative solutions did you explore? (Optional)

    Optionally we can also avoid displaying the error for the receiving end

  5. alexpensify commented on Oct 31, 2024

    @alexpensify
    Contributor

    Adding to my testing list, I'll review this one soon.

  6. alexpensify commented on Nov 5, 2024

    @alexpensify
    Contributor

    No update yet

  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 7, 2024
  8. changed the title [-]1:1 Submit expense - Scan failure does not ask receiver to enter information[/-] [+][$250] 1:1 Submit expense - Scan failure does not ask receiver to enter information[/+] on Nov 7, 2024
  9. melvin-bot commented on Nov 7, 2024

    @melvin-bot
  10. 94 remaining items

  11. changed the title [-][$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed[/-] [+][Due for payment 2025-02-28] [$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed[/+] on Feb 21, 2025
  12. melvin-bot commented on Feb 21, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Feb 21, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-02-28. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Feb 21, 2025

    @melvin-bot

    @getusha @alexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. alexpensify commented on Mar 4, 2025

    @alexpensify
    Contributor

    Contributor: @FitseTLT paid $250 via Upwork
    Contributor+: @getusha owed $250 via NewDot - please submit a request in Chat

  16. moved this from Bugs and Follow Up Issues to Done in #expensify-bugson Mar 4, 2025
  17. garrettmknight commented on Apr 10, 2025

    @garrettmknight
    Contributor

    $250 approved for @getusha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions