You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2025-02-28] [$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed #51574
@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
What changes do you think we should make in order to solve the problem?
We should display this copy only if the user canEditAmount and add another appropriate copy (like No amount set yet) and display it when the user can't modify the amount
changed the title [-]1:1 Submit expense - Scan failure does not ask receiver to enter information[/-][+][$250] 1:1 Submit expense - Scan failure does not ask receiver to enter information[/+]on Nov 7, 2024
changed the title [-][$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed[/-][+][Due for payment 2025-02-28] [$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed[/+]on Feb 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@getusha@alexpensify@getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
Activity
melvin-bot commentedon Oct 28, 2024
Triggered auto assignment to @alexpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Oct 28, 2024
@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
FitseTLT commentedon Oct 28, 2024
Proposal
Please re-state the problem that we are trying to solve in this issue.
1:1 Submit expense - Scan failure should not ask receiver to enter information
What is the root cause of that problem?
We are displaying the same
Enter an amounttext for both side of the usersApp/src/components/ReportActionItem/MoneyRequestView.tsx
Line 272 in c3dde46
What changes do you think we should make in order to solve the problem?
We should display this copy only if the user
canEditAmountand add another appropriate copy (likeNo amount set yet) and display it when the user can't modify the amountWe should do the same
enterDateandenterMerchantWhat alternative solutions did you explore? (Optional)
Optionally we can also avoid displaying the error for the receiving end
alexpensify commentedon Oct 31, 2024
Adding to my testing list, I'll review this one soon.
alexpensify commentedon Nov 5, 2024
No update yet
[-]1:1 Submit expense - Scan failure does not ask receiver to enter information[/-][+][$250] 1:1 Submit expense - Scan failure does not ask receiver to enter information[/+]melvin-bot commentedon Nov 7, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021854642765194540226
94 remaining items
[-][$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed[/-][+][Due for payment 2025-02-28] [$250] 1:1 Submit expense - The receiving end of the IOU should not be asked to fill out information if the scan failed[/+]melvin-bot commentedon Feb 21, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Feb 21, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-02-28. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Feb 21, 2025
@getusha @alexpensify @getusha The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
alexpensify commentedon Mar 4, 2025
Contributor: @FitseTLT paid $250 via Upwork
Contributor+: @getusha owed $250 via NewDot - please submit a request in Chat
garrettmknight commentedon Apr 10, 2025
$250 approved for @getusha