[$250] [HOLD for payment 2024-11-13] Wallet - Deactivated card is not removed from Wallet when it is deactivated in Wallet page

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!

Version Number: 9.0.55-6
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes - iOS
Email or phone of affected tester (no customers): applausetester+kh2210001@applause.expensifail.com
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Go to staging.new.expensify.com
Go to workspace settings > Members.
Click on your own profile.
Click Add card.
Assign a virtual card to yourself.
Go to Wallet.
Click on the card.
Click Report virtual card fraud.
Click Deactivate card.
Go back to members and click on your own profile.
Note that the deactivated card is removed.
Go to Wallet.
Note that the deactivated card is not removed.

Expected Result:

After the card is deactivated in Wallet, it should be removed in Wallet.

Actual Result:

After the card is deactivated in Wallet, it is removed from member profile and Expensify Card page but it still remains in Wallet.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Bug6650094_1730280094888.20241030_171420.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021856352075978124643
Upwork Job ID: 1856352075978124643
Last Price Increase: 2024-11-12

@joekaufmanexpensify

Triggered auto assignment to @joekaufmanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

We think this issue might be related to the #collect project.

Reproduced.

2024-10-30_17-29-49.mp4

@mountiny

@mountiny LMK if I should make this one external

discussed the solution here

Edited by proposal-police: This proposal was edited at 2024-10-31 08:52:47 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Card deactivated in Expensify Card page is not removed from member profile

What is the root cause of that problem?

When we call REPORT_VIRTUAL_EXPENSIFY_CARD_FRAUD API, we only clear the Onyx Form REPORT_VIRTUAL_CARD_FRAUD:

App/src/libs/actions/Card.ts

Lines 40 to 50 in aa6401d

    
           function reportVirtualExpensifyCardFraud(cardID: number) { 
        
               const optimisticData: OnyxUpdate[] = [ 
        
                   { 
        
                       onyxMethod: Onyx.METHOD.MERGE, 
        
                       key: ONYXKEYS.FORMS.REPORT_VIRTUAL_CARD_FRAUD, 
        
                       value: { 
        
                           isLoading: true, 
        
                       }, 
        
                   }, 
        
               ];

but in ReportVirtualCardFraudPage page, we use CARD_LIST which stores the user's cash card and imported cards (including the Expensify Card):

App/src/pages/settings/Wallet/ReportVirtualCardFraudPage.tsx

Line 31 in aa6401d

const [cardList] = useOnyx(ONYXKEYS.CARD_LIST);

This is the reason why the member is not removed from wallet.

What changes do you think we should make in order to solve the problem?

While calling Deactive card API we should also clear the CARD_LIST:

    const optimisticData: OnyxUpdate[] = [
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.FORMS.REPORT_VIRTUAL_CARD_FRAUD,
            value: {
                isLoading: true,
            },
        },
        {
            onyxMethod: Onyx.METHOD.MERGE,
            key: ONYXKEYS.CARD_LIST,
            value: {
                [cardID]: null,
            }
        }
    ];

Similarly if needed update failure data and if needed add success data. If we want then for offline case we can add offline feedback pattern as well, that can be decided during PR phase

If the same bug exists elsewhere we should look and fix there too.

@DylanDylann

This was not made external yet and @DylanDylann has worked on this project with us. Do you want to work on the PR?

Job added to Upwork: https://www.upwork.com/jobs/~021856352075978124643

@DylanDylann

Current assignee @DylanDylann is eligible for the External assigner, not assigning anyone new.

@DylanDylann

Only payment here is $250 to @DylanDylann for C+ review via Upwork.

@DylanDylann

@DylanDylann offer sent for $250!

Bumped in Slack

@joekaufmanexpensify

@joekaufmanexpensify All good now, thank you

Great, $250 sent and contract ended!

Upwork job closed

All set, thanks everyone!

Navigation Menu

Repository navigation

[$250] [HOLD for payment 2024-11-13] Wallet - Deactivated card is not removed from Wallet when it is deactivated in Wallet page #51738

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

15 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

	function reportVirtualExpensifyCardFraud(cardID: number) {
	const optimisticData: OnyxUpdate[] = [
	{
	onyxMethod: Onyx.METHOD.MERGE,
	key: ONYXKEYS.FORMS.REPORT_VIRTUAL_CARD_FRAUD,
	value: {
	isLoading: true,
	},
	},
	];

[$250] [HOLD for payment 2024-11-13] Wallet - Deactivated card is not removed from Wallet when it is deactivated in Wallet page #51738

Description

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

Activity

melvin-bot commented on Oct 30, 2024

izarutskaya commented on Oct 30, 2024

joekaufmanexpensify commented on Oct 30, 2024

joekaufmanexpensify commented on Oct 30, 2024

mountiny commented on Oct 31, 2024

twilight2294 commented on Oct 31, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

mountiny commented on Oct 31, 2024

15 remaining items

melvin-bot commented on Nov 12, 2024

melvin-bot commented on Nov 12, 2024

joekaufmanexpensify commented on Nov 12, 2024

joekaufmanexpensify commented on Nov 12, 2024

joekaufmanexpensify commented on Nov 13, 2024

DylanDylann commented on Nov 13, 2024

joekaufmanexpensify commented on Nov 13, 2024

joekaufmanexpensify commented on Nov 13, 2024

joekaufmanexpensify commented on Nov 13, 2024

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions