Skip to content

[HOLD for payment 2025-01-17] [$250] Android - Accounting-Export button with dropdown goes out of preview component while loading #51763

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.55-8
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): nathanmulugetatesting+1959@gmail.com
Issue reported by: Applause - Internal Team

Action Performed:

Pre-condition:

  • Workspace is connected to QBO or any of accounting integrations
  • An expense is submitted and paid
  1. Go to troubleshoot and clear cache and restart
  2. Open the workspace chat where the paid expense lives

Expected Result:

The export button with the dropdown doesn't get shown until chat history is fully loaded (Web behavior)

Actual Result:

The export button with the dropdown is visible with a weird loading status and the box goes out of the expense preview component

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6650549_1730314648141.Screen_Recording_20241030_214838.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021854228557201867351
  • Upwork Job ID: 1854228557201867351
  • Last Price Increase: 2025-01-01
  • Automatic offers:
    • wildan-m | Contributor | 105570789
Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 30, 2024
  2. melvin-bot commented on Oct 30, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. lanitochka17 commented on Oct 30, 2024

    @lanitochka17
    Author

    @JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

  4. melvin-bot commented on Nov 5, 2024

    @melvin-bot

    @JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...

  5. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 6, 2024
  6. changed the title [-]Android - Accounting-Export button with dropdown goes out of preview component while loading[/-] [+][$250] Android - Accounting-Export button with dropdown goes out of preview component while loading[/+] on Nov 6, 2024
  7. melvin-bot commented on Nov 6, 2024

    @melvin-bot
  8. added
    Help WantedApply this label when an issue is open to proposals by contributors
    on Nov 6, 2024
  9. melvin-bot commented on Nov 6, 2024

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

  10. JmillsExpensify commented on Nov 6, 2024

    @JmillsExpensify
    Contributor

    Not sure how important this is, though opening up to the community for creative ideas on the solution to this one.

  11. 78 remaining items

  12. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  13. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2025-01-17. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Jan 10, 2025

    @melvin-bot

    @parasharrajat @JmillsExpensify @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  15. moved this from Bugs and Follow Up Issues to Hold for Payment in #expensify-bugson Jan 14, 2025
  16. JmillsExpensify commented on Jan 17, 2025

    @JmillsExpensify
    Contributor

    Payment summary:

    @parasharrajat mind completing the BZ checklist when you get a chance?

  17. JmillsExpensify commented on Jan 17, 2025

    @JmillsExpensify
    Contributor

    Contributor paid out. I'm going to close this issue, and we'll circle back for payment/checklist/regression tests (if needed).

  18. moved this from Hold for Payment to Done in #expensify-bugson Jan 17, 2025
  19. parasharrajat commented on Jan 17, 2025

    @parasharrajat
    Member

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
    • 2b. Reported on staging (eg. found during regression or PR testing)
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/47243/files#r1920155337

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: Not needed

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Workspace is connected to QBO or any of accounting integrations
    • An expense is submitted and paid, ensure no other chat after creating the expense

    Test:

    1. Go to troubleshoot and clear cache and restart
    2. Open the workspace chat where the paid expense lives
    3. Tap on the newest report preview
    4. Back
    5. Verify that the button layout does not go out of the preview component.
    6. Try to log in again and load that chat to see the loading preview. (Steps from feat: show last message while loading others #47243 can be followed to see the loading preview).
    7. Verify that the button layout does not go out of the preview component.

    Do we agree 👍 or 👎

  20. parasharrajat commented on Jan 19, 2025

    @parasharrajat
    Member

    Payment requested as per #51763 (comment)

  21. mallenexpensify commented on Jan 22, 2025

    @mallenexpensify
    Contributor

    Contributor: @wildan-m paid $250 via Upwork
    Reviewer: @parasharrajat paid $250 via New Expensify

  22. JmillsExpensify commented on Jan 22, 2025

    @JmillsExpensify
    Contributor

    $250 approved for @parasharrajat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.DailyKSv2ExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions