You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2025-01-17] [$250] Android - Accounting-Export button with dropdown goes out of preview component while loading #51763
Version Number: 9.0.55-8 Reproducible in staging?: Y Reproducible in production?: Y If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Email or phone of affected tester (no customers):nathanmulugetatesting+1959@gmail.com Issue reported by: Applause - Internal Team
Action Performed:
Pre-condition:
Workspace is connected to QBO or any of accounting integrations
An expense is submitted and paid
Go to troubleshoot and clear cache and restart
Open the workspace chat where the paid expense lives
Expected Result:
The export button with the dropdown doesn't get shown until chat history is fully loaded (Web behavior)
Actual Result:
The export button with the dropdown is visible with a weird loading status and the box goes out of the expense preview component
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Android: Standalone
Android: HybridApp
Android: mWeb Chrome
iOS: Standalone
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidenceBug6650549_1730314648141.Screen_Recording_20241030_214838.mp4
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
changed the title [-]Android - Accounting-Export button with dropdown goes out of preview component while loading[/-][+][$250] Android - Accounting-Export button with dropdown goes out of preview component while loading[/+]on Nov 6, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
@parasharrajat@JmillsExpensify@parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Workspace is connected to QBO or any of accounting integrations
An expense is submitted and paid, ensure no other chat after creating the expense
Test:
Go to troubleshoot and clear cache and restart
Open the workspace chat where the paid expense lives
Tap on the newest report preview
Back
Verify that the button layout does not go out of the preview component.
Activity
melvin-bot commentedon Oct 30, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.lanitochka17 commentedon Oct 30, 2024
@JmillsExpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors
melvin-bot commentedon Nov 5, 2024
@JmillsExpensify Eep! 4 days overdue now. Issues have feelings too...
[-]Android - Accounting-Export button with dropdown goes out of preview component while loading[/-][+][$250] Android - Accounting-Export button with dropdown goes out of preview component while loading[/+]melvin-bot commentedon Nov 6, 2024
Job added to Upwork: https://www.upwork.com/jobs/~021854228557201867351
melvin-bot commentedon Nov 6, 2024
Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (
External)JmillsExpensify commentedon Nov 6, 2024
Not sure how important this is, though opening up to the community for creative ideas on the solution to this one.
78 remaining items
melvin-bot commentedon Jan 10, 2025
Reviewinglabel has been removed, please complete the "BugZero Checklist".melvin-bot commentedon Jan 10, 2025
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2025-01-17. 🎊
For reference, here are some details about the assignees on this issue:
melvin-bot commentedon Jan 10, 2025
@parasharrajat @JmillsExpensify @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]
JmillsExpensify commentedon Jan 17, 2025
Payment summary:
@parasharrajat mind completing the BZ checklist when you get a chance?
JmillsExpensify commentedon Jan 17, 2025
Contributor paid out. I'm going to close this issue, and we'll circle back for payment/checklist/regression tests (if needed).
parasharrajat commentedon Jan 17, 2025
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/47243/files#r1920155337
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: Not needed
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Do we agree 👍 or 👎
parasharrajat commentedon Jan 19, 2025
Payment requested as per #51763 (comment)
mallenexpensify commentedon Jan 22, 2025
Contributor: @wildan-m paid $250 via Upwork
Reviewer: @parasharrajat paid $250 via New Expensify
JmillsExpensify commentedon Jan 22, 2025
$250 approved for @parasharrajat