Skip to content

[HOLD for payment 2024-11-14] [$250] Can't edit the participant amounts on the confirmation page. #51802

Closed

Description

@m-natarajan

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.56-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Stand alone, Hybrid is not updated yet
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @rayane-djouah
Slack conversation (hyperlinked to channel name): https://expensify.slack.com/archives/C049HHMV9SM/p1730291235500129

Action Performed:

  1. Start a group
  2. Split money (e.g 9000)
  3. Enter the value in the BNP
  4. Click continue
  5. Try to edit the split amount

Expected Result:

Able to edit the participants amounts

Actual Result:

Unable to edit

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
381525247-7724c5c7-2174-499e-9070-07d2d3c19a21.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021852097521924704037
  • Upwork Job ID: 1852097521924704037
  • Last Price Increase: 2024-10-31
Issue OwnerCurrent Issue Owner: @jliexpensify

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 31, 2024
  2. github-actions commented on Oct 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  3. melvin-bot commented on Oct 31, 2024

    @melvin-bot

    Triggered auto assignment to @chiragsalian (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Oct 31, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. melvin-bot commented on Oct 31, 2024

    @melvin-bot

    Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  6. s77rt commented on Oct 31, 2024

    @s77rt
    Member

    Same root cause as #51800

  7. 16 remaining items

  8. s77rt commented on Nov 1, 2024

    @s77rt
    Member

    Reverting the PR

  9. added
    Awaiting PaymentAuto-added when associated PR is deployed to production
    and removed on Nov 7, 2024
  10. changed the title [-][$250] Can't edit the participant amounts on the confirmation page.[/-] [+][HOLD for payment 2024-11-14] [$250] Can't edit the participant amounts on the confirmation page.[/+] on Nov 7, 2024
  11. melvin-bot commented on Nov 7, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  12. melvin-bot commented on Nov 7, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.58-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-14. 🎊

    For reference, here are some details about the assignees on this issue:

    • @mollfpr requires payment through NewDot Manual Requests
    • @rayane-djouah requires payment (Needs manual offer from BZ)
  13. melvin-bot commented on Nov 7, 2024

    @melvin-bot

    @mollfpr @jliexpensify The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

  14. jliexpensify commented on Nov 8, 2024

    @jliexpensify
    Contributor

    @mollfpr just to confirm: no payments needed here as its a regression?

  15. mollfpr commented on Nov 8, 2024

    @mollfpr
    Contributor

    @mollfpr just to confirm: no payments needed here as its a #51802 (comment)

    @jliexpensify Yes!

  16. jliexpensify commented on Nov 8, 2024

    @jliexpensify
    Contributor

    Thanks! I assume no checklist needed either?

  17. mollfpr commented on Nov 8, 2024

    @mollfpr
    Contributor

    Yes, it shouldn't need a checklist.

  18. jliexpensify commented on Nov 14, 2024

    @jliexpensify
    Contributor

    Great thanks, closing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionBugSomething is broken. Auto assigns a BugZero manager.EngineeringExternalAdded to denote the issue can be worked on by a contributorHelp WantedApply this label when an issue is open to proposals by contributorsWeeklyKSv2

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions