You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
mWeb - BA - On tapping "next" in manually enter bank account page, user directed to continue setup #51823
Version Number: 9.0.56-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
So it's not the blink, i think the description could be clearer.
Basically, when you are on the "Manually add your bank account" pane (usually gotten to by clicking "continue setup" or by clicking "back" from the Personal info pane), when you click next you should be brought to the Personal info pane, NOT the Continue Setup pane. This is the behavior that's wrong here.
It might also be a bug that existed before but was unearthed by this PR - the personal-information pane doesn't actually exist in the list of steps, so I think the logic doesn't know where to go from the new page...
Activity
melvin-bot commentedon Oct 31, 2024
Triggered auto assignment to @dangrous (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Oct 31, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Oct 31, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
lanitochka17 commentedon Oct 31, 2024
Production:
Screen_Recording_20241031_203922_Chrome.mp4
dangrous commentedon Oct 31, 2024
Traced it to #51315 - looking to see if we can maybe fix without reverting
dangrous commentedon Oct 31, 2024
it's specifically this useEffect - I'm not sure what that was added for so I hesitate just to remove
EDIT: it's this line
App/src/pages/ReimbursementAccount/ReimbursementAccountPage.tsx
Line 209 in 4bf4988
Nodebrute commentedon Oct 31, 2024
@dangrous I am unable to repro this on the latest main. The weird blink you see is linked to an open issue: #51799
Screen.Recording.2024-11-01.at.12.18.10.AM.mov
dangrous commentedon Oct 31, 2024
So it's not the blink, i think the description could be clearer.
Basically, when you are on the "Manually add your bank account" pane (usually gotten to by clicking "continue setup" or by clicking "back" from the Personal info pane), when you click next you should be brought to the Personal info pane, NOT the Continue Setup pane. This is the behavior that's wrong here.
Nodebrute commentedon Oct 31, 2024
Ah, right 😅
dangrous commentedon Oct 31, 2024
It might also be a bug that existed before but was unearthed by this PR - the
personal-informationpane doesn't actually exist in the list of steps, so I think the logic doesn't know where to go from the new page...DylanDylann commentedon Nov 1, 2024
I am checking
mountiny commentedon Nov 1, 2024
The offending Pr is reverted, we can close now and make sure its addressed with the PR going again