Skip to content

mWeb - BA - On tapping "next" in manually enter bank account page, user directed to continue setup #51823

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.56-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

  1. Go to https://staging.new.expensify.com/home
  2. Tap profile icon -- workspaces-- workspace
  3. Tap more features - enable workflow
  4. Tap workflow in workspace settings
  5. Tap connect bank account
  6. Complete the flow using region bank - selecting account ending 1111
  7. Note user directed to continue set up page instead of "manually add bank account page"
  8. Navigate to settings and tap connect bank - continue set up
  9. On tapping next on manually enter bank account page, user directed to continue set up page again
  10. When we revisit the page by tapping next, user directed to personal information page

Expected Result:

On tapping "next" in manually enter bank account page, user must not be directed to continue set up page

Actual Result:

On tapping "next" in manually enter bank account page, user directed to continue set up page again instead personal information page.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6651325_1730392361910.Screenrecorder-2024-10-31-21-49-32-126_compress_1.mp4

View all open jobs on GitHub

Activity

  1. melvin-bot commented on Oct 31, 2024

    @melvin-bot

    Triggered auto assignment to @dangrous (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  2. melvin-bot commented on Oct 31, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  3. github-actions commented on Oct 31, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. lanitochka17 commented on Oct 31, 2024

    @lanitochka17
    Author

    Production:

    Screen_Recording_20241031_203922_Chrome.mp4
  5. dangrous commented on Oct 31, 2024

    @dangrous
    Contributor

    Traced it to #51315 - looking to see if we can maybe fix without reverting

  6. dangrous commented on Oct 31, 2024

    @dangrous
    Contributor

    it's specifically this useEffect - I'm not sure what that was added for so I hesitate just to remove

    EDIT: it's this line

    setShouldShowContinueSetupButton(getShouldShowContinueSetupButtonInitialValue());

  7. Nodebrute commented on Oct 31, 2024

    @Nodebrute
    Contributor

    @dangrous I am unable to repro this on the latest main. The weird blink you see is linked to an open issue: #51799

    Screen.Recording.2024-11-01.at.12.18.10.AM.mov
  8. dangrous commented on Oct 31, 2024

    @dangrous
    Contributor

    So it's not the blink, i think the description could be clearer.

    Basically, when you are on the "Manually add your bank account" pane (usually gotten to by clicking "continue setup" or by clicking "back" from the Personal info pane), when you click next you should be brought to the Personal info pane, NOT the Continue Setup pane. This is the behavior that's wrong here.

  9. Nodebrute commented on Oct 31, 2024

    @Nodebrute
    Contributor

    Ah, right 😅

  10. dangrous commented on Oct 31, 2024

    @dangrous
    Contributor

    It might also be a bug that existed before but was unearthed by this PR - the personal-information pane doesn't actually exist in the list of steps, so I think the logic doesn't know where to go from the new page...

  11. DylanDylann commented on Nov 1, 2024

    @DylanDylann
    Contributor

    I am checking

  12. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Nov 1, 2024
  13. mountiny commented on Nov 1, 2024

    @mountiny
    Contributor

    The offending Pr is reverted, we can close now and make sure its addressed with the PR going again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions