Skip to content

[HOLD for payment 2024-11-13][$250] [Performance] HybridApp iOS: Firebase crash - facebook::jsi::JSError #51853

Closed

Description

@muttmuure

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


What performance issue do we need to solve?

Firebase crash here:

https://console.firebase.google.com/u/0/project/expensify-mobile-app/crashlytics/app/ios:com.expensify.expensifylite/issues/6c81436592b37f898c07cab55a30a83a?time=last-seven-days&types=crash&versions=9.0.56%20(9.0.56.0)&sessionEventKey=e05c506c93834ffb8281b148f87b6459_2010479564232592518

What is the impact of this on end-users?

Reported here: https://expensify.slack.com/archives/C05LX9D6E07/p1730395726205249

List any benchmarks that show the severity of the issue

14 sessions so far

Proposed solution (if any)

Please list out the steps you think we should take to solve this issue.

Investigate and fix

List any benchmarks after implementing the changes to show impacts of the proposed solution (if any)

Note: These should be the same as the benchmarks collected before any changes.

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on Upwork

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021852337274739729797
  • Upwork Job ID: 1852337274739729797
  • Last Price Increase: 2024-11-01
Issue OwnerCurrent Issue Owner: @ZhenjaHorbach

Activity

  1. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Auto-assigning issues to engineers is no longer supported. If you think this issue should receive engineering attention, please raise it in #whatsnext.

  2. added
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    DeployBlockerIndicates it should block deploying the API
    on Nov 1, 2024
  3. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Triggered auto assignment to @arosiclair (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. mountiny commented on Nov 1, 2024

    @mountiny
    Contributor
    Fatal Exception: facebook::jsi::JSError
    Exception in HostFunction: Unhandled JS Exception: RangeError: Maximum call stack size exceeded This error is located at: in ReportIDsContextProvider in ActiveWorkspaceContextProvider in Ac..., stack: getRootParentReport@1:2745489 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:2745520 getRootParentReport@1:274552
    
  7. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Nov 1, 2024
  8. melvin-bot commented on Nov 1, 2024

    @melvin-bot
  9. 21 remaining items

  10. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    Reviewing label has been removed, please complete the "BugZero Checklist".

  11. melvin-bot commented on Nov 4, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.56-9 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-11. 🎊

    For reference, here are some details about the assignees on this issue:

  12. changed the title [-][HOLD for payment 2024-11-11] [$250] [Performance] HybridApp iOS: Firebase crash - facebook::jsi::JSError[/-] [+][HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] [$250] [Performance] HybridApp iOS: Firebase crash - facebook::jsi::JSError[/+] on Nov 6, 2024
  13. melvin-bot commented on Nov 6, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.57-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-13. 🎊

    For reference, here are some details about the assignees on this issue:

  14. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    Issue is ready for payment but no BZ is assigned. @lschurr you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

  15. melvin-bot commented on Nov 13, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    BugZero Checklist (@lschurr)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1852337274739729797/hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  16. lschurr commented on Nov 13, 2024

    @lschurr
    Contributor

    @ZhenjaHorbach - please accept the offer in Upwork

  17. changed the title [-][HOLD for payment 2024-11-13] [HOLD for payment 2024-11-11] [$250] [Performance] HybridApp iOS: Firebase crash - facebook::jsi::JSError[/-] [+][HOLD for payment 2024-11-13][$250] [Performance] HybridApp iOS: Firebase crash - facebook::jsi::JSError[/+] on Nov 13, 2024
  18. added and removed on Nov 13, 2024
  19. lschurr commented on Nov 13, 2024

    @lschurr
    Contributor

    All set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Awaiting PaymentAuto-added when associated PR is deployed to productionDailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions