You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[HOLD for payment 2024-11-18] [Workspace feeds] Company Cards - Bank name persists between different banks in the Other card feed #51860
Version Number: 9.0.56-2 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: N/A Issue reported by: Applause - Internal Team
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Company cards enabled
Test:
Open the app > Navigate to Workspace settings > Company cards
Navigate to Add company cards - Other - Mastercard Commercial Cards - Next
Enter any text for the "Name of bank"
Tap on the "Next" button
Navigate back to the screen where "Mastercard Commercial Cards" and "Visa Commercial Cards" are visible
Activity
melvin-bot commentedon Nov 1, 2024
Triggered auto assignment to @JmillsExpensify (
Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.melvin-bot commentedon Nov 1, 2024
Triggered auto assignment to @tylerkaraszewski (
DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.melvin-bot commentedon Nov 1, 2024
💬 A slack conversation has been started in #expensify-open-source
github-actions commentedon Nov 1, 2024
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
28 remaining items
melvin-bot commentedon Nov 11, 2024
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2024-11-18. 🎊
For reference, here are some details about the assignees on this issue:
allgandalf commentedon Nov 17, 2024
BugZero Checklist:
Bug classification
Source of bug:
Where bug was reported:
Who reported the bug:
[Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.
Link to comment: https://github.com/Expensify/App/pull/48119/files#r1845487311
[Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.
Link to discussion: N/A
[Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.
[BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.
Link to issue:
Regression Test Proposal
Precondition:
Test:
Verify that bank name field is empty
Do we agree 👍 or 👎
melvin-bot commentedon Nov 18, 2024
Payment Summary
Upwork Job
BugZero Checklist (@JmillsExpensify)
mountiny commentedon Nov 18, 2024
Should we add a regression test for this? @JmillsExpensify if not, we can close this as payments will be handled in lumpsum
JmillsExpensify commentedon Nov 19, 2024
I think we should add a regression test for this one.
mountiny commentedon Nov 20, 2024
@JmillsExpensify there is one proposed from @allgandalf so I think we can go ahead with that one
JmillsExpensify commentedon Nov 20, 2024
Ah haha sorry I missed it in the scroll. I'll add.
JmillsExpensify commentedon Nov 20, 2024
@allgandalf are you being paid a lump sum for this project?
allgandalf commentedon Nov 21, 2024
Yes yes, no payment here @JmillsExpensify 🙇
JmillsExpensify commentedon Nov 21, 2024
Awesome thanks!