Skip to content

[HOLD for payment 2024-11-18] [Workspace feeds] Company Cards - Bank name persists between different banks in the Other card feed #51860

Closed

Description

@lanitochka17

If you haven’t already, check out our contributing guidelines for onboarding and email contributors@expensify.com to request to join our Slack channel!


Version Number: 9.0.56-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Issue found when executing PR #51569

Action Performed:

  1. Open the app
  2. Log in with an expensify account that's an admin of a workspace with "Company Cards" enabled
  3. Navigate to Workspace settings - Company cards
  4. Navigate to Add company cards - Other - Mastercard Commercial Cards - Next
  5. Enter any text for the "Name of bank"
  6. Tap on the "Next" button
  7. Navigate back to the screen where "Mastercard Commercial Cards" and "Visa Commercial Cards" are visible
  8. Tap on "Visa Commercial Cards" - Next - Next

Expected Result:

Bank name should be cleared when choosing a different bank

Actual Result:

Bank name persists between different banks in the "Other" card feed

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6651888_1730441823181.MGTM7335.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @JmillsExpensify

Activity

  1. added
    BugSomething is broken. Auto assigns a BugZero manager.
    DeployBlockerCashThis issue or pull request should block deployment
    and removed
    BugSomething is broken. Auto assigns a BugZero manager.
    on Nov 1, 2024
  2. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

  3. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    Triggered auto assignment to @tylerkaraszewski (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. melvin-bot commented on Nov 1, 2024

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  5. github-actions commented on Nov 1, 2024

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  6. 28 remaining items

  7. melvin-bot commented on Nov 11, 2024

    @melvin-bot

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.59-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2024-11-18. 🎊

    For reference, here are some details about the assignees on this issue:

  8. allgandalf commented on Nov 17, 2024

    @allgandalf
    Contributor

    BugZero Checklist:

    • [Contributor] Classify the bug:
    Bug classification

    Source of bug:

    • 1a. Result of the original design (eg. a case wasn't considered)
    • 1b. Mistake during implementation
    • 1c. Backend bug
    • 1z. Other:

    Where bug was reported:

    • 2a. Reported on production
    • 2b. Reported on staging (deploy blocker)
    • 2c. Reported on both staging and production
    • 2d. Reported on a PR
    • 2z. Other:

    Who reported the bug:

    • 3a. Expensify user
    • 3b. Expensify employee
    • 3c. Contributor
    • 3d. QA
    • 3z. Other:
    • [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

      Link to comment: https://github.com/Expensify/App/pull/48119/files#r1845487311

    • [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

      Link to discussion: N/A

    • [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

    • [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

      Link to issue:

    Regression Test Proposal

    Precondition:

    • Company cards enabled

    Test:

    1. Open the app > Navigate to Workspace settings > Company cards
    2. Navigate to Add company cards - Other - Mastercard Commercial Cards - Next
    3. Enter any text for the "Name of bank"
    4. Tap on the "Next" button
    5. Navigate back to the screen where "Mastercard Commercial Cards" and "Visa Commercial Cards" are visible
    6. Tap on "Visa Commercial Cards" > Next > Next

    Verify that bank name field is empty

    Do we agree 👍 or 👎

  9. melvin-bot commented on Nov 18, 2024

    @melvin-bot

    Payment Summary

    Upwork Job

    • Contributor: @narefyev91 is from an agency-contributor and not due payment
    • ROLE: @allgandalf paid $(AMOUNT) via Upwork (LINK)

    BugZero Checklist (@JmillsExpensify)

    • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
    • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
    • I have paid out the Upwork contracts or cancelled the ones that are incorrect
    • I have verified the payment summary above is correct
  10. mountiny commented on Nov 18, 2024

    @mountiny
    Contributor

    Should we add a regression test for this? @JmillsExpensify if not, we can close this as payments will be handled in lumpsum

  11. JmillsExpensify commented on Nov 19, 2024

    @JmillsExpensify
    Contributor

    I think we should add a regression test for this one.

  12. mountiny commented on Nov 20, 2024

    @mountiny
    Contributor

    @JmillsExpensify there is one proposed from @allgandalf so I think we can go ahead with that one

  13. JmillsExpensify commented on Nov 20, 2024

    @JmillsExpensify
    Contributor

    Ah haha sorry I missed it in the scroll. I'll add.

  14. JmillsExpensify commented on Nov 20, 2024

    @JmillsExpensify
    Contributor

    @allgandalf are you being paid a lump sum for this project?

  15. allgandalf commented on Nov 21, 2024

    @allgandalf
    Contributor

    @allgandalf are you being paid a lump sum for this project?

    Yes yes, no payment here @JmillsExpensify 🙇

  16. JmillsExpensify commented on Nov 21, 2024

    @JmillsExpensify
    Contributor

    Awesome thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions